From 545053856367b7ac42f556c113a23252d3e55c5a Mon Sep 17 00:00:00 2001 From: Nicholas Seckar Date: Sat, 4 Feb 2006 23:59:37 +0000 Subject: Don't let arbitrary classes match as controllers git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de --- actionpack/test/controller/fake_controllers.rb | 2 ++ actionpack/test/controller/routing_test.rb | 9 ++++++++- 2 files changed, 10 insertions(+), 1 deletion(-) (limited to 'actionpack/test/controller') diff --git a/actionpack/test/controller/fake_controllers.rb b/actionpack/test/controller/fake_controllers.rb index 8c626acab3..5f958b2845 100644 --- a/actionpack/test/controller/fake_controllers.rb +++ b/actionpack/test/controller/fake_controllers.rb @@ -2,6 +2,8 @@ class << Object; alias_method :const_available?, :const_defined?; end class ContentController < Class.new(ActionController::Base) end +class NotAController +end module Admin class << self; alias_method :const_available?, :const_defined?; end class UserController < Class.new(ActionController::Base); end diff --git a/actionpack/test/controller/routing_test.rb b/actionpack/test/controller/routing_test.rb index daf2c8e5ed..b570909641 100644 --- a/actionpack/test/controller/routing_test.rb +++ b/actionpack/test/controller/routing_test.rb @@ -643,7 +643,7 @@ class RouteSetTests < Test::Unit::TestCase assert_equal ['/admin/stuff', []], rs.generate({:controller => 'stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'}) assert_equal ['/stuff', []], rs.generate({:controller => '/stuff'}, {:controller => 'admin/user', :action => 'list', :id => '10'}) end - + def test_ignores_leading_slash @rs.draw {|m| m.connect '/:controller/:action/:id'} test_default_setup @@ -802,6 +802,13 @@ class RouteSetTests < Test::Unit::TestCase assert results, "Recognition should have succeeded" assert_equal [], results['path'] end + + def test_non_controllers_cannot_be_matched + rs.draw do + rs.connect ':controller/:action/:id' + end + assert_nil rs.recognize_path(%w(not_a show 10)), "Shouldn't recognize non-controllers as controllers!" + end def test_paths_do_not_accept_defaults assert_raises(ActionController::RoutingError) do -- cgit v1.2.3