From 66d705b3e7c03f806f7481e0e6a1f157dcf86f83 Mon Sep 17 00:00:00 2001 From: schneems Date: Tue, 19 Jan 2016 11:45:34 -0600 Subject: [close #23084] Deprecated StrongParameters We can provide a more flexible upgrade experience by warning users they are using unsafe methods instead of forcing the safe API by deprecating before removal. This PR provides this functionality. --- actionpack/test/controller/required_params_test.rb | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'actionpack/test/controller/required_params_test.rb') diff --git a/actionpack/test/controller/required_params_test.rb b/actionpack/test/controller/required_params_test.rb index 168f64ce41..129a713564 100644 --- a/actionpack/test/controller/required_params_test.rb +++ b/actionpack/test/controller/required_params_test.rb @@ -65,4 +65,10 @@ class ParametersRequireTest < ActiveSupport::TestCase .require([:first_name, :title]) end end + + test "Deprecated method are deprecated" do + assert_deprecated do + ActionController::Parameters.new(foo: "bar").merge!({bar: "foo"}) + end + end end -- cgit v1.2.3 From 3f2ac413b7c455ca951944da510683f52cb964da Mon Sep 17 00:00:00 2001 From: schneems Date: Tue, 19 Jan 2016 11:53:27 -0600 Subject: Add methods to StrongParameters It's reasonable to expose different value readers. --- actionpack/test/controller/required_params_test.rb | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'actionpack/test/controller/required_params_test.rb') diff --git a/actionpack/test/controller/required_params_test.rb b/actionpack/test/controller/required_params_test.rb index 129a713564..b6efcd6f9a 100644 --- a/actionpack/test/controller/required_params_test.rb +++ b/actionpack/test/controller/required_params_test.rb @@ -66,7 +66,14 @@ class ParametersRequireTest < ActiveSupport::TestCase end end - test "Deprecated method are deprecated" do + test "value params" do + params = ActionController::Parameters.new(foo: "bar", dog: "cinco") + assert_equal ["bar", "cinco"], params.values + assert params.has_value?("cinco") + assert params.value?("cinco") + end + + test "Deprecated methods are deprecated" do assert_deprecated do ActionController::Parameters.new(foo: "bar").merge!({bar: "foo"}) end -- cgit v1.2.3