From 17424a7de15694432405f56f97424d50b2e908b5 Mon Sep 17 00:00:00 2001
From: John Hawthorn <john@hawthorn.email>
Date: Mon, 27 May 2019 15:35:08 -0700
Subject: Give HelperMethods module a name

---
 actionpack/lib/abstract_controller/helpers.rb | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

(limited to 'actionpack/lib')

diff --git a/actionpack/lib/abstract_controller/helpers.rb b/actionpack/lib/abstract_controller/helpers.rb
index 3913259ecc..8ff214f220 100644
--- a/actionpack/lib/abstract_controller/helpers.rb
+++ b/actionpack/lib/abstract_controller/helpers.rb
@@ -7,7 +7,7 @@ module AbstractController
     extend ActiveSupport::Concern
 
     included do
-      class_attribute :_helpers, default: Module.new
+      class_attribute :_helpers, default: define_helpers_module(self)
       class_attribute :_helper_methods, default: Array.new
     end
 
@@ -31,7 +31,7 @@ module AbstractController
       # independently of the child class's.
       def inherited(klass)
         helpers = _helpers
-        klass._helpers = Module.new { include helpers }
+        klass._helpers = define_helpers_module(klass, helpers)
         klass.class_eval { default_helper_module! } unless klass.anonymous?
         super
       end
@@ -170,6 +170,17 @@ module AbstractController
       end
 
       private
+        def define_helpers_module(klass, helpers = nil)
+          # In some tests inherited is called explicitly. In that case, just
+          # return the module from the first time it was defined
+          return klass.const_get(:HelperMethods) if klass.const_defined?(:HelperMethods, false)
+
+          mod = Module.new
+          klass.const_set(:HelperMethods, mod)
+          mod.include(helpers) if helpers
+          mod
+        end
+
         # Makes all the (instance) methods in the helper module available to templates
         # rendered through this controller.
         #
-- 
cgit v1.2.3


From 4ab00cfac0c5bda7b66c5f80c63a8e858d4eac02 Mon Sep 17 00:00:00 2001
From: John Hawthorn <john@hawthorn.email>
Date: Mon, 3 Jun 2019 17:20:20 -0700
Subject: Use file/line from call to helper_module

---
 actionpack/lib/abstract_controller/helpers.rb | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

(limited to 'actionpack/lib')

diff --git a/actionpack/lib/abstract_controller/helpers.rb b/actionpack/lib/abstract_controller/helpers.rb
index 8ff214f220..abb09456e0 100644
--- a/actionpack/lib/abstract_controller/helpers.rb
+++ b/actionpack/lib/abstract_controller/helpers.rb
@@ -61,12 +61,17 @@ module AbstractController
         meths.flatten!
         self._helper_methods += meths
 
+        location = caller_locations(1, 1).first
+        file, line = location.path, location.lineno
+
         meths.each do |meth|
-          _helpers.class_eval <<-ruby_eval, __FILE__, __LINE__ + 1
-            def #{meth}(*args, &blk)                               # def current_user(*args, &blk)
-              controller.send(%(#{meth}), *args, &blk)             #   controller.send(:current_user, *args, &blk)
-            end                                                    # end
-          ruby_eval
+          method_def = [
+            "def #{meth}(*args, &blk)",
+            "  controller.send(%(#{meth}), *args, &blk)",
+            "end"
+          ].join(";")
+
+          _helpers.class_eval method_def, file, line
         end
       end
 
-- 
cgit v1.2.3