From efd59ab38231eca1084e85aa990321599308757f Mon Sep 17 00:00:00 2001 From: Mike Virata-Stone Date: Thu, 11 Aug 2016 21:57:12 -0700 Subject: Remove dead code and ensure values are strings before calling gsub --- actionpack/lib/action_view/helpers/tag_helper.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'actionpack/lib/action_view') diff --git a/actionpack/lib/action_view/helpers/tag_helper.rb b/actionpack/lib/action_view/helpers/tag_helper.rb index 6b659a7c00..e39c58ca32 100644 --- a/actionpack/lib/action_view/helpers/tag_helper.rb +++ b/actionpack/lib/action_view/helpers/tag_helper.rb @@ -147,7 +147,6 @@ module ActionView elsif BOOLEAN_ATTRIBUTES.include?(key) attrs << %(#{key}="#{key}") if value elsif !value.nil? - final_value = value.is_a?(Array) ? value.join(" ") : value attrs << tag_option(key, value, escape) end end @@ -159,7 +158,7 @@ module ActionView if value.is_a?(Array) value = escape ? safe_join(value, " ") : value.join(" ") else - value = escape ? ERB::Util.html_escape(value) : value + value = escape ? ERB::Util.html_escape(value) : value.to_s end %(#{key}="#{value.gsub(/"/, '"'.freeze)}") end -- cgit v1.2.3