From 379ddf54c00723c816b0dd4aa78d0cd47f159772 Mon Sep 17 00:00:00 2001 From: Kasper Timm Hansen Date: Sun, 6 Sep 2015 17:42:57 +0200 Subject: Add commit method to share option normalization Remove the clutter to make PermanentCookieJar's one change stand out. --- actionpack/lib/action_dispatch/middleware/cookies.rb | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'actionpack/lib/action_dispatch') diff --git a/actionpack/lib/action_dispatch/middleware/cookies.rb b/actionpack/lib/action_dispatch/middleware/cookies.rb index d3e1887478..4a9b534212 100644 --- a/actionpack/lib/action_dispatch/middleware/cookies.rb +++ b/actionpack/lib/action_dispatch/middleware/cookies.rb @@ -422,19 +422,27 @@ module ActionDispatch def [](name) @parent_jar[name.to_s] end - end - class PermanentCookieJar < AbstractCookieJar # :nodoc: def []=(name, options) if options.is_a?(Hash) options.symbolize_keys! else - options = { :value => options } + options = { value: options } end - options[:expires] = 20.years.from_now + commit(options) @parent_jar[name] = options end + + private + def commit(options); end + end + + class PermanentCookieJar < AbstractCookieJar # :nodoc: + private + def commit(options) + options[:expires] = 20.years.from_now + end end class JsonSerializer # :nodoc: -- cgit v1.2.3