From 1a4f61307286702205fd32b3aa62c26c21c9cce3 Mon Sep 17 00:00:00 2001 From: Eileen Uchitelle Date: Tue, 29 Jan 2019 09:01:58 -0500 Subject: Rename methods and update docs This is a minor update to the named methods for the following: - s/desired_capabilities/capabilities - s/driver_options/capabilities Since they are all the same thing we should keep the name the same throughout the feature. Updated docs to match / be a little bit clearer Also updated the Gemfile for selenium-webdriver. --- actionpack/lib/action_dispatch/system_testing/driver.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'actionpack/lib/action_dispatch/system_testing/driver.rb') diff --git a/actionpack/lib/action_dispatch/system_testing/driver.rb b/actionpack/lib/action_dispatch/system_testing/driver.rb index f71736833c..25a09dd918 100644 --- a/actionpack/lib/action_dispatch/system_testing/driver.rb +++ b/actionpack/lib/action_dispatch/system_testing/driver.rb @@ -3,12 +3,12 @@ module ActionDispatch module SystemTesting class Driver # :nodoc: - def initialize(name, **options, &desired_capabilities) + def initialize(name, **options, &capabilities) @name = name @browser = Browser.new(options[:using]) @screen_size = options[:screen_size] @options = options[:options] - @desired_capabilities = desired_capabilities + @capabilities = capabilities end def use @@ -23,7 +23,7 @@ module ActionDispatch end def register - define_browser_capabilities(@browser.driver_options) + define_browser_capabilities(@browser.capabilities) Capybara.register_driver @name do |app| case @name @@ -34,8 +34,8 @@ module ActionDispatch end end - def define_browser_capabilities(driver_options) - @desired_capabilities.call(driver_options) if @desired_capabilities + def define_browser_capabilities(capabilities) + @capabilities.call(capabilities) if @capabilities end def browser_options -- cgit v1.2.3