From 943aa826a48c7db682e24f13cc93ed3298aa7e1a Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Mon, 12 Sep 2011 15:48:03 -0700 Subject: reduce dependencies of external objects in the Route class --- actionpack/lib/action_dispatch/routing/route.rb | 28 +++++++++++++------------ 1 file changed, 15 insertions(+), 13 deletions(-) (limited to 'actionpack/lib/action_dispatch/routing/route.rb') diff --git a/actionpack/lib/action_dispatch/routing/route.rb b/actionpack/lib/action_dispatch/routing/route.rb index 563adb02c4..76d18e4dd5 100644 --- a/actionpack/lib/action_dispatch/routing/route.rb +++ b/actionpack/lib/action_dispatch/routing/route.rb @@ -3,10 +3,15 @@ module ActionDispatch class Route #:nodoc: attr_reader :conditions, :path - def initialize(set, app, conditions, requirements, defaults, name, anchor) - @set = set - path = ::Rack::Mount::Strexp.new( - conditions[:path_info], requirements, SEPARATORS, anchor) + def initialize(valid_conditions, app, conditions, requirements, defaults, name, anchor) + @valid_conditions = valid_conditions + strexp = Journey::Router::Strexp.new( + conditions.delete(:path_info), + requirements, + SEPARATORS, + anchor) + + @path = Journey::Path::Pattern.new(strexp) @verbs = conditions[:request_method] || [] @@ -16,22 +21,19 @@ module ActionDispatch # :request_method represents the HTTP verb that matches this route. # # Here we munge values before they get sent on to rack-mount. - @conditions[:request_method] = %r[^#{verb}$] unless @verbs.empty? - @conditions[:path_info] = Rack::Mount::RegexpWithNamedGroups.new(path) - @conditions.delete_if{ |k,v| k != :path_info && !valid_condition?(k) } - end - - def verb - @verbs.join '|' + unless @verbs.empty? + @conditions[:request_method] = %r[^#{@verbs.join('|')}$] + end + @conditions.delete_if{ |k,v| !valid_condition?(k) } end def segment_keys - @segment_keys ||= conditions[:path_info].names.compact.map { |key| key.to_sym } + @segment_keys ||= path.names.compact.map { |key| key.to_sym } end private def valid_condition?(method) - segment_keys.include?(method) || @set.valid_conditions.include?(method) + segment_keys.include?(method) || @valid_conditions.include?(method) end end end -- cgit v1.2.3