From 3120b51de7d391d04eae5332b91c753d0643cbd4 Mon Sep 17 00:00:00 2001 From: Tinco Andringa Date: Fri, 1 Jul 2016 00:42:51 +0200 Subject: close hijacked i/o socket after use (fixes #25613) --- actioncable/test/connection/client_socket_test.rb | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'actioncable/test/connection/client_socket_test.rb') diff --git a/actioncable/test/connection/client_socket_test.rb b/actioncable/test/connection/client_socket_test.rb index 4af071b4da..fe9077ae7f 100644 --- a/actioncable/test/connection/client_socket_test.rb +++ b/actioncable/test/connection/client_socket_test.rb @@ -48,6 +48,20 @@ class ActionCable::Connection::ClientSocketTest < ActionCable::TestCase end end + test 'closes hijacked i/o socket at shutdown' do + skip if ENV['FAYE'].present? + + run_in_eventmachine do + connection = open_connection + + client = connection.websocket.send(:websocket) + client.instance_variable_get('@stream') + .instance_variable_get('@rack_hijack_io') + .expects(:close) + connection.close + end + end + private def open_connection env = Rack::MockRequest.env_for '/test', -- cgit v1.2.3