From ef2016f8885ccd30c37ca97e76786503325f4e81 Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Sun, 13 Aug 2017 21:41:05 +0900 Subject: Use frozen string literal in tasks/ --- .rubocop.yml | 1 + tasks/release.rb | 10 ++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index f1107acb93..f84014d83a 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -93,6 +93,7 @@ Style/FrozenStringLiteralComment: - 'actionview/**/*' - 'actionpack/**/*' - 'guides/**/*' + - 'tasks/**/*' Exclude: - 'actionview/test/**/*.builder' - 'actionview/test/**/*.ruby' diff --git a/tasks/release.rb b/tasks/release.rb index 6ff37fb415..aa8ba44c1a 100644 --- a/tasks/release.rb +++ b/tasks/release.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + FRAMEWORKS = %w( activesupport activemodel activerecord actionview actionpack activejob actionmailer actioncable activestorage railties ) FRAMEWORK_NAMES = Hash.new { |h, k| k.split(/(?<=active|action)/).map(&:capitalize).join(" ") } @@ -72,9 +74,9 @@ npm_version = version.gsub(/\./).with_index { |s, i| i >= 2 ? "-" : s } task gem => %w(update_versions pkg) do cmd = "" - cmd << "cd #{framework} && " unless framework == "rails" - cmd << "bundle exec rake package && " unless framework == "rails" - cmd << "gem build #{gemspec} && mv #{framework}-#{version}.gem #{root}/pkg/" + cmd += "cd #{framework} && " unless framework == "rails" + cmd += "bundle exec rake package && " unless framework == "rails" + cmd += "gem build #{gemspec} && mv #{framework}-#{version}.gem #{root}/pkg/" sh cmd end @@ -104,7 +106,7 @@ namespace :changelog do current_contents = File.read(fname) header = "## Rails #{version} (#{Date.today.strftime('%B %d, %Y')}) ##\n\n" - header << "* No changes.\n\n\n" if current_contents =~ /\A##/ + header += "* No changes.\n\n\n" if current_contents =~ /\A##/ contents = header + current_contents File.open(fname, "wb") { |f| f.write contents } end -- cgit v1.2.3