From e6effb247a8051d21c2e9bdeed6c48a511f16b28 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Mon, 6 Jul 2015 19:35:41 +0200 Subject: Removing unused matches? method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit @lifo I couldn’t find any use of documentation for this, so removed it for now. Was it just for testing? --- lib/action_cable/channel/base.rb | 6 ------ test/channel_test.rb | 3 --- test/server_test.rb | 3 --- 3 files changed, 12 deletions(-) diff --git a/lib/action_cable/channel/base.rb b/lib/action_cable/channel/base.rb index ee22db4e09..cf5f593a31 100644 --- a/lib/action_cable/channel/base.rb +++ b/lib/action_cable/channel/base.rb @@ -11,12 +11,6 @@ module ActionCable attr_reader :params, :connection delegate :logger, to: :connection - class << self - def matches?(identifier) - raise "Please implement #{name}#matches? method" - end - end - def initialize(connection, channel_identifier, params = {}) @connection = connection @channel_identifier = channel_identifier diff --git a/test/channel_test.rb b/test/channel_test.rb index 96987977ea..2a33237219 100644 --- a/test/channel_test.rb +++ b/test/channel_test.rb @@ -3,9 +3,6 @@ require 'test_helper' class ChannelTest < ActionCableTest class PingChannel < ActionCable::Channel::Base - def self.matches?(identifier) - identifier[:channel] == 'chat' && identifier[:user_id].to_i.nonzero? - end end class PingServer < ActionCable::Server::Base diff --git a/test/server_test.rb b/test/server_test.rb index 636fa37cf7..2d514091ff 100644 --- a/test/server_test.rb +++ b/test/server_test.rb @@ -3,9 +3,6 @@ require 'test_helper' class ServerTest < ActionCableTest class ChatChannel < ActionCable::Channel::Base - def self.matches?(identifier) - identifier[:channel] == 'chat' && identifier[:user_id].to_i.nonzero? - end end class ChatServer < ActionCable::Server::Base -- cgit v1.2.3