From df76eaa4f1619dfbc024235f444c602eb6d6775a Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Mon, 3 Dec 2018 19:57:27 +0900 Subject: Address "warning: shadowing outer local variable - parts" And hide the `READ_QUERY` internal constant. --- .../lib/active_record/connection_adapters/abstract_adapter.rb | 6 ++---- .../active_record/connection_adapters/mysql/database_statements.rb | 3 ++- .../connection_adapters/postgresql/database_statements.rb | 3 ++- .../lib/active_record/connection_adapters/sqlite3_adapter.rb | 3 ++- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb index 31a994292e..9d971d9e16 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb @@ -101,10 +101,8 @@ module ActiveRecord end def self.build_read_query_regexp(*parts) # :nodoc: - lambda do |*parts| - parts = parts.map { |part| /\A\s*#{part}/i } - Regexp.union(*parts) - end + parts = parts.map { |part| /\A\s*#{part}/i } + Regexp.union(*parts) end def initialize(connection, logger = nil, config = {}) # :nodoc: diff --git a/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb b/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb index 0ec9581c42..43e2f628dc 100644 --- a/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/mysql/database_statements.rb @@ -19,7 +19,8 @@ module ActiveRecord execute(sql, name).to_a end - READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp.call(:begin, :select, :set, :show, :release, :savepoint) # :nodoc: + READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp(:begin, :select, :set, :show, :release, :savepoint) # :nodoc: + private_constant :READ_QUERY def write_query?(sql) # :nodoc: !READ_QUERY.match?(sql) diff --git a/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb b/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb index c8bc339e61..2d5b592639 100644 --- a/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb @@ -67,7 +67,8 @@ module ActiveRecord end end - READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp.call(:select, :show, :set) # :nodoc: + READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp(:select, :show, :set) # :nodoc: + private_constant :READ_QUERY def write_query?(sql) # :nodoc: !READ_QUERY.match?(sql) diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb index 1bec8fbabd..615aa0d83e 100644 --- a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb @@ -209,7 +209,8 @@ module ActiveRecord # DATABASE STATEMENTS ====================================== #++ - READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp.call(:select) # :nodoc: + READ_QUERY = ActiveRecord::ConnectionAdapters::AbstractAdapter.build_read_query_regexp(:select) # :nodoc: + private_constant :READ_QUERY def write_query?(sql) # :nodoc: !READ_QUERY.match?(sql) -- cgit v1.2.3