From dccc23a503e461820603f3e6901f2321617e7018 Mon Sep 17 00:00:00 2001 From: Xavier Noria Date: Mon, 18 Jul 2016 10:41:39 +0200 Subject: deprecates the error_on_ignored_order_or_limit instance reader Albeit the previous existence of this method is not seen in the patch itself, the declaration mattr_accessor :error_on_ignored_order_or_limit, instance_writer: false was present before. It was removed recently in 210012f. --- activerecord/lib/active_record/core.rb | 4 ++++ activerecord/test/cases/batches_test.rb | 12 ++++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/activerecord/lib/active_record/core.rb b/activerecord/lib/active_record/core.rb index c46cafdd09..3e3a7679ac 100644 --- a/activerecord/lib/active_record/core.rb +++ b/activerecord/lib/active_record/core.rb @@ -86,6 +86,10 @@ module ActiveRecord self.error_on_ignored_order end + def error_on_ignored_order_or_limit + self.class.error_on_ignored_order_or_limit + end + def self.error_on_ignored_order_or_limit=(value) ActiveSupport::Deprecation.warn(<<-MSG.squish) The flag error_on_ignored_order_or_limit is deprecated. Limits are diff --git a/activerecord/test/cases/batches_test.rb b/activerecord/test/cases/batches_test.rb index 837ad76686..8a4c1bd615 100644 --- a/activerecord/test/cases/batches_test.rb +++ b/activerecord/test/cases/batches_test.rb @@ -587,7 +587,7 @@ class EachTest < ActiveRecord::TestCase end end - test 'error_on_ignored_order_or_limit= is deprecated' do + test '.error_on_ignored_order_or_limit= is deprecated' do begin prev = ActiveRecord::Base.error_on_ignored_order assert_deprecated 'Please use error_on_ignored_order= instead.' do @@ -599,11 +599,19 @@ class EachTest < ActiveRecord::TestCase end end - test 'error_on_ignored_order_or_limit is deprecated' do + test '.error_on_ignored_order_or_limit is deprecated' do expected = ActiveRecord::Base.error_on_ignored_order actual = assert_deprecated 'Please use error_on_ignored_order instead.' do ActiveRecord::Base.error_on_ignored_order_or_limit end assert_equal expected, actual end + + test '#error_on_ignored_order_or_limit is deprecated' do + expected = ActiveRecord::Base.error_on_ignored_order + actual = assert_deprecated 'Please use error_on_ignored_order instead.' do + Post.new.error_on_ignored_order_or_limit + end + assert_equal expected, actual + end end -- cgit v1.2.3