From dbf54339783c49b90450c4c6faaa05759709298f Mon Sep 17 00:00:00 2001 From: Jon Atack Date: Thu, 19 Mar 2015 10:04:11 +0530 Subject: Active Record changelog pass [skip ci] --- activerecord/CHANGELOG.md | 73 ++++++++++++++++++++++++----------------------- 1 file changed, 38 insertions(+), 35 deletions(-) diff --git a/activerecord/CHANGELOG.md b/activerecord/CHANGELOG.md index 89cea5a7cb..2bf0bba220 100644 --- a/activerecord/CHANGELOG.md +++ b/activerecord/CHANGELOG.md @@ -29,8 +29,8 @@ *James Cox* -* Dont enroll records in the transaction if they dont have commit callbacks. - That was causing a memory grow problem when creating a lot of records inside a transaction. +* Don't enroll records in the transaction if they don't have commit callbacks. + This was causing a memory leak when creating many records inside a transaction. Fixes #15549. @@ -43,11 +43,11 @@ *Sean Griffin* -* Add `SchemaMigration.create_table` support any unicode charsets for MySQL. +* Add `SchemaMigration.create_table` support for any unicode charsets with MySQL. *Ryuta Kamizono* -* PostgreSQL, no longer disables user triggers if system triggers can't be +* PostgreSQL no longer disables user triggers if system triggers can't be disabled. Disabling user triggers does not fulfill what the method promises. Rails currently requires superuser privileges for this method. @@ -61,12 +61,12 @@ *Toby Ovod-Everett*, *Yves Senn* -* PostgreSQL, print warning message if `disable_referential_integrity` fails - due to missing permissions. +* In PostgreSQL, print a warning message if `disable_referential_integrity` + fails due to missing permissions. *Andrey Nering*, *Yves Senn* -* Allow `:limit` option for MySQL bigint primary key support. +* Allow a `:limit` option for MySQL bigint primary key support. Example: @@ -89,7 +89,7 @@ *Josef Šimánek* * Fixed ActiveRecord::Relation#becomes! and changed_attributes issues for type - column. + columns. Fixes #17139. @@ -99,7 +99,7 @@ *Ryuta Kamizono* -* Allow `:precision` option for time type columns. +* Allow a `:precision` option for time type columns. *Ryuta Kamizono* @@ -116,10 +116,10 @@ recipients: commentable.recipients } end - That's what you want the bulk of the time. New comment creates a new - Notification. But there may well be off cases, like copying a commentable - and its comments, where you don't want that. So you'd have a concern - something like this: + That's what you want the bulk of the time. A new comment creates a new + Notification. There may be edge cases where you don't want that, like + when copying a commentable and its comments, in which case write a + concern with something like this: module Copyable def copy_to(destination) @@ -138,7 +138,7 @@ *Hyonjee Joo* -* Deprecated passing of `start` value to `find_in_batches` and `find_each` +* Deprecate passing of `start` value to `find_in_batches` and `find_each` in favour of `begin_at` value. *Vipul A M* @@ -147,9 +147,10 @@ *Tõnis Simo* -* Use SQL COUNT and LIMIT 1 queries for `none?` and `one?` methods if no block or limit is given, - instead of loading the entire collection to memory. - This applies to relations (e.g. `User.all`) as well as associations (e.g. `account.users`) +* Use SQL COUNT and LIMIT 1 queries for `none?` and `one?` methods + if no block or limit is given, instead of loading the entire + collection into memory. This applies to relations (e.g. `User.all`) + as well as associations (e.g. `account.users`) # Before: @@ -198,16 +199,16 @@ *Vipul A M* -* Fix rounding problem for PostgreSQL timestamp column. +* Fix a rounding problem for PostgreSQL timestamp columns. - If timestamp column have the precision, it need to format according to - the precision of timestamp column. + If a timestamp column has a precision specified, it needs to + format according to that. *Ryuta Kamizono* * Respect the database default charset for `schema_migrations` table. - The charset of `version` column in `schema_migrations` table is depend + The charset of `version` column in `schema_migrations` table depends on the database default charset and collation rather than the encoding of the connection. @@ -215,12 +216,12 @@ * Raise `ArgumentError` when passing `nil` or `false` to `Relation#merge`. - These are not valid values to merge in a relation so it should warn the users + These are not valid values to merge in a relation, so it should warn users early. *Rafael Mendonça França* -* Use `SCHEMA` instead of `DB_STRUCTURE` for specifying structure file. +* Use `SCHEMA` instead of `DB_STRUCTURE` for specifying a structure file. This makes the db:structure tasks consistent with test:load_structure. @@ -232,7 +233,7 @@ *Sean Griffin* -* Fixed several edge cases which could result in a counter cache updating +* Fix several edge cases which could result in a counter cache updating twice or not updating at all for `has_many` and `has_many :through`. Fixes #10865. @@ -265,11 +266,13 @@ *Sammy Larbi* * Change the default error message from `can't be blank` to `must exist` for - the presence validator of the `:required` option on `belongs_to`/`has_one` associations. + the presence validator of the `:required` option on `belongs_to`/`has_one` + associations. *Henrik Nygren* -* Fixed ActiveRecord::Relation#group method when argument is SQL reserved key word: +* Fixed ActiveRecord::Relation#group method when an argument is an SQL + reserved key word: Example: @@ -400,7 +403,7 @@ *Yves Senn* -* Remove deprecation when modifying a relation with cached arel. +* Remove deprecation when modifying a relation with cached Arel. This raises an `ImmutableRelation` error instead. *Yves Senn* @@ -490,13 +493,13 @@ *Florian Weingarten* -* Fixed setting of foreign_key for through associations while building of new record. +* Fix setting of foreign_key for through associations when building a new record. Fixes #12698. *Ivan Antropov* -* Improve a dump of the primary key support. If it is not a default primary key, +* Improve dumping of the primary key. If it is not a default primary key, correctly dump the type and options. Fixes #14169, #16599. @@ -514,18 +517,18 @@ *Ryuta Kamizono* -* Allow precision option for MySQL datetimes. +* Allow a precision option for MySQL datetimes. *Ryuta Kamizono* -* Fixed automatic inverse_of for models nested in module. +* Fixed automatic `inverse_of` for models nested in a module. *Andrew McCloud* * Change `ActiveRecord::Relation#update` behavior so that it can be called without passing ids of the records to be updated. - This change allows to update multiple records returned by + This change allows updating multiple records returned by `ActiveRecord::Relation` with callbacks and validations. # Before @@ -566,7 +569,7 @@ *arthurnn* -* `validates_size_of` / `validates_length_of` do not count records, +* `validates_size_of` / `validates_length_of` do not count records which are `marked_for_destruction?`. Fixes #7247. @@ -608,7 +611,7 @@ *Ryuta Kamizono* -* Support for any type primary key. +* Support for any type of primary key. Fixes #14194. @@ -634,7 +637,7 @@ *Yves Senn* -* Fixes bug with 'ActiveRecord::Type::Numeric' that causes negative values to +* Fix bug with 'ActiveRecord::Type::Numeric' that caused negative values to be marked as having changed when set to the same negative value. Closes #18161. -- cgit v1.2.3