From da507b71f66bca61d06328a876ac1b1482e8fb81 Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Tue, 3 Dec 2013 19:53:45 -0200 Subject: No need for #tap --- .../lib/active_support/number_helper/number_to_phone_converter.rb | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/activesupport/lib/active_support/number_helper/number_to_phone_converter.rb b/activesupport/lib/active_support/number_helper/number_to_phone_converter.rb index ac51ceabc1..300924bded 100644 --- a/activesupport/lib/active_support/number_helper/number_to_phone_converter.rb +++ b/activesupport/lib/active_support/number_helper/number_to_phone_converter.rb @@ -23,10 +23,9 @@ module ActiveSupport end def convert_without_area_code(number) - number.tap { |n| - n.gsub!(/(\d{0,3})(\d{3})(\d{4})$/,"\\1#{delimiter}\\2#{delimiter}\\3") - n.slice!(0, 1) if begins_with_delimiter?(n) - } + number.gsub!(/(\d{0,3})(\d{3})(\d{4})$/,"\\1#{delimiter}\\2#{delimiter}\\3") + number.slice!(0, 1) if begins_with_delimiter?(number) + number end def begins_with_delimiter?(number) -- cgit v1.2.3