From d40c88ae05ba2441c6bec3e87a8939a43ed7c84e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Mendon=C3=A7a=20Fran=C3=A7a?= Date: Thu, 1 Aug 2019 11:18:42 -0400 Subject: No private def --- actionview/lib/action_view/helpers/url_helper.rb | 6 ++++-- actionview/lib/action_view/layouts.rb | 3 ++- .../connection_adapters/abstract/schema_definitions.rb | 3 ++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/actionview/lib/action_view/helpers/url_helper.rb b/actionview/lib/action_view/helpers/url_helper.rb index cebb2aea4d..61ab3c2e13 100644 --- a/actionview/lib/action_view/helpers/url_helper.rb +++ b/actionview/lib/action_view/helpers/url_helper.rb @@ -42,11 +42,12 @@ module ActionView end end - private def _back_url # :nodoc: + def _back_url # :nodoc: _filtered_referrer || "javascript:history.back()" end + private :_back_url - private def _filtered_referrer # :nodoc: + def _filtered_referrer # :nodoc: if controller.respond_to?(:request) referrer = controller.request.env["HTTP_REFERER"] if referrer && URI(referrer).scheme != "javascript" @@ -55,6 +56,7 @@ module ActionView end rescue URI::InvalidURIError end + private :_filtered_referrer # Creates an anchor element of the given +name+ using a URL created by the set of +options+. # See the valid options in the documentation for +url_for+. It's also possible to diff --git a/actionview/lib/action_view/layouts.rb b/actionview/lib/action_view/layouts.rb index db92f905d4..3fdd9fb272 100644 --- a/actionview/lib/action_view/layouts.rb +++ b/actionview/lib/action_view/layouts.rb @@ -305,12 +305,13 @@ module ActionView end RUBY when Proc - private define_method :_layout_from_proc, &_layout + define_method :_layout_from_proc, &_layout <<-RUBY result = _layout_from_proc(#{_layout.arity == 0 ? '' : 'self'}) return #{default_behavior} if result.nil? result RUBY + private :_layout_from_proc when false nil when true diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb index dbd533b4b3..aedd8119ef 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb @@ -221,7 +221,7 @@ module ActiveRecord end class_methods do - private def define_column_methods(*column_types) # :nodoc: + def define_column_methods(*column_types) # :nodoc: column_types.each do |column_type| module_eval <<-RUBY, __FILE__, __LINE__ + 1 def #{column_type}(*names, **options) @@ -231,6 +231,7 @@ module ActiveRecord RUBY end end + private :define_column_methods end end -- cgit v1.2.3