From c61eebd64e579b196678e79dfbc3285de61d3923 Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com> Date: Sun, 4 May 2014 10:56:27 -0300 Subject: Simplify building options hash in rename column method for mysql --- .../connection_adapters/abstract_mysql_adapter.rb | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb index 16e048423f..4184fad81c 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract_mysql_adapter.rb @@ -711,12 +711,13 @@ module ActiveRecord end def rename_column_sql(table_name, column_name, new_column_name) - options = { name: new_column_name } column = column_for(table_name, column_name) - - options[:default] = column.default - options[:null] = column.null - options[:auto_increment] = column.extra == "auto_increment" + options = { + name: new_column_name, + default: column.default, + null: column.null, + auto_increment: column.extra == "auto_increment" + } current_type = select_one("SHOW COLUMNS FROM #{quote_table_name(table_name)} LIKE '#{column_name}'", 'SCHEMA')["Type"] schema_creation.accept ChangeColumnDefinition.new column, current_type, options -- cgit v1.2.3