From b610104e5ce9c148e67cf7f73c8c3e644b2077f9 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Tue, 20 May 2014 15:33:30 -0700 Subject: mutate the path string to avoid object allocations --- actionpack/lib/action_dispatch/http/url.rb | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/actionpack/lib/action_dispatch/http/url.rb b/actionpack/lib/action_dispatch/http/url.rb index 86ca909d27..7ca1636780 100644 --- a/actionpack/lib/action_dispatch/http/url.rb +++ b/actionpack/lib/action_dispatch/http/url.rb @@ -45,14 +45,14 @@ module ActionDispatch if options[:trailing_slash] if path.include?('?') - result << path.sub(/\?/, '/\&') + path.sub!(/\?/, '/\&') else - result << path.sub(/[^\/]\z|\A\z/, '\&/') + path.sub!(/[^\/]\z|\A\z/, '\&/') end - else - result << path end + result << path + if options.key? :params params = options[:params].is_a?(Hash) ? options[:params] : -- cgit v1.2.3