From ac4d101a75335dc430a53203184e67753b6d99e0 Mon Sep 17 00:00:00 2001 From: Jon Leighton Date: Fri, 13 Jul 2012 18:55:38 +0100 Subject: move the deprecated options into active_record_deprecated_finders --- activerecord/lib/active_record/associations/builder/association.rb | 2 +- .../lib/active_record/associations/builder/collection_association.rb | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/activerecord/lib/active_record/associations/builder/association.rb b/activerecord/lib/active_record/associations/builder/association.rb index 91b2582acc..331b724814 100644 --- a/activerecord/lib/active_record/associations/builder/association.rb +++ b/activerecord/lib/active_record/associations/builder/association.rb @@ -4,7 +4,7 @@ module ActiveRecord::Associations::Builder attr_accessor :valid_options end - self.valid_options = [:class_name, :foreign_key, :select, :conditions, :include, :extend, :readonly, :validate, :references] + self.valid_options = [:class_name, :foreign_key, :validate] attr_reader :model, :name, :scope, :options, :reflection diff --git a/activerecord/lib/active_record/associations/builder/collection_association.rb b/activerecord/lib/active_record/associations/builder/collection_association.rb index b2eeb08f8a..98ca94b42a 100644 --- a/activerecord/lib/active_record/associations/builder/collection_association.rb +++ b/activerecord/lib/active_record/associations/builder/collection_association.rb @@ -3,10 +3,7 @@ module ActiveRecord::Associations::Builder CALLBACKS = [:before_add, :after_add, :before_remove, :after_remove] def valid_options - super + [ - :table_name, :order, :group, :having, :limit, :offset, :uniq, :finder_sql, - :counter_sql, :before_add, :after_add, :before_remove, :after_remove - ] + super + [:table_name, :finder_sql, :counter_sql, :before_add, :after_add, :before_remove, :after_remove] end attr_reader :block_extension -- cgit v1.2.3