From 5313eab6954aff1235aca9126d662aac5b6c300d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Kondzior?= <pawel@kondzior.com>
Date: Mon, 16 Jan 2012 23:07:15 -0800
Subject: Fix ActiveModel::Errors#dup

Since ActiveModel::Errors instance keeps all error messages as hash
we should duplicate this object as well.

Previously ActiveModel::Errors was a subclass of ActiveSupport::OrderedHash,
which results in different behavior on `dup`, this may result in regression for
people relying on it.
---
 activemodel/lib/active_model/errors.rb | 5 +++++
 activemodel/test/cases/errors_test.rb  | 8 ++++++++
 2 files changed, 13 insertions(+)

diff --git a/activemodel/lib/active_model/errors.rb b/activemodel/lib/active_model/errors.rb
index c6535082d3..4a0ad618bc 100644
--- a/activemodel/lib/active_model/errors.rb
+++ b/activemodel/lib/active_model/errors.rb
@@ -78,6 +78,11 @@ module ActiveModel
       @messages = ActiveSupport::OrderedHash.new
     end
 
+    def initialize_dup(other)
+      @messages = other.messages.dup
+      super
+    end
+
     # Clear the messages
     def clear
       messages.clear
diff --git a/activemodel/test/cases/errors_test.rb b/activemodel/test/cases/errors_test.rb
index 4edeece3e8..ab80f193b6 100644
--- a/activemodel/test/cases/errors_test.rb
+++ b/activemodel/test/cases/errors_test.rb
@@ -40,6 +40,14 @@ class ErrorsTest < ActiveModel::TestCase
     assert errors.include?(:foo), 'errors should include :foo'
   end
 
+  def test_dup
+    errors = ActiveModel::Errors.new(self)
+    errors[:foo] = 'bar'
+    errors_dup = errors.dup
+    errors_dup[:bar] = 'omg'
+    assert_not_same errors_dup.messages, errors.messages
+  end
+
   def test_has_key?
     errors = ActiveModel::Errors.new(self)
     errors[:foo] = 'omg'
-- 
cgit v1.2.3


From 6174d3ba244c448bf31b4a84aa45ac651bb9435c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Kondzior?= <pawel@kondzior.com>
Date: Mon, 16 Jan 2012 23:24:14 -0800
Subject: Remove redundant #to_sym

---
 activemodel/lib/active_model/errors.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/activemodel/lib/active_model/errors.rb b/activemodel/lib/active_model/errors.rb
index 4a0ad618bc..5cd8f77f0d 100644
--- a/activemodel/lib/active_model/errors.rb
+++ b/activemodel/lib/active_model/errors.rb
@@ -123,7 +123,7 @@ module ActiveModel
     #   p.errors[:name] = "must be set"
     #   p.errors[:name] # => ['must be set']
     def []=(attribute, error)
-      self[attribute.to_sym] << error
+      self[attribute] << error
     end
 
     # Iterates through each error key, value pair in the error messages hash.
-- 
cgit v1.2.3