From 9fb3dd7551a2bdb8acedf3ceb056071070b6fd66 Mon Sep 17 00:00:00 2001 From: Javan Makhmali Date: Tue, 2 Oct 2018 19:36:01 -0400 Subject: Uncomment failing tests --- test/unit/attachment_test.rb | 54 ++++++++++++++-------------- test/unit/content_test.rb | 84 ++++++++++++++++++++++---------------------- 2 files changed, 69 insertions(+), 69 deletions(-) diff --git a/test/unit/attachment_test.rb b/test/unit/attachment_test.rb index dec2b8244d..a31ef1afd0 100644 --- a/test/unit/attachment_test.rb +++ b/test/unit/attachment_test.rb @@ -18,33 +18,33 @@ class ActionText::AttachmentTest < ActiveSupport::TestCase assert_equal attachable.to_param, attachment.to_param end - # test "converts to TrixAttachment" do - # attachment = attachment_from_html(%Q()) - # - # trix_attachment = attachment.to_trix_attachment - # assert_kind_of ActionText::TrixAttachment, trix_attachment - # - # assert_equal attachable.attachable_sgid, trix_attachment.attributes["sgid"] - # assert_equal attachable.attachable_content_type, trix_attachment.attributes["contentType"] - # assert_equal attachable.filename.to_s, trix_attachment.attributes["filename"] - # assert_equal attachable.byte_size, trix_attachment.attributes["filesize"] - # assert_equal "Captioned", trix_attachment.attributes["caption"] - # - # assert_nil trix_attachment.attributes["content"] - # end - - # test "converts to TrixAttachment with content" do - # attachment = attachment_from_html(%Q()) - # - # trix_attachment = attachment.to_trix_attachment - # assert_kind_of ActionText::TrixAttachment, trix_attachment - # - # assert_equal attachable.attachable_sgid, trix_attachment.attributes["sgid"] - # assert_equal attachable.attachable_content_type, trix_attachment.attributes["contentType"] - # - # assert_not_nil attachable.to_trix_content_attachment_partial_path - # assert_not_nil trix_attachment.attributes["content"] - # end + test "converts to TrixAttachment" do + attachment = attachment_from_html(%Q()) + + trix_attachment = attachment.to_trix_attachment + assert_kind_of ActionText::TrixAttachment, trix_attachment + + assert_equal attachable.attachable_sgid, trix_attachment.attributes["sgid"] + assert_equal attachable.attachable_content_type, trix_attachment.attributes["contentType"] + assert_equal attachable.filename.to_s, trix_attachment.attributes["filename"] + assert_equal attachable.byte_size, trix_attachment.attributes["filesize"] + assert_equal "Captioned", trix_attachment.attributes["caption"] + + assert_nil trix_attachment.attributes["content"] + end + + test "converts to TrixAttachment with content" do + attachment = attachment_from_html(%Q()) + + trix_attachment = attachment.to_trix_attachment + assert_kind_of ActionText::TrixAttachment, trix_attachment + + assert_equal attachable.attachable_sgid, trix_attachment.attributes["sgid"] + assert_equal attachable.attachable_content_type, trix_attachment.attributes["contentType"] + + assert_not_nil attachable.to_trix_content_attachment_partial_path + assert_not_nil trix_attachment.attributes["content"] + end private def attachment_from_html(html) diff --git a/test/unit/content_test.rb b/test/unit/content_test.rb index 8f32a85110..c0b8ad024c 100644 --- a/test/unit/content_test.rb +++ b/test/unit/content_test.rb @@ -62,46 +62,46 @@ class ActionText::ContentTest < ActiveSupport::TestCase assert_equal ActionText::Attachables::MissingAttachable, content.attachments.first.attachable end - # test "extracts missing attachables" do - # html = %Q() - # content = ActionText::Content.new(html) - # assert_equal 1, content.attachments.size - # assert_equal ActionText::Attachables::MissingAttachable, content.attachments.first.attachable - # end - # - # test "converts Trix-formatted attachments" do - # html = %Q(
) - # content = ActionText::Content.new(html) - # assert_equal 1, content.attachments.size - # assert_equal %Q(), content.to_html - # end - # - # test "ignores Trix-formatted attachments with malformed JSON" do - # html = %Q(
) - # content = ActionText::Content.new(html) - # assert_equal 0, content.attachments.size - # end - # - # test "minifies attachment markup" do - # html = %Q(
HTML
) - # assert_equal %Q(), ActionText::Content.new(html).to_html - # end - # - # test "canonicalizes attachment gallery markup" do - # attachment_html = %Q() - # html = %Q() - # assert_equal %Q(
#{attachment_html}
), ActionText::Content.new(html).to_html - # end - # - # test "canonicalizes attachment gallery markup with whitespace" do - # attachment_html = %Q(\n \n \n) - # html = %Q() - # assert_equal %Q(
#{attachment_html}
), ActionText::Content.new(html).to_html - # end - # - # test "canonicalizes nested attachment gallery markup" do - # attachment_html = %Q() - # html = %Q(
) - # assert_equal %Q(
#{attachment_html}
), ActionText::Content.new(html).to_html - # end + test "extracts missing attachables" do + html = %Q() + content = ActionText::Content.new(html) + assert_equal 1, content.attachments.size + assert_equal ActionText::Attachables::MissingAttachable, content.attachments.first.attachable + end + + test "converts Trix-formatted attachments" do + html = %Q(
) + content = ActionText::Content.new(html) + assert_equal 1, content.attachments.size + assert_equal %Q(), content.to_html + end + + test "ignores Trix-formatted attachments with malformed JSON" do + html = %Q(
) + content = ActionText::Content.new(html) + assert_equal 0, content.attachments.size + end + + test "minifies attachment markup" do + html = %Q(
HTML
) + assert_equal %Q(), ActionText::Content.new(html).to_html + end + + test "canonicalizes attachment gallery markup" do + attachment_html = %Q() + html = %Q() + assert_equal %Q(
#{attachment_html}
), ActionText::Content.new(html).to_html + end + + test "canonicalizes attachment gallery markup with whitespace" do + attachment_html = %Q(\n \n \n) + html = %Q() + assert_equal %Q(
#{attachment_html}
), ActionText::Content.new(html).to_html + end + + test "canonicalizes nested attachment gallery markup" do + attachment_html = %Q() + html = %Q(
) + assert_equal %Q(
#{attachment_html}
), ActionText::Content.new(html).to_html + end end -- cgit v1.2.3