From 5556db22c57294a9f4e2ee4e633834ec6a200242 Mon Sep 17 00:00:00 2001 From: Michael Koziarski Date: Tue, 7 Oct 2008 20:59:03 +0200 Subject: Reduce memory usage slightly in String#parameterize [#1034 state:committed] --- activesupport/lib/active_support/inflector.rb | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/activesupport/lib/active_support/inflector.rb b/activesupport/lib/active_support/inflector.rb index f1e7abf4aa..336b6db47f 100644 --- a/activesupport/lib/active_support/inflector.rb +++ b/activesupport/lib/active_support/inflector.rb @@ -259,11 +259,15 @@ module ActiveSupport # # => Donald E. Knuth def parameterize(string, sep = '-') re_sep = Regexp.escape(sep) - transliterate(string). - gsub(/[^a-z0-9\-_\+]+/i, sep). # Turn unwanted chars into the separator. - squeeze(sep). # No more than one of the separator in a row. - gsub(/^#{re_sep}|#{re_sep}$/i, ''). # Remove leading/trailing separator. - downcase + # replace accented chars with ther ascii equivalents + parameterized_string = transliterate(string) + # Turn unwanted chars into the seperator + parameterized_string.gsub!(/[^a-z0-9\-_\+]+/i, sep) + # No more than one of the separator in a row. + parameterized_string.squeeze!(sep) + # Remove leading/trailing separator. + parameterized_string.gsub!(/^#{re_sep}|#{re_sep}$/i, '') + parameterized_string.downcase end -- cgit v1.2.3