From 35bbf0923b038464bb0334e9f75181ea0847d15a Mon Sep 17 00:00:00 2001 From: Sean Griffin Date: Fri, 22 Aug 2014 10:01:10 -0700 Subject: Don't calculate in-place changes twice Now that `changed_attributes` includes in place changes, we don't need to override these methods in Active Record. Partially fixes the performance regression caused by #16189 --- activerecord/lib/active_record/attribute_methods/dirty.rb | 8 -------- 1 file changed, 8 deletions(-) diff --git a/activerecord/lib/active_record/attribute_methods/dirty.rb b/activerecord/lib/active_record/attribute_methods/dirty.rb index d3f4e51c33..01f126f1b3 100644 --- a/activerecord/lib/active_record/attribute_methods/dirty.rb +++ b/activerecord/lib/active_record/attribute_methods/dirty.rb @@ -43,14 +43,6 @@ module ActiveRecord calculate_changes_from_defaults end - def changed? - super || changed_in_place.any? - end - - def changed - super | changed_in_place - end - def changes_applied super store_original_raw_attributes -- cgit v1.2.3