From 48cfb003b717c5494fb2f4d3eb10c1b339f9f05e Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Mon, 20 Feb 2017 00:10:50 +0900 Subject: Improve `create_table force: true` Extra `data_source_exists?(table_name)` is unneeded if `drop_table(table_name, if_exists: true)` directly. --- .../active_record/connection_adapters/abstract/schema_statements.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb index bdcdfe4982..3686ad8b54 100644 --- a/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb +++ b/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb @@ -273,8 +273,8 @@ module ActiveRecord yield td if block_given? - if options[:force] && data_source_exists?(table_name) - drop_table(table_name, options) + if options[:force] + drop_table(table_name, **options, if_exists: true) end result = execute schema_creation.accept td -- cgit v1.2.3