From 4861bc62cf4832bcfbaecac9ad9ee73deb172c0c Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Tue, 8 Apr 2014 21:15:15 -0700 Subject: fixing ibm db --- lib/arel/visitors/ibm_db.rb | 6 ++++-- test/visitors/test_ibm_db.rb | 8 ++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/lib/arel/visitors/ibm_db.rb b/lib/arel/visitors/ibm_db.rb index a41f8ff573..f1d126790d 100644 --- a/lib/arel/visitors/ibm_db.rb +++ b/lib/arel/visitors/ibm_db.rb @@ -3,8 +3,10 @@ module Arel class IBM_DB < Arel::Visitors::ToSql private - def visit_Arel_Nodes_Limit o - "FETCH FIRST #{visit o.expr } ROWS ONLY" + def visit_Arel_Nodes_Limit o, collector + collector << "FETCH FIRST " + collector = visit o.expr, collector + collector << " ROWS ONLY" end end diff --git a/test/visitors/test_ibm_db.rb b/test/visitors/test_ibm_db.rb index 75f1daff6a..f1aa7612be 100644 --- a/test/visitors/test_ibm_db.rb +++ b/test/visitors/test_ibm_db.rb @@ -7,10 +7,14 @@ module Arel @visitor = IBM_DB.new Table.engine.connection end + def compile node + @visitor.accept(node, Collectors::SQLString.new).value + end + it 'uses FETCH FIRST n ROWS to limit results' do stmt = Nodes::SelectStatement.new stmt.limit = Nodes::Limit.new(1) - sql = @visitor.accept(stmt) + sql = compile(stmt) sql.must_be_like "SELECT FETCH FIRST 1 ROWS ONLY" end @@ -20,7 +24,7 @@ module Arel stmt.relation = table stmt.limit = Nodes::Limit.new(Nodes.build_quoted(1)) stmt.key = table[:id] - sql = @visitor.accept(stmt) + sql = compile(stmt) sql.must_be_like "UPDATE \"users\" WHERE \"users\".\"id\" IN (SELECT \"users\".\"id\" FROM \"users\" FETCH FIRST 1 ROWS ONLY)" end -- cgit v1.2.3