From 17b8cde6d16cee9a7b7d5daf1ef79d8facfcfbf6 Mon Sep 17 00:00:00 2001 From: Carlos Antonio da Silva Date: Mon, 29 Jul 2019 12:27:48 -0300 Subject: Call raise with parentheses like a normal method call with arguments Using `(raise FooError, "error")` is like forcing a "new scope" around the `raise` call, it's simpler to just wrap the `raise` arguments with parentheses just like any other method call would. --- activesupport/lib/active_support/core_ext/string/access.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/activesupport/lib/active_support/core_ext/string/access.rb b/activesupport/lib/active_support/core_ext/string/access.rb index 1a0b10b4f6..f6a14c08bc 100644 --- a/activesupport/lib/active_support/core_ext/string/access.rb +++ b/activesupport/lib/active_support/core_ext/string/access.rb @@ -76,7 +76,7 @@ class String # str.first(0) # => "" # str.first(6) # => "hello" def first(limit = 1) - self[0, limit] || (raise ArgumentError, "negative limit") + self[0, limit] || raise(ArgumentError, "negative limit") end # Returns the last character of the string. If a limit is supplied, returns a substring @@ -90,6 +90,6 @@ class String # str.last(0) # => "" # str.last(6) # => "hello" def last(limit = 1) - self[[length - limit, 0].max, limit] || (raise ArgumentError, "negative limit") + self[[length - limit, 0].max, limit] || raise(ArgumentError, "negative limit") end end -- cgit v1.2.3