From 0aa0de17488be8c3490b5f230f8186dd744fa90d Mon Sep 17 00:00:00 2001 From: Ryuta Kamizono Date: Wed, 20 Dec 2017 13:35:49 +0900 Subject: Place args normalization from `left_outer_joins` to `left_outer_joins!` Like other query bang methods. --- activerecord/lib/active_record/relation/query_methods.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/activerecord/lib/active_record/relation/query_methods.rb b/activerecord/lib/active_record/relation/query_methods.rb index 2056f9bb73..0296101f81 100644 --- a/activerecord/lib/active_record/relation/query_methods.rb +++ b/activerecord/lib/active_record/relation/query_methods.rb @@ -444,15 +444,13 @@ module ActiveRecord # def left_outer_joins(*args) check_if_method_has_arguments!(__callee__, args) - - args.compact! - args.flatten! - spawn.left_outer_joins!(*args) end alias :left_joins :left_outer_joins def left_outer_joins!(*args) # :nodoc: + args.compact! + args.flatten! self.left_outer_joins_values += args self end -- cgit v1.2.3