From 087e0ccb72e7a1491701dd1d1d49746f745d9d68 Mon Sep 17 00:00:00 2001 From: Daniel Colson Date: Tue, 17 Apr 2018 08:37:35 -0400 Subject: Add RuboCop for `assert_not` over `assert !` We added `assert_not` in f75addd "to replace warty 'assert !foo'". fa8d35b agrees that it is warty, and so do I. This custom Rubocop rule turns the wart into a violation. As with my last custom cop, https://github.com/rails/rails/pull/32441, I want to make sure this looks right on code climate before pushing another commit to autocorrect everything. @toshimaru I just noticed https://github.com/toshimaru/rubocop-rails/pull/26 Is there a better way to add these custom cops, or were you saying we shouldn't have custom cops at all? --- .rubocop.yml | 5 +++++ 1 file changed, 5 insertions(+) (limited to '.rubocop.yml') diff --git a/.rubocop.yml b/.rubocop.yml index eb410376fe..9d1ec47aee 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -15,6 +15,11 @@ CustomCops/RefuteNot: Include: - '**/*_test.rb' +# Prefer assert_not over assert ! +CustomCops/AssertNot: + Include: + - '**/*_test.rb' + # Prefer &&/|| over and/or. Style/AndOr: Enabled: true -- cgit v1.2.3