Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
| * | | | Eager load controller and mailer actions | Kir Shatrov | 2017-07-29 | 1 | -0/+60 | |
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the first request, ActionController::Base#action_methods computes and memoized the list of available actions [1]. With this PR we move this expensive operation into eager load step to reduce response time of the first request served in production. This also reduces the memory footprint when running on forking server like Unicorn. [1] https://github.com/rails/rails/blob/a3813dce9a0c950a4af7909111fa730a2622b1db/actionpack/lib/abstract_controller/base.rb#L66-L77 | |||||
* | | | Merge pull request #30114 from yhirano55/remove_empty_line_from_dummy_manifest | Rafael França | 2017-08-11 | 1 | -1/+0 | |
|\ \ \ | | | | | | | | | Removed empty line from dummy_manifest | |||||
| * | | | Removed empty line from dummy_manifest | Yoshiyuki Hirano | 2017-08-07 | 1 | -1/+0 | |
| | | | | ||||||
* | | | | Merge pull request #30116 from ↵ | Rafael Mendonça França | 2017-08-11 | 3 | -1/+32 | |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | yhirano55/skip_unused_components_when_running_rails_command_in_plugin Skip unused components when running `bin/rails` in Rails plugin | |||||
| * | | | | Skip unused components when running in Rails plugin | Yoshiyuki Hirano | 2017-08-09 | 3 | -1/+32 | |
| | | | | | ||||||
* | | | | | Merge pull request #30105 from bogdanvlviv/remove-sorted-test_order | Rafael França | 2017-08-11 | 1 | -2/+0 | |
|\ \ \ \ \ | | | | | | | | | | | | | Remove :sorted test order for isolated tests | |||||
| * | | | | | Remove :sorted test order for isolated tests | bogdanvlviv | 2017-08-07 | 1 | -2/+0 | |
| | | | | | | ||||||
* | | | | | | Merge pull request #30110 from yhirano55/add_git_source | Rafael Mendonça França | 2017-08-11 | 3 | -0/+10 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | Add git_source to Gemfile for plugin generator | |||||
| * | | | | | | Add git_source to Gemfile for plugin generator | Yoshiyuki Hirano | 2017-08-09 | 3 | -0/+10 | |
| | |/ / / / | |/| | | | | ||||||
* | | | | | | Merge pull request #30092 from bogdanvlviv/prevent-generation-extra-empty-lines | Rafael França | 2017-08-11 | 2 | -7/+6 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Prevent generation extra empty lines in a plugin's Rakefile | |||||
| * | | | | | | Prevent generation extra empty lines in a plugin's Rakefile | bogdanvlviv | 2017-08-09 | 2 | -7/+6 | |
| | | | | | | | ||||||
* | | | | | | | Refactor app_generator_test (#30192) | yhirano55 | 2017-08-11 | 1 | -1/+8 | |
| |_|_|_|_|/ |/| | | | | | ||||||
* | | | | | | `--skip-action-cable` pass throughs `rails plugin new` | bogdanvlviv | 2017-08-10 | 3 | -1/+11 | |
| | | | | | | ||||||
* | | | | | | Improve plugin generator tests. Related to #30123. | bogdanvlviv | 2017-08-10 | 2 | -44/+74 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve app generator tests. Ensure that generation `config/application.rb` is correct. Ensure that generation `config/application.rb` is correct. | |||||
* | | | | | | Merge pull request #30091 from yhirano55/fix_engine_command | Rafael França | 2017-08-08 | 2 | -0/+6 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix engine command | |||||
| * | | | | | | Fix engine command | Yoshiyuki Hirano | 2017-08-06 | 2 | -0/+6 | |
| |/ / / / / | ||||||
* | | | | | | Merge pull request #30088 from y-yagi/use_the_same_key_as_presented_in_doc | Rafael França | 2017-08-08 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Use the same key as presented in doc | |||||
| * | | | | | | Use the same key as presented in doc | yuuji.yaginuma | 2017-08-09 | 1 | -1/+1 | |
| | |/ / / / | |/| | | | | | | | | | | | | | | | | Ref: https://github.com/rails/rails/blob/a8217bb594a625fb46a6af1488c0bde4aeac4986/railties/lib/rails/generators/rails/app/templates/config/storage.yml#L24 | |||||
* | | | | | | Merge pull request #30090 from yhirano55/fix_escaped_character | Rafael França | 2017-08-08 | 1 | -1/+1 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix non escaped character | |||||
| * | | | | | | Fix escaped character | Yoshiyuki Hirano | 2017-08-06 | 1 | -1/+1 | |
| | |/ / / / | |/| | | | | ||||||
* | | | | | | Merge pull request #30115 from ↵ | Rafael França | 2017-08-08 | 1 | -4/+6 | |
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | | intrip/30049-application-controller-renderer-defaults-automatic-reload-in-dev Fix ApplicationController.renderer.defaults overriding in development | |||||
| * | | | | | Fix ApplicationController.renderer.defaults overriding in development | Jacopo | 2017-07-20 | 1 | -4/+6 | |
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously overriding ApplicationController.renderer.defaults wasn't working effectively in development. In fact the override was unset every time the code was reloaded. The solution is to wrap the code in a `.to_prepare` block. | |||||
* | | | | | Merge pull request #30123 from yhirano55/fix_dummy_app_configuration | Rafael França | 2017-08-08 | 1 | -3/+5 | |
|\ \ \ \ \ | | | | | | | | | | | | | Fix dummy_app configuration | |||||
| * | | | | | Fix dummy_app configuration | Yoshiyuki Hirano | 2017-08-08 | 1 | -3/+5 | |
| |/ / / / | ||||||
* | | | | | Merge pull request #30122 from yhirano55/use_with_dummy_app_in_gitignore | Rafael França | 2017-08-08 | 1 | -1/+1 | |
|\ \ \ \ \ | | | | | | | | | | | | | Use `with_dummy_app?` in gitignore | |||||
| * | | | | | Use `with_dummy_app?` in gitignore | Yoshiyuki Hirano | 2017-08-08 | 1 | -1/+1 | |
| |/ / / / | ||||||
* | | | | | Merge pull request #30127 from y-yagi/deprecate_support_of_older_config_ru | Rafael França | 2017-08-08 | 3 | -1/+43 | |
|\ \ \ \ \ | | | | | | | | | | | | | Deprecate support of older `config.ru` | |||||
| * | | | | | Deprecate support of older `config.ru` | yuuji.yaginuma | 2017-08-08 | 3 | -1/+43 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since Rails 4.0, `config.ru` generated by default uses instances of `Rails.application`. Therefore, I think that it is good to deprecate the old behavior. Related: #9669 | |||||
* | | | | | | ActiveStorage:Add migrations per rails engine conventions (#30111) | Dino Maric | 2017-08-08 | 1 | -2/+2 | |
| |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | * Add migrations per rails engine conventions * Fix failing tests | |||||
* | | | | | Lint railties/CHANGELOG.md | Jon Moss | 2017-08-06 | 1 | -2/+2 | |
|/ / / / | | | | | | | | | | | | | | | | | | | | | Light grammar edits. [ci skip] | |||||
* / / / | Fix wrong service name in the storage.yml | dixpac | 2017-08-06 | 1 | -3/+3 | |
|/ / / | ||||||
* | | | Merge pull request #30080 from georgeclaghorn/active-storage-secret-key-base | David Heinemeier Hansson | 2017-08-05 | 1 | -3/+1 | |
|\ \ \ | | | | | | | | | Active Storage: check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | |||||
| * | | | Check for `app.secrets.secret_key_base`, not `app.config.secret_key_base` | George Claghorn | 2017-08-05 | 1 | -3/+1 | |
| |/ / | | | | | | | | | | By default, apps only have the former set. | |||||
* / / | Add missing blank line between `config.active_storage` and `config.action_cable` | Ryuta Kamizono | 2017-08-05 | 1 | -0/+1 | |
|/ / | ||||||
* | | Merge pull request #30020 from rails/active-storage-import | David Heinemeier Hansson | 2017-08-04 | 17 | -19/+127 | |
|\ \ | | | | | | | Add Active Storage to Rails | |||||
| * | | Make sure the test fails if the code chages | Rafael Mendonça França | 2017-08-04 | 1 | -8/+10 | |
| | | | | | | | | | | | | | | | | | | | | | | | | The test was passing before because it was not being testes correctly. Now we create a different engine that is loaded before the already exising and we make sure that the first call for isolate_namespace is what takes effect. | |||||
| * | | Do not call isolate_namespace on the application | Rafael Mendonça França | 2017-08-04 | 1 | -1/+9 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | What we want to test is that two different calls to isolate_namespace with the same module doesn't change the original railtie. We can do that defining two different railties. We can't call in the application because this method is not supposed to be called in an Application class. | |||||
| * | | Include active_storage in all generated application.rb files | David Heinemeier Hansson | 2017-08-04 | 3 | -1/+4 | |
| | | | | | | | | | | | | And deal with a temporary test fix until we allow you to skip active storage. | |||||
| * | | Convert to strings so array can be sorted deterministically | David Heinemeier Hansson | 2017-08-04 | 1 | -3/+3 | |
| | | | ||||||
| * | | Deterministic comparisons please | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+3 | |
| | | | ||||||
| * | | Do not eager load ActiveRecord::Base | Rafael Mendonça França | 2017-08-03 | 2 | -10/+6 | |
| | | | | | | | | | | | | Everything inside the app directory of a engine is autoload/eager loaded automatically so we don't need to require them. | |||||
| * | | Active Storage routes are now part of the default routes | David Heinemeier Hansson | 2017-08-03 | 1 | -9/+37 | |
| | | | | | | | | | | | | It's worth considering whether we should hide these by default, but I'm kinda thinking no. It's very reasonable that someone would want to call these directly, so they should be documented. | |||||
| * | | Same issue from AR getting loaded earlier | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+3 | |
| | | | | | | | | | | | | cc @rafaelfranca | |||||
| * | | Including new default classes in loading test | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+3 | |
| | | | ||||||
| * | | Active Storage loads AR earlier to extend it so require env later | David Heinemeier Hansson | 2017-08-03 | 1 | -3/+7 | |
| | | | ||||||
| * | | Generating the app is where the exception is now raised | David Heinemeier Hansson | 2017-08-03 | 1 | -1/+1 | |
| | | | ||||||
| * | | Merge branch 'master' into active-storage-import | David Heinemeier Hansson | 2017-08-02 | 3 | -3/+3 | |
| |\ \ | ||||||
| * \ \ | Merge branch 'master' into active-storage-import | David Heinemeier Hansson | 2017-08-01 | 7 | -8/+10 | |
| |\ \ \ | ||||||
| * | | | | Prevent interpolation of ERB elements | David Heinemeier Hansson | 2017-08-01 | 1 | -6/+6 | |
| | | | | | ||||||
| * | | | | Add the storage.yml file by default | David Heinemeier Hansson | 2017-08-01 | 1 | -0/+1 | |
| | | | | |