| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
to return self.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logs for a certain block, change the log level for that block.
* ActiveSupport::BufferedLogger#open_log is deprecated. This method should
not have been public in the first place.
* ActiveSupport::BufferedLogger's behavior of automatically creating the
directory for your log file is deprecated. Please make sure to create the
directory for your log file before instantiating.
* ActiveSupport::BufferedLogger#auto_flushing is deprecated. Either set the
sync level on the underlying file handle like this:
f = File.open('foo.log', 'w')
f.sync = true
ActiveSupport::BufferedLogger.new f
Or tune your filesystem. The FS cache is now what controls flushing.
* ActiveSupport::BufferedLogger#flush is deprecated. Set sync on your
filehandle, or tune your filesystem.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removing this feature causes boost in performance when using Ruby 1.9.
Ruby 1.9 started to do implicit conversions using `to_ary` and `to_str`
in some STDLIB methods (like Array#join). To do such implicit conversions,
Ruby 1.9 always dispatches the method and rescues the NoMethodError exception
in case one is raised.
Therefore, since the whiners feature defined NilClass#method_missing, such
implicit conversions for nil became much, much slower. In fact, just defining
NilClass#method_missing (even without the whiners feature) already causes a
massive slow down. Here is a snippet that shows such slow down:
require "benchmark"
Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
class NilClass
def method_missing(*args)
raise NoMethodError
end
end
Benchmark.realtime { 1_000.times { [nil,nil,nil].join } }
|
| |
|
|\
| |
| | |
Add tests for the return value of require
|
| |
| |
| |
| | |
- These tests don't use autoloading so there's no need to add anything to autoload_paths
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
- Add tests to protect from regressions in require's return value behavior
- See a10606c490471d8e1483acb3b31d7f2d51e9ebbe (require needs to return true or false) for the original bug fix
|
|/
|
|
|
|
|
| |
Revert html_escape to do a single gsub again, but add the "n" flag (no
language, i.e. not multi-byte) to protect against XSS via invalid utf8
Signed-off-by: José Valim <jose.valim@gmail.com>
|
| |
|
|
|
|
| |
a before callback halts.
|
|
|
|
| |
from ruby's standard library.
|
|\
| |
| | |
Object#in? also accepts multiple parameters
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
Reference commits :
a8f2860d0e7db86c61bb70935006100b04667ab1
80ac4dc6d0632937ccf61b38bc15fc2f6e27b18b
|
| |
| |
| |
| | |
start based on start day that is monday by default
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
(part 2)
`nil` and `false` both expand to `""` (empty string), while `true` expands to
`"true"`; `false` should expand to `"false"`
|
| |
| |
| |
| |
| | |
`cache_key` method is never called when the argument is a 1-element array
with something that responds to `cache_key`
|
|\ \
| | |
| | | |
Fix inconsistencies with Time{WithZone}#{hash,eql?}
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | | |
value, not expecting specifically true or false
Respecting Genuine assert_equal false Edition
|
| | |
| | |
| | |
| | | |
This avoids the unnecessary "yo dawg, I heard you like include, so I put a module that includes your module when it is included" approach when building extensions.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
return value, not expecting specifically true or false"
Reason: there were some genuine tests for false when
reading values, going to revise those ones.
This reverts commit a539a5e3f3be68f027d3dfe43f88dc9f0642c743.
|
| | |
| | |
| | |
| | | |
value, not expecting specifically true or false
|
| |/
|/| |
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | | |
remove_method tests and changes
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The last argument to DateTime.new/civil is the Julian day number for
when the calendar reform occured. DateTime ignores it if it's 0, and
sets it to the default of DateTime::ITALY instead, so we could just
leave it out. This also removes the warnings while running the
ActiveSupport tests (there still are some for the setup though).
|
|/ / |
|
| |
| |
| |
| | |
events while a block runs
|
|/ |
|
|
|
|
|
|
|
|
|
|
| |
This commit also implements a faster version of #demodulize I was unable
to isolate with git add --patch.
Not a big fan of the name #deconstantize. It complements #demodulize
getting rid of the rightmost constant, hence the name, but it is
unrelated to the well-known #constantize. So unsure. Could not come
with anything better, please feel free to rename.
|
|
|
|
| |
This is also faster on 1.9.
|
|
|
|
|
|
|
| |
Tests were failing on Travis-CI.
This reverts commit 79d01a8f16e20c556a086a2f07e3ccb4400f9819, reversing
changes made to b838570bd69ff13d677fb43e79f10d6f3168c696.
|
| |
|
|\
| |
| | |
Fix ActiveSupport::Cache::FileStore.cleanup to actually work.
|
| | |
|
|/ |
|
|
|
| |
In log it should not show the empty array.
|
| |
|
|
|
|
| |
production concerns
|