Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | AS::Callbacks: Refactor :per_key option | Bogdan Gusiev | 2012-01-17 | 1 | -35/+7 |
| | |||||
* | AS::Callbacks: remove unused runner | Bogdan Gusiev | 2012-01-12 | 1 | -16/+3 |
| | |||||
* | Remove Array.wrap calls in ActiveSupport | Rafael Mendonça França | 2012-01-06 | 1 | -8/+7 |
| | |||||
* | Merge pull request #3637 from bogdan/compile_options | José Valim | 2012-01-05 | 1 | -58/+62 |
|\ | | | | | AS::Callbacks::Callback refactor | ||||
| * | AS::Callbacks::Callback refactor | Bogdan Gusiev | 2011-11-15 | 1 | -58/+62 |
| | | | | | | | | | | | | In order to make Callbacks code always operate on valid peaces of code Concatenated Callback#start and Callback#end method into #apply method. | ||||
* | | Revert "AS::Callbacks: remove __define_runner" | José Valim | 2012-01-04 | 1 | -3/+16 |
| | | | | | | | | | | | | Runners are used internally. This reverts commit 40c8aa706adbb60ff9d289016fb9020d48969fea. | ||||
* | | AS::Callbacks: remove __define_runner | Bogdan Gusiev | 2011-12-30 | 1 | -16/+3 |
| | | |||||
* | | Refactor AS::Callbacks | Bogdan Gusiev | 2011-12-28 | 1 | -6/+8 |
| | | | | | | | | | | Extracted `__reset_runner` from `__define_runner` And call it in proper places | ||||
* | | AS::Callbacks: improved __define_runner performance | Bogdan Gusiev | 2011-12-25 | 1 | -3/+2 |
| | | |||||
* | | AS::Callbacks: improve __define_runner perfomance | Bogdan Gusiev | 2011-12-25 | 1 | -10/+11 |
| | | |||||
* | | Log 'Filter chain halted as CALLBACKNAME rendered or redirected' every time ↵ | José Valim | 2011-11-30 | 1 | -4/+14 |
|/ | | | | a before callback halts. | ||||
* | AS::Callbacks::Callback#_compile_option refactored | Bogdan Gusiev | 2011-11-11 | 1 | -14/+12 |
| | |||||
* | AS::Callbacks.__run_keyed_callback: remove unused cache | Bogdan Gusiev | 2011-11-10 | 1 | -10/+6 |
| | |||||
* | self.class.name -> self.name (we are already inside a class). | José Valim | 2011-11-10 | 1 | -1/+1 |
| | |||||
* | AS::Callbacks#_define_runner refactored | Bogdan Gusiev | 2011-11-10 | 1 | -23/+22 |
| | | | | | Incapsulate the logic of keyed callback method definition and execution in the separated method. | ||||
* | Remove `#among?` from Active Support | Prem Sichanugrist | 2011-04-13 | 1 | -1/+1 |
| | | | | | | After a long list of discussion about the performance problem from using varargs and the reason that we can't find a great pair for it, it would be best to remove support for it for now. It will come back if we can find a good pair for it. For now, Bon Voyage, `#among?`. | ||||
* | Change Object#either? to Object#among? -- thanks to @jamesarosen for the ↵ | David Heinemeier Hansson | 2011-04-12 | 1 | -1/+1 |
| | | | | suggestion! | ||||
* | Using Object#in? and Object#either? in various places | Prem Sichanugrist | 2011-04-11 | 1 | -1/+2 |
| | | | | There're a lot of places in Rails source code which make a lot of sense to switching to Object#in? or Object#either? instead of using [].include?. | ||||
* | Prevent callbacks in child classes from being executed more than once. | Rolf Timmermans | 2011-03-13 | 1 | -1/+1 |
| | |||||
* | adds a couple of missing AS dependencies | Rolf Timmermans | 2011-03-12 | 1 | -0/+1 |
| | |||||
* | Allow access to a callback event's return result from around callbacks | Aaron Pfeifer | 2011-03-08 | 1 | -2/+8 |
| | |||||
* | Merge branch 'master' of git://github.com/lifo/docrails | Xavier Noria | 2011-01-20 | 1 | -113/+116 |
|\ | |||||
| * | editing comments regarding rescuable optoin in AS callbacks | Neeraj Singh | 2011-01-12 | 1 | -2/+3 |
| | | |||||
| * | Expand and clarify AS::Callbacks docs. | John Firebaugh | 2011-01-09 | 1 | -113/+115 |
| | | |||||
* | | removing usesless variable assignments | Aaron Patterson | 2011-01-18 | 1 | -1/+5 |
|/ | |||||
* | expand on set_callback method to explain that in | Neeraj Singh | 2010-12-21 | 1 | -0/+4 |
| | | | | some cases an implicit :before is assumed | ||||
* | Replace nested ifs with case/when | Pavel Gorbokon | 2010-12-07 | 1 | -46/+44 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | Ommit nil in method call | Pavel Gorbokon | 2010-12-07 | 1 | -1/+1 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | bye bye extlib_inheritable_*, AS callbacks now using class_attribute | Josh Kalderimis | 2010-11-18 | 1 | -9/+13 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Correct documentation that references how *_filter of action_pack are ↵ | Marcelo Giorgi | 2010-10-03 | 1 | -2/+2 |
| | | | | translated into set_callback/run_callback's (from active_support) invocations. | ||||
* | after_create in ActiveModel should in the order specified | Neeraj Singh | 2010-09-27 | 1 | -1/+1 |
| | | | | | | [#5650 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | lifecycle should be two words, life cycle | Jaime Iniesta | 2010-08-26 | 1 | -1/+1 |
| | |||||
* | Deletes trailing whitespaces (over text files only find * -type f -exec sed ↵ | Santiago Pastorino | 2010-08-14 | 1 | -1/+1 |
| | | | | 's/[ \t]*$//' -i {} \;) | ||||
* | adding an example of skipping a callback | Neeraj Singh | 2010-08-06 | 1 | -1/+5 |
| | |||||
* | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-05 | 1 | -1/+2 |
|\ | |||||
| * | documents that :terminator is a string to be eval'ed, and that it sees the ↵ | Xavier Noria | 2010-08-05 | 1 | -1/+2 |
| | | | | | | | | result variable | ||||
| * | Revert "correcting the documentation that default to false. it does not ↵ | Xavier Noria | 2010-08-05 | 1 | -4/+5 |
| | | | | | | | | | | | | | | | | default to false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned" This reverts commit cd87cf771acb90c43cd56e5f038fc345a69790f9. Reason: it does default to "false". | ||||
| * | correcting the documentation that default to false. it does not default to ↵ | Neeraj Singh | 2010-08-05 | 1 | -5/+4 |
| | | | | | | | | false. returing either false or nil will not halt the chain unless :terminator is explicitly mentioned | ||||
* | | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-05 | 1 | -3/+3 |
|\| | |||||
| * | Fix ActiveSupport::Callbacks' define_callbacks and ActiveSupport::Concern ↵ | Tom Stuart | 2010-08-05 | 1 | -3/+3 |
| | | | | | | | | documentation to look like native English | ||||
* | | Merge remote branch 'docrails/master' | Xavier Noria | 2010-08-05 | 1 | -1/+3 |
|\| | |||||
| * | adding documentation to ActiveSupport::Concern ht:strictly typed for an ↵ | Neeraj Singh | 2010-08-04 | 1 | -1/+3 |
| | | | | | | | | | | | | awesome example some minor documentation changes | ||||
* | | Reload action_methods in AbstractController after defining new method. | Piotr Sarnacki | 2010-08-04 | 1 | -1/+4 |
|/ | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Define a convention for descendants and subclasses. | José Valim | 2010-07-05 | 1 | -2/+2 |
| | | | | | | The former should be symmetric with ancestors and include all children. However, it should not include self since ancestors + descendants should not have duplicated. The latter is symmetric to superclass in the sense it only includes direct children. By adopting a convention, we expect to have less conflict with other frameworks, as Datamapper. For this moment, to ensure ActiveModel::Validations can be used with Datamapper, we should always call ActiveSupport::DescendantsTracker.descendants(self) internally instead of self.descendants avoiding conflicts. | ||||
* | Change callbacks to automatically include DescendantsTracker and rename ↵ | José Valim | 2010-06-19 | 1 | -3/+7 |
| | | | | descendents to descendants. | ||||
* | edit pass: the names of Rails components have a space, ie, "Active Record", ↵ | Xavier Noria | 2010-06-14 | 1 | -1/+1 |
| | | | | not "ActiveRecord" | ||||
* | edit pass in #define_callbacks rdoc | Xavier Noria | 2010-06-14 | 1 | -20/+22 |
| | |||||
* | adding to the :kind documentation for ActiveSupport callbacks | Neeraj Singh | 2010-06-14 | 1 | -0/+5 |
| | |||||
* | clearer documentation of how scope applies to ActiveSupport callbacks | Neeraj Singh | 2010-06-14 | 1 | -20/+32 |
| | |||||
* | Simplify and optimize callbacks superclass sync. | José Valim | 2010-06-12 | 1 | -54/+21 |
| |