| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
`travel/travel_to` travel time helpers, now raise on nested calls
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
as this can lead to confusing time stubbing.
Instead of:
travel_to 2.days.from_now do
# 2 days from today
travel_to 3.days.from_now do
# 5 days from today
end
end
preferred way to achieve above is:
travel_to 2.days.from_now
# 2 days from today
travel_back
travel_to 5.days.from_now
# 5 days from today
Closes #24690
Fixes #24689
|
|\ \
| | |
| | | |
Use `squish` rather than `strip_heredoc`
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
HermanHiddema/fix/unnecessary-nesting-in-handle-dependency
Fixed unnecessary nesting in handle_dependency
|
| |/ /
| | |
| | |
| | |
| | | |
This nested if checked the same value as the containing case statement.
Moved the code in the if/else into when/else in the containing case.
|
|/ / |
|
|\ \
| | |
| | | |
Improve error message when record touch fails.
|
| | |
| | |
| | |
| | |
| | |
| | | |
The current error message only indicates that a touch can fail because the record is new. In practice, we saw cases where touches were failing because the record had been destroyed. `persisted?` checks `new_record?` *and* `destroyed?`. It was confusing to get a message about a new record when in reality we were destroying records.
I also included a helpful tip for users to consider using `persisted?`, `new_record?`, or `destroyed?` before touching.
|
|/ / |
|
| | |
|
|\ \
| | |
| | | |
Remove unused `predicate_builder` for `BasicObjectHandler` and `RangeHandler`
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
bquorning/optimize-for-first-result-and-remove-mysql-select_one
Remove #select_one from Mysql2Adapter
|
| | | |
| | | |
| | | |
| | | |
| | | | |
If you only want the last element of a result set, there's no need to create all
of hash_rows. Also, add a test.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The implementation from abstract/database_statements.rb seems to work just fine.
And with ActiveRecord::Result now implementing an optimized #first method, the
performance concerns previously addressed in
https://github.com/rails/rails/commit/bf79aa4fc14aeb2646331e767038acf0b77e9e7f
should not be an issue.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
When you only need the first element of a result set, you shouldn't need to
instantiate all of hash_rows.
|
|\ \ \ \
| | | | |
| | | | | |
Revert "Rename `active_record_internal_metadatas` to `ar_internal_metadata"
|
| | |_|/
| |/| |
| | | |
| | | | |
This reverts commit 407e0ab5e5cddf6a8b6b278b12f50772d13b4d86.
|
|\ \ \ \
| |_|_|/
|/| | | |
Remove `create_table_info_cache` because it not be reused
|
| |/ /
| | |
| | |
| | |
| | |
| | | |
`create_table_info_cache` is used for sharing `create_table_info` both
`table_options` and `foreign_keys`. But `foreign_keys` no longer uses
`create_table_info_cache` by #25307. No need caching anymore.
|
|\ \ \
| |/ /
|/| | |
Pass `pk: false` to `connection.insert` explicitly if do not have a primary key
|
| | |
| | |
| | |
| | |
| | |
| | | |
Because causing an extra query by `sql_for_insert` for guessing a
primary key.
https://github.com/rails/rails/blob/v5.0.0/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb#L121-L125
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If you had a foreign key set and then decided to add `on_delete:
:cascade` later in another migration that migration would run but
wouldn't refresh the schema dump.
The reason for this was because `create_table_info` caches the statement
and sets it to be the same as the original declaration for the foreign
key (without the `on_delete: :cascade`.
PR #25307 ended up fixing this bug because it removes the check for
`create_table_info` and relies on reading from `information_schema`. The
fix however was intended to patch another bug. The reason this fixes the
issue is we're no longer parsing the regex from the cached
`create_table_info`.
This regression test is to ensure that the issue does not return if we
for some reason go back to using `create_table_info` to set the foreign
keys.
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
kamipo/extract_foreign_key_action_from_information_schema
Extract foreign key action from `information_schema`
|
| | |
| | |
| | |
| | | |
Fixes #25300.
|
| | | |
|
| | |
| | |
| | |
| | | |
preventing infinite looping in some cases.
|
| | |
| | |
| | |
| | |
| | |
| | | |
Right now with this middleware we are likely always connected, but I'm
hoping to change that soon. This is an easy change to pull out on its
own.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This method appears to have been partially used in connection pool
caching, but it was introduced without much reasoning or any tests. One
edge case test was added later on, but it was focused on implementation
details. This method is no longer used outside of tests, and as such is
removed.
|
|\ \ \
| | | |
| | | | |
Fix `Type::Date#serialize` to return a date object correctly
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently `Type::Date#serialize` does not cast a value to a date object.
It should be cast to a date object for finding by date column correctly
working.
Fixes #25354.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This was added at c7c3f73 but it never raised because MySQL cannot
create text/blob columns with a default value.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As mentioned in 7b86ea6715ee987e61a7f3bd8e72b1bbfcfbbbe7, this is an
internal class.
[ci skip]
r? @sgrif
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveRecord::AttributeSet::YAMLEncoder#decode"
This reverts commit 7ea502ae141fc26b736c7a73bdf7a676b1f9fc87, per
internal discussion with @sgrif -- this is documenting the
implementation of a class that isn't intended to be public API.
|
|\ \ \ \
| |_|_|/
|/| | | |
return correct type from `EnumType`
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
- `with_exclusive_scope` was removed in this commit d242e467819a428ad7e302968e4c9fa1e26d9326
|
|/ / / |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Improve mysqldump
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
I think these are meant to be in the root directory, not in
`/activerecord`? :grimacing:
r? @sgrif
[ci skip]
|
|\ \ \ \
| |_|/ /
|/| | | |
PostgreSQL: Fix db:structure:load silent failure on SQL error
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The command line flag "-v ON_ERROR_STOP=1" should be used when invoking psql to make sure errors are not suppressed.
Example: psql -v ON_ERROR_STOP=1 -q -f awesome-file.sql my-app-db
Fixes #23818.
|
|\ \ \ \
| | | | |
| | | | | |
Prevent `RangeError` for `FinderMethods#exists?`
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
`FinderMethods#exists?` should return a boolean rather than raising an
exception.
`UniquenessValidator#build_relation` catches a `RangeError` because it
includes type casting due to a string value truncation. But a string
value truncation was removed at #23523 then type casting in
`build_relation` is no longer necessary. aa06231 removes type casting in
`build_relation` then a `RangeError` moves to `relation.exists?`.
This change will remove the catching a `RangeError`.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | | |
Type casting in uniqueness validator is for a string value truncation.
It was removed at #23523.
|