| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
frameworks like ActiveRecord and ActiveResource to log outsude Rails::Application [#4816 state:resolved]
|
|
|
|
|
|
| |
[#4882 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
| |
[#4547 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
|
|
| |
is sql reserved word
[#4945 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
| |
Cloning an active record object should be shallow in that it should copy attributes but not associations. This was no longer true as a result of #3164.
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
| |
[#4803 state:resolved]
Signed-off-by: Michael Koziarski <michael@koziarski.com>
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hash and make various Validators pass their (filtered) options.
This makes it possible to pass additional options through Validators to message generation. E.g. plugin authors want to add validates_presence_of :foo, :format => "some format".
Also, cleanup the :default vs :message options confusion in ActiveModel validation message generation.
Also, deprecate ActiveModel::Errors#add_on_blank(attributes, custom_message) in favor of ActiveModel::Errors#add_on_blank(attributes, options).
Also, refactoring of ActiveModel and ActiveRecord Validation tests. Test are a lot more DRY now. Better test coverage as well now.
The first four points were reapplied from an older patch of Sven Fuchs which didn't apply cleanly anymore and was not complete yet.
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
| |
state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
|
|
| |
order of the loaded records. Reapplied from before but now allows already-saved records to be refreshed.
[#4830 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| | |
connection
[#4689 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
| |
| |
| |
| |
| |
| | |
[#2991]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
|/ |
|
|
|
|
|
|
| |
state:resolved]
Signed-off-by: Carl Lerche <carllerche@mac.com>
|
|
|
|
| |
not "ActiveRecord"
|
|
|
|
|
|
|
|
| |
preserve the order of the loaded records. [#4642 state:open]"
This commit introduced a regression described in ticket [#4830].
This reverts commit 0265c708b9696c3943518ad5f3dabdc22c5eba11.
|
|
|
|
|
|
| |
[#4804 state:resolved]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
|
|
|
|
|
|
| |
order of the loaded records. [#4642 state:resolved]
Signed-off-by: Pratik Naik <pratiknaik@gmail.com>
|
|
|
|
|
|
| |
8.4 failing test
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
|
|
| |
tests to use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction.""
This reverts commit 1b2941cba1165b0721f57524645fe378bee2a950.
[#2991]
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
| |
state:resolved]
Signed-off-by: David Heinemeier Hansson <david@loudthinking.com>
|
|
|
|
| |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use new style API with an :on options instead of on_* suffix." and "Add after_commit and after_rollback callbacks to ActiveRecord that are called after transactions either commit or rollback on all records saved or destroyed in the transaction."
This reverts commits d2a49e4b1f30c5997e169110eed94a55aee53f56 and da840d13da865331297d5287391231b1ed39721b.
[#2991]
Conflicts:
activerecord/CHANGELOG
activerecord/lib/active_record/transactions.rb
activerecord/test/cases/transaction_callbacks_test.rb
|
|
|
|
|
|
| |
[#4679 state:committed]
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
|\ |
|
| |
| |
| | |
Oracle does not guarantee that SELECT will return records ordered by primary key
|
| | |
|
| |
| |
| |
| | |
Fixed adapter test cases that were failing in oracle because the asserts were looking for the presence of offset and limit which are not available in oracle. Changed the tests to check that the sql injection is not present in the output so that the tests are database adapter agnostic.
|
| | |
|
| |
| |
| |
| | |
quoted table name is in uppercase (when using Oracle)
|
| |
| |
| |
| |
| | |
latest oracle_enhanced adapter does automatic shortening of index names
ignore select from all_triggers table in assert_queries
|
| |
| |
| |
| | |
(as otherwise was failing under JRuby and oracle_enhanced adapter)
|
| |
| |
| |
| | |
names, some additional tests now pass
|
| |
| |
| |
| | |
identifier name cannot be larger than 30 characters
|
| |
| |
| |
| |
| |
| | |
enhanced adapter is used
(otherwise some tests are failing which assume that this attribute will have Date value)
|
| |
| |
| |
| |
| |
| | |
value with local offset
(otherwise test is failing for oracle_enhanced JDBC adapter)
|
| |
| |
| |
| | |
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
|
| | |
|
| |
| |
| |
| | |
Signed-off-by: José Valim <jose.valim@gmail.com>
|
|/
|
|
| |
thanks to Marc-Andre Lafortune
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| |
| |
| | |
e.g. it guesses that a belongs_to association to Namespace::MyModel is
named "my_model", unlike before where it would look up an association
named "namespace::mymodel" and fail.
|