| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
make AbstractAdapter#subquery_for private
|
| | |
|
| | |
|
|\ \
| | |
| | | |
Use `select_value` for avoid `ActiveRecord::Result` instance creating
|
| | |
| | |
| | |
| | |
| | | |
`exec_query` create `ActiveRecord::Result` instance. It is better to use
`select_value` instead of `exec_query` for performance.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
kamipo/use_select_rows_instead_of_select_one_in_select_values
Use `select_rows` instead of `select_one` in `select_value`
|
| |/ /
| | |
| | |
| | |
| | | |
`select_one` create `ActiveRecord::Result` instance. It is better to use
`select_rows` instead of `select_one` for performance.
|
|\ \ \
| |/ /
|/| | |
Apply schema cache dump when creating connections
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The `db:schema:cache:dump` rake task dumps the database schema structure
to `db/schema_cache.dump`. If this file is present, the schema details
are loaded into the currently checked out connection by a railtie while
Rails is booting, to avoid having to query the database for its schema.
The schema cache dump is only applied to the initial connection used to
boot the application though; other connections from the same pool are
created with an empty schema cache, and still have to load the structure
of each table directly from the database.
With this change, a copy of the schema cache is associated with the
connection pool and applied to connections as they are created.
|
| | | |
|
| | |
| | |
| | |
| | |
| | | |
MySQL does not support partial index. And, the create index algorithm in
create table can not be specified.
|
|\ \ \
| | | |
| | | |
| | | | |
Dump indexes in `create_table` instead of `add_index`
|
| | | |
| | | |
| | | |
| | | |
| | | | |
If the adapter supports indexes in create table, generated SQL is
slightly more efficient.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
yuki24/change-record-not-saved-and-not-destroyed-to-include-error-msg
AR::RecordNotSaved & RecordNotDestroyed from save!/destroy! should include an error message
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When `AR::Base.save!` or `AR::Base.destroy!` is called and an exception
is raised, the exception doesn't have any error message or has a weird
message like `#<FailedBulb:0x0000000907b4b8>`. Give a better message so
we can easily understand why it's failing to save/destroy.
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Correctly dump `:options` on `create_table` for MySQL
|
| |/ / / / |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
PostgreSQL: `:collation` support for string and text columns
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Example:
create_table :foos do |t|
t.string :string_en, collation: 'en_US.UTF-8'
t.text :text_ja, collation: 'ja_JP.UTF-8'
end
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Some databases like MySQL allow defining collation charset for specific
columns.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Change the `visit_AddColumn` visiblity for the internal API
|
| | |_|/ / /
| |/| | | | |
|
| |/ / / /
|/| | | | |
|
|\ \ \ \ \
| |_|_|_|/
|/| | | | |
Move comment about microseconds [ci skip]
|
| |/ / /
| | | |
| | | |
| | | | |
The microseconds handling was already moved to `Quoting#quoted_date`.
|
| | | |
| | | |
| | | |
| | | | |
Follow up #18914.
|
|/ / /
| | |
| | |
| | |
| | | |
Its nodoc'ed for the other implementations, and doc'ed in the base
class, just like the other change_column* methods.
|
|/ /
| |
| |
| |
| |
| | |
`change_column_null` is doc'ed only in
ActiveRecord::ConnectionAdapters::SchemaStatements, so it would make
sense to :nodoc: it elsewhere.
|
| | |
|
|\ \
| | |
| | | |
Nodoc validate_index_length! method
|
| |/
| |
| |
| | |
- This method is used only by adapters to validate length of new index names.
|
|/
|
|
|
|
| |
- Added documentation for index_name_exists? and rename_index.
- Also changed rails to \Rails in documentation of
allowed_index_name_length.
|
| |
|
|\
| |
| |
| | |
Fix unscope for less than
|
| |
| |
| |
| |
| |
| | |
Code such as the following will be corrected.
Developer.where(id: -Float::INFINITY...2).unscope(where: :id)
|
|\ \
| | |
| | |
| | | |
Raise ArgumentError when find_by receives no arguments
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
It fixes the strange error saying undefined method `take'.
```
RelationTest#test_find_by_without_arg_behaves_same_with_find_by({}):
NoMethodError: undefined method `take' for #<ActiveRecord::QueryMethods::WhereChain:0x007f9c55db1d68>
```
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Add note about sti column value to becomes method [ci skip]
|
|/ / / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
calebthompson/dont-rely-on-environment-task-for-schema-load"
This reverts commit 08ff4ccbbb3fb143a02e6752efb974a4bcfcd3bb, reversing
changes made to 6c9ed6dbc62450cdb87559afd15798305e069146.
Caused by #17920.
Closes #19545.
This patch introduced regressions because initializers were no longer
loaded. Specifically missing inflections result in broken restores of
the database.
|
| | |
| | |
| | |
| | | |
Also added reference for to_date, as it belongs historically.
|
| | |
| | |
| | |
| | | |
follow up to 107526e809ea2b6de8b2775ecf83e55d60833206
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
Fix missing index when using timestamps with index
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The `index` option used with `timestamps` should be passed to both
`column` definitions for `created_at` and `updated_at` rather than just
the first.
This was happening because `Hash#delete` is used to extract the `index`
option passed to `timestamps`, thereby mutating the `options` hash
in-place. Now take a copy of the `options` before deleting so that the
original is not modified.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In 1f006c an option was added called :class to allow passing anonymous
classes to association definitions. Since using :class instead of
:class_name is a fairly common typo even amongst experienced developers
this can result in hard to debug errors arising in raise_on_type_mismatch?
To fix this we're renaming the option from :class to :anonymous_class as
that is a more correct description of what the option is for. Since this
was an internal, undocumented option there is no need for a deprecation.
Fixes #19659
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This will avoid the indirection of having calling id since we already
know which is the primary key column.
Also this will make explicit the behavior since it is not clear that id
gets the right primary key value and not just the value of the "id"
column.
|
|\ \ \ \
| | | | |
| | | | | |
Raise StaleObjectError if touched object is stale and locking is enabled
|