Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Improve the performance of reading attributes | Sean Griffin | 2014-11-18 | 1 | -1/+1 |
| | | | | | | | We added a comparison to "id", and call to `self.class.primary_key` a *lot*. We also have performance hits from `&block` all over the place. We skip the check in a new method, in order to avoid breaking the behavior of `read_attribute` | ||||
* | [ci skip] fix doc typo for validates_uniqueness_of | Satoru Yamasaki | 2014-07-29 | 1 | -1/+1 |
| | |||||
* | Remove the `text?` predicate from the type objects | Sean Griffin | 2014-07-06 | 1 | -2/+4 |
| | | | | | | | This was only used for uniqueness validations. The first usage was in conjunction with `limit`. Types which cast to string, but are not considered text cannot have a limit. The second case was only with an explicit `:case_sensitive => true` option given by the user. | ||||
* | Don't rely on the column for type casting reflections | Sean Griffin | 2014-06-18 | 1 | -1/+1 |
| | |||||
* | Remove most code related to serialized properties | Sean Griffin | 2014-06-01 | 1 | -7/+0 |
| | | | | | | | | | | | Nearly completely implemented in terms of custom properties. `_before_type_cast` now stores the raw serialized string consistently, which removes the need to keep track of "state". The following is now consistently true: - `model.serialized == model.reload.serialized` - A model can be dumped and loaded infinitely without changing - A model can be saved and reloaded infinitely without changing | ||||
* | Merge pull request #15210 from arthurnn/fix_hbtm_reflection | Arthur Neves | 2014-05-24 | 1 | -2/+2 |
| | | | | | | | | | Fix habtm reflection Conflicts: activerecord/CHANGELOG.md activerecord/lib/active_record/counter_cache.rb activerecord/lib/active_record/reflection.rb activerecord/test/cases/reflection_test.rb | ||||
* | Follow up to bbe7fe41 to fix enum leakage across classes. | Godfrey Chan | 2014-04-07 | 1 | -1/+1 |
| | | | | | | | | The original attempt didn't really fix the problem and wasn't testing the problematic area. This commit corrected those issues in the original commit. Also removed the private `enum_mapping_for` method. As `defined_enums` is now a method, this method doesn't provide much value anymore. | ||||
* | Merge pull request #13040 from kamipo/case_sensitive_comparison | Rafael Mendonça França | 2014-03-12 | 1 | -2/+1 |
|\ | | | | | | | | | | | | | Only use BINARY for mysql case sensitive uniqueness check when column has a case insensitive collation. Conflicts: activerecord/CHANGELOG.md | ||||
| * | Only use BINARY for mysql case sensitive uniqueness check when column has a ↵ | Ryuta Kamizono | 2013-11-26 | 1 | -2/+1 |
| | | | | | | | | case insensitive collation. | ||||
* | | Whitespaces | Rafael Mendonça França | 2014-03-10 | 1 | -2/+2 |
| | | |||||
* | | Fix a bug affecting validations of enum attributes | TheMonster | 2014-02-27 | 1 | -0/+7 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug where any enum attribute of a model would be evaluated always as 0 when calling the database on validations. This fix converts the value of the enum attribute to its integer value rather than the string before building the relation as the bug occured when the string finally gets converted to integer using string.to_i which converts it to 0. [Vilius Luneckas, Ahmed AbouElhamayed] | ||||
* | | Cleanups in API docs: his => their | Guillermo Iguaran | 2013-12-02 | 1 | -2/+2 |
| | | |||||
* | | Use genderless pronouns in API docs | Guillermo Iguaran | 2013-12-01 | 1 | -1/+1 |
| | | |||||
* | | Merge pull request #13061 from ↵ | Rafael Mendonça França | 2013-11-26 | 1 | -1/+9 |
|/ | | | | | | | | laurocaetano/fix-uniqueness-validation-for-aliased-attribute Fix bug when validating the uniqueness of an aliased attribute. Conflicts: activerecord/CHANGELOG.md | ||||
* | Fix validation on uniqueness of empty association | Evgeny Li | 2013-11-22 | 1 | -1/+1 |
| | |||||
* | replace artificial space with RDoc markup (follow up #11285). [ci skip] | Yves Senn | 2013-07-04 | 1 | -2/+2 |
| | |||||
* | [ci skip] Separated full stop from the Optimistic_concurrency_control wiki ↵ | ankit8898 | 2013-07-04 | 1 | -1/+1 |
| | | | | link d4e3f8ba826cd42aa3c242149 | ||||
* | deprecate Validator#setup (to get rid of a respond_to call). validators do ↵ | Nick Sutterer | 2013-05-23 | 1 | -6/+1 |
| | | | | their setup in their constructor now. | ||||
* | Change uniq validation with conditions examples to use where with hashes | Carlos Antonio da Silva | 2013-03-09 | 1 | -3/+3 |
| | | | | Take the opportunity to showcase where.not. | ||||
* | Uniqueness validation uses a proc to specify the `:conditions` option. | Yves Senn | 2013-03-09 | 1 | -3/+7 |
| | | | | | This is a follow up to #5321 and follows the general direction in AR to make things lazy evaluated. | ||||
* | Extract some methods | Carlos Antonio da Silva | 2012-12-18 | 1 | -16/+22 |
| | |||||
* | Change relation in place | Carlos Antonio da Silva | 2012-12-18 | 1 | -1/+1 |
| | |||||
* | Simplify value logic by always typecasting | Carlos Antonio da Silva | 2012-12-18 | 1 | -11/+5 |
| | |||||
* | Avoid unnecessary hashes with error options | Carlos Antonio da Silva | 2012-12-18 | 1 | -1/+4 |
| | |||||
* | Remove prepend_and_append requirement from AS | Carlos Antonio da Silva | 2012-12-18 | 1 | -3/+1 |
| | | | | It's not necessary to use this extension here, we are fine with Array#unshift. | ||||
* | Refactor uniqueness validator logic a bit | Carlos Antonio da Silva | 2012-12-18 | 1 | -10/+5 |
| | | | | | Cleanup some code, avoid extra hash with reverse_merge, and don't use send for :id, since it's always present. | ||||
* | Added support for validates_uniqueness_of in PostgreSQL array columns. ↵ | Pedro Padron | 2012-12-18 | 1 | -1/+6 |
| | | | | Fixes: #8075. | ||||
* | refactoring of uniqueness validate_each | Angelo Capilleri | 2012-10-14 | 1 | -1/+2 |
| | | | | get scope_value only one time dependig on reflection | ||||
* | small refactoring of build_relation in uniqueness | Angelo Capilleri | 2012-09-29 | 1 | -5/+3 |
| | | | | | reflection init as 'if' stantment. column is always the same expression and depends from the changing of attributes | ||||
* | update AR::Validations documentation [ci skip] | Francesco Rodriguez | 2012-09-22 | 1 | -6/+6 |
| | |||||
* | update AR::Validations::UniquenessValidator documentation [ci skip] | Francesco Rodriguez | 2012-07-29 | 1 | -31/+45 |
| | |||||
* | Fixes "Cannot visit ..." with validates_uniqueness_of | beerlington | 2012-07-17 | 1 | -1/+1 |
| | | | | | | Fixes issue with overrding ActiveRecord reader methods with a composed object and using that attribute as the scope of a validates_uniqueness_of validation. | ||||
* | fix tests for SQLite3Adapter | Andrey Deryabin | 2012-04-27 | 1 | -1/+0 |
| | |||||
* | Correct grammar in documentation | Mattias Pfeiffer | 2012-03-07 | 1 | -1/+1 |
| | |||||
* | Change syntax to accept an AR::Relation instead of old conditions hash/array. | Mattias Pfeiffer | 2012-03-07 | 1 | -3/+9 |
| | |||||
* | Add :conditions option to uniqueness validator | Mattias Pfeiffer | 2012-03-07 | 1 | -2/+12 |
| | |||||
* | say unshift when you mean unshift (modulus prepend) | Xavier Noria | 2012-02-11 | 1 | -1/+3 |
| | |||||
* | Remove initialize variable columnn, not needed | Paco Guzman | 2012-01-29 | 1 | -2/+1 |
| | |||||
* | allow association as 1st uniqueness validation arg | Dan Pickett | 2012-01-06 | 1 | -1/+9 |
| | | | #4321 | ||||
* | allow an association as a scope parameter | Dan Pickett | 2012-01-06 | 1 | -0/+5 |
| | | | #4321 | ||||
* | Fixed nil field value uniqueness check | pyromaniac | 2012-01-06 | 1 | -2/+2 |
| | |||||
* | Revert "Merge pull request #2325 from pyromaniac/master" | José Valim | 2012-01-06 | 1 | -1/+1 |
| | | | | | | | It breaks the build for mysql. This reverts commit 958d25df4a1b0d41ce5deeeb0739c93b49bbd18d, reversing changes made to 8f309e31057e1b26fefedb199ab0526126fb1fe4. | ||||
* | Merge pull request #4340 from rafaelfranca/patch-1 | José Valim | 2012-01-05 | 1 | -4/+2 |
|\ | | | | | Remove more Array.wrap calls | ||||
| * | Whitespaces :scissors: | Rafael Mendonça França | 2012-01-06 | 1 | -1/+1 |
| | | |||||
| * | Remove Array.wrap calls in ActiveRecord | Rafael Mendonça França | 2012-01-06 | 1 | -3/+1 |
| | | |||||
* | | Fixed nil field value uniqueness check | pyromaniac | 2012-01-06 | 1 | -1/+1 |
|/ | |||||
* | remove useless call to mb_chars | Sergey Nartimov | 2012-01-05 | 1 | -1/+1 |
| | |||||
* | Only use LOWER for mysql case insensitive uniqueness check when column has a ↵ | Joseph Palermo | 2011-10-09 | 1 | -2/+2 |
| | | | | case sensitive collation. | ||||
* | Remove extra white spaces on ActiveRecord docs. | Sebastian Martinez | 2011-05-23 | 1 | -2/+2 |
| | |||||
* | Do not use SQL LIKE operator for case insensitive uniqueness validation | Raimonds Simanovskis | 2011-04-25 | 1 | -2/+3 |
| | | | It can result in wrong results if values contain special % or _ characters. It is safer to use SQL LOWER function and compare for equality. |