Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Refactor the handling of default_url_options in integration tests | Andrew White | 2012-05-10 | 2 | -7/+104 |
| | | | | | | | | | | | | This commit improves the handling of default_url_options in integration tests by making behave closer to how a real application operates. Specifically the following issues have been addressed: * Options specified in routes.rb are used (fixes #546) * Options specified in controllers are used * Request parameters are recalled correctly * Tests can override default_url_options directly | ||||
* | remove duplicate usage of Rack::Utils.status_code in ↵ | Rafael Magana | 2012-05-10 | 1 | -1/+1 |
| | | | | LogSubscriber#process_action | ||||
* | removing key argument from run_callbacks - fix build | Francesco Rodriguez | 2012-05-10 | 1 | -1/+1 |
| | |||||
* | Refactor Generator class to not rely on in-place editing the controller | Andrew White | 2012-05-09 | 2 | -11/+16 |
| | |||||
* | Fix bug when url_for changes controller. | Nikita Beloglazov | 2012-05-09 | 2 | -2/+11 |
| | |||||
* | fix a couple of formatting issues [ci skip] | Vijay Dev | 2012-05-09 | 1 | -2/+4 |
| | |||||
* | update some examples in asset tag helper docs [ci skip] | Vijay Dev | 2012-05-09 | 1 | -15/+15 |
| | |||||
* | remove redundant and stray line [ci skip] | Vijay Dev | 2012-05-09 | 1 | -2/+0 |
| | |||||
* | Merge branch 'master' of github.com:lifo/docrails | Vijay Dev | 2012-05-08 | 5 | -105/+180 |
|\ | |||||
| * | Fix NumberHelper options wrapping to prevent verbatim blocks being rendered ↵ | Mark J. Titorenko | 2012-05-08 | 1 | -92/+161 |
| | | | | | | | | instead of line continuations. While I'm at it, wrap long comment lines consistently. | ||||
| * | Add example for image_submit_tag with confirmation. [ci skip] | Edward Tsech | 2012-05-08 | 1 | -0/+3 |
| | | |||||
| * | Add annotaion for class_eval in AbstractController#helper_method [ci skip] | Edward Tsech | 2012-05-08 | 1 | -3/+3 |
| | | |||||
| * | Improve readability of metaprogramming annotations at AbstractController ↵ | Edward Tsech | 2012-05-08 | 1 | -10/+10 |
| | | | | | | | | callbacks. | ||||
| * | Added reference to I18n.localize, as discussed here: | Ernesto Tagwerker | 2012-05-04 | 1 | -0/+3 |
| | | | | | | | | https://github.com/rails/rails/issues/4027 | ||||
* | | Add failing test re #3436 which demonstrates content_type is not respected ↵ | Kunal Shah | 2012-05-08 | 1 | -0/+21 |
| | | | | | | | | when using the :head method/shortcut | ||||
* | | If content_type is explicitly passed to the :head method use the value or ↵ | Kunal Shah | 2012-05-08 | 1 | -1/+2 |
| | | | | | | | | fallback | ||||
* | | Add passing tests for generating URLs with nested SCRIPT_NAMEs | Jeremy Kemper | 2012-05-07 | 2 | -3/+17 |
| | | |||||
* | | Merge pull request #5368 from andhapp/remove-max-stale | José Valim | 2012-05-07 | 1 | -4/+4 |
|\ \ | | | | | | | Minor test improvement | ||||
| * | | Removed max-stale from the tests since it's a request cache-control ↵ | Anuj Dutta | 2012-03-10 | 1 | -4/+4 |
| | | | | | | | | | | | | directive, just for clarity sake. | ||||
* | | | Merge pull request #6182 from shaliko/change_unless_else_into_if_else | José Valim | 2012-05-07 | 1 | -3/+3 |
|\ \ \ | | | | | | | | | Change unless + else into if + else | ||||
| * | | | Change unless + else into if + else | Shaliko Usubov | 2012-05-06 | 1 | -3/+3 |
| | | | | |||||
* | | | | Fix that optimized named routes should also work as singleton methods on the ↵ | Jeremy Kemper | 2012-05-06 | 2 | -1/+26 |
| | | | | | | | | | | | | | | | | url_helpers module | ||||
* | | | | doc edits [ci skip] | Vijay Dev | 2012-05-06 | 1 | -3/+2 |
| | | | | |||||
* | | | | Merge pull request #5924 from cjolly/signed-cookies-docs | Vijay Dev | 2012-05-06 | 1 | -3/+5 |
|\ \ \ \ | |/ / / |/| | | | Improve signed cookies documentation | ||||
| * | | | Improve signed cookies documentation | Chad Jolly | 2012-04-21 | 1 | -3/+5 |
| | | | | |||||
* | | | | Fix typo in submit_tag helper documentation | Alex Soulim | 2012-05-06 | 1 | -1/+1 |
| | | | | |||||
* | | | | Update actionpack/CHANGELOG.md | José Valim | 2012-05-06 | 1 | -1/+5 |
| | | | | |||||
* | | | | remove .new from raise ActionController::UnknownFormat | Steven Soroka | 2012-05-06 | 1 | -1/+1 |
| | | | | |||||
* | | | | added an integration test that checks ActionController::UnknownFormat ↵ | Steven Soroka | 2012-05-06 | 1 | -0/+9 |
| | | | | | | | | | | | | | | | | renders 406 :not_acceptable | ||||
* | | | | Raise a rescuable exception when Rails doesn't know what to do with the ↵ | Steven Soroka | 2012-05-06 | 4 | -15/+24 |
| | | | | | | | | | | | | | | | | format, rather than responding with a head :not_acceptable (406) | ||||
* | | | | check checkboxes with array of strings as :checked option | Vasiliy Ermolovich | 2012-05-05 | 2 | -1/+10 |
| | | | | |||||
* | | | | Try to convert object passed to debug_hash to hash | Piotr Sarnacki | 2012-05-05 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | SessionStore was recently changed to delegate to hash object instead of inherit from it. Since we don't want to extend SessionStore with every method implemented in Hash, it's better to just convert any object passed to debug_hash (which is also better as we don't require to pass Hash instance there, it can be any object that can be converted to Hash). | ||||
* | | | | need to dup the default options so that mutations will not impact us | Aaron Patterson | 2012-05-04 | 1 | -1/+1 |
| | | | | |||||
* | | | | make sure the superclass matches so load order does not matter | Aaron Patterson | 2012-05-04 | 2 | -2/+2 |
| | | | | |||||
* | | | | Use Hash#fetch instead of has_key? check | Carlos Antonio da Silva | 2012-05-04 | 1 | -1/+1 |
| | | | | |||||
* | | | | Merge pull request #4445 from nragaz/role_based_params_wrapping | José Valim | 2012-05-04 | 2 | -4/+18 |
| | | | | | | | | | | | | | | | | specify a role for identifying accessible attributes when wrapping params | ||||
* | | | | Improve assert_template layout checking | Alexey Vakhov | 2012-05-04 | 2 | -3/+30 |
| | | | | |||||
* | | | | Fix assert_template :layout => nil assertion | Alexey Vakhov | 2012-05-04 | 2 | -2/+17 |
| | | | | |||||
* | | | | Fix assert_template assertion with :layout option | Alexey Vakhov | 2012-05-04 | 3 | -1/+13 |
| | | | | |||||
* | | | | Merge pull request #6160 from ↵ | Aaron Patterson | 2012-05-04 | 3 | -5/+13 |
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | carlosantoniodasilva/resource-route-canonical-action Force given path to http methods in mapper to skip canonical action checking | ||||
| * | | | | Force given path to http methods in mapper to skip canonical action checking | Carlos Antonio da Silva | 2012-05-04 | 3 | -5/+13 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the following scenario: resources :contacts do post 'new', action: 'new', on: :collection, as: :new end Where the /new path is not generated because it's considered a canonical action, part of the normal resource actions: new_contacts POST /contacts(.:format) contacts#new Fixes #2999 | ||||
* | | | | | fix doc [ci skip] | Vijay Dev | 2012-05-04 | 1 | -1/+1 |
| | | | | | |||||
* | | | | | session creation methods to a module | Aaron Patterson | 2012-05-04 | 3 | -24/+11 |
| | | | | | |||||
* | | | | | Merge pull request #6154 from shaliko/patch-1 | Vijay Dev | 2012-05-04 | 1 | -1/+6 |
|\ \ \ \ \ | |/ / / / |/| | | | | Update documentation for button_to. | ||||
| * | | | | Update documentation for button_to. | Shalva Usubov | 2012-05-04 | 1 | -1/+6 |
| | |_|/ | |/| | | |||||
* | | | | update invalid partial error message as per ↵ | Vijay Dev | 2012-05-04 | 1 | -4/+4 |
| | | | | | | | | | | | | | | | | 04202a3f8d66c0675eac41fbf63309f4be356e81 | ||||
* | | | | Merge pull request #6159 from marcandre/fix_bad_partial_error_mess | Vijay Dev | 2012-05-04 | 1 | -2/+2 |
|\ \ \ \ | | | | | | | | | | | Adjust error message for partial names starting with an uppercase letter... | ||||
| * | | | | Adjust error message for partial names starting with an uppercase letter. | Marc-Andre Lafortune | 2012-05-04 | 1 | -2/+2 |
| | | | | | |||||
* | | | | | create a request session in the cookie stores | Aaron Patterson | 2012-05-04 | 1 | -0/+8 |
| | | | | | |||||
* | | | | | create a request::session object in the memecache store middleware | Aaron Patterson | 2012-05-04 | 1 | -0/+10 |
|/ / / / |