Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | Merge pull request #8704 from senny/remove_regexp_global_from_url_for | Aaron Patterson | 2013-02-14 | 2 | -2/+9 | |
|\ \ \ | | | | | | | | | replace regexp global in #url_for | |||||
| * | | | replace regexp global in #url_for | Yves Senn | 2013-01-16 | 2 | -2/+9 | |
| | | | | ||||||
* | | | | Bump rack-test dependency to 0.6.2 | Rahul P. Chaudhari | 2013-02-14 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Avoid to_sym calls | Santiago Pastorino | 2013-02-13 | 1 | -1/+1 | |
| | | | | ||||||
* | | | | Improve changelog entry from #9221 [ci skip] | Carlos Antonio da Silva | 2013-02-11 | 2 | -18/+16 | |
| | | | | ||||||
* | | | | Merge pull request #9221 from thenickcox/image_alt_attribute | Carlos Antonio da Silva | 2013-02-11 | 3 | -4/+40 | |
|\ \ \ \ | | | | | | | | | | | Improve img alt attribute for screen readers | |||||
| * | | | | Improve img alt attribute for screen readers | thenickcox | 2013-02-09 | 3 | -4/+40 | |
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the img_alt method in ActionView keeps underscores in the alt attribute. Because underscores are pronounced in Apple's VoiceOver Utility, this has serious implications for accessibility. This patch makes underscored or hyphenated file names (both common in projects) read more naturally in screen readers by replacing them with spaces. See method documentation for details. Added documentation to image_alt method | |||||
* | | | | the `:controller` option for routes can contain numbers. closes #9231. | Yves Senn | 2013-02-09 | 2 | -1/+13 | |
| | | | | ||||||
* | | | | Add missing require to AP | Carlos Antonio da Silva | 2013-02-08 | 1 | -0/+1 | |
| | | | | ||||||
* | | | | We don't need a CHANGELOG entry for an issue of something that was not ↵ | Santiago Pastorino | 2013-02-08 | 1 | -5/+0 | |
| | | | | | | | | | | | | | | | | released yet | |||||
* | | | | Merge pull request #9196 from AndreyChernyh/fix-cookies-with-null-session | Santiago Pastorino | 2013-02-08 | 4 | -5/+49 | |
|\ \ \ \ | | | | | | | | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | |||||
| * | | | | Fix #9168 Initialize NullCookieJar with all options needed for KeyGenerator | Andrey Chernih | 2013-02-08 | 4 | -5/+49 | |
| |/ / / | ||||||
* / / / | Bump rack dependency to 1.5.2 | Santiago Pastorino | 2013-02-08 | 1 | -1/+1 | |
|/ / / | ||||||
* | | | Update actionpack/CHANGELOG.md | Rafael Mendonça França | 2013-02-06 | 1 | -4/+4 | |
| | | | | | | | | | [ci skip] | |||||
* | | | ruby constant syntax is not supported as routing `:controller` option. | Yves Senn | 2013-02-06 | 3 | -9/+59 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current implementation only works correctly if you supply the `:controller` with directory notation (eg. `:controller => 'admin/posts'`). The ruby constant notation (eg. `:controller => 'Admin::Posts`) leads to unexpected problems with `url_for`. This patch prints a warning for every non supported `:controller` option. I also added documentation how to work with namespaced controllers. The warning links to that documentation in the rails guide. | |||||
* | | | partials inside directory work with `assert_template` | Yves Senn | 2013-02-04 | 6 | -3/+30 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | previously when a partial was placed inside a directory (eg. '/dir/_partial'), `assert_template` did not replace the '_' prefix when looking through rendered tempaltes, which resulted in an error. I modified it to replace both, the leading '_' and the last '_' after a '/'. | |||||
* | | | descriptive `assert_template` error when partial wasn't rendered | Yves Senn | 2013-02-04 | 3 | -0/+16 | |
| | | | | | | | | | | | | | | | | | | | | | When `assert_template` is used with the :locals option, and the partial was not rendered, a method_missing error was raised. This changes first checks, if the partial actually was rendered and raises a descriptive error. | |||||
* | | | Put .rdoc at the end of the files named RUNNING_UNIT_TESTS | Yuki Nishijima | 2013-02-03 | 1 | -0/+0 | |
| |/ |/| | | | | | So that they are printed nicely on GitHub. | |||||
* | | Fix markdown syntax in actionpack CHANGELOG. | Steve Klabnik | 2013-02-01 | 1 | -1/+2 | |
| | | | | | | | | Starting a line with an octothorpe makes an <h1> | |||||
* | | Missing require hash/keys | Akira Matsuda | 2013-02-01 | 2 | -0/+3 | |
| | | ||||||
* | | Missing or unneeded require extract_options | Akira Matsuda | 2013-02-01 | 10 | -1/+10 | |
| | | ||||||
* | | Use \A in Regexps | Egor Homakov | 2013-02-01 | 1 | -1/+1 | |
| | | | | | | | | | | So, if there is redirect_to params[:q] i can send ?q=javascript:asdf()%0A/localpath Or something more nasty, so please use \A | |||||
* | | remove dead code | Aaron Patterson | 2013-01-30 | 1 | -4/+1 | |
| | | ||||||
* | | change parameter name for positional args | Aaron Patterson | 2013-01-30 | 1 | -2/+1 | |
| | | ||||||
* | | nodoc the helper classes, cache stuff for optimized helper | Aaron Patterson | 2013-01-30 | 1 | -13/+17 | |
| | | ||||||
* | | cache path parts in the instance | Aaron Patterson | 2013-01-30 | 1 | -2/+3 | |
| | | ||||||
* | | stop evaling a string every time | Aaron Patterson | 2013-01-30 | 1 | -4/+4 | |
| | | ||||||
* | | moving helper classes outside the private block | Aaron Patterson | 2013-01-30 | 1 | -90/+88 | |
| | | ||||||
* | | pushing specialization down to the optimized class | Aaron Patterson | 2013-01-30 | 1 | -23/+25 | |
| | | ||||||
* | | use polymorphism to remove conditional | Aaron Patterson | 2013-01-30 | 1 | -35/+27 | |
| | | ||||||
* | | move conditionals to instance | Aaron Patterson | 2013-01-30 | 1 | -6/+16 | |
| | | ||||||
* | | pull stuff out of the caller and hide in the instance | Aaron Patterson | 2013-01-30 | 1 | -4/+3 | |
| | | ||||||
* | | moving more stuff on to the instance | Aaron Patterson | 2013-01-30 | 1 | -18/+18 | |
| | | ||||||
* | | move optimize_helper? to the helper instance | Aaron Patterson | 2013-01-30 | 1 | -9/+12 | |
| | | ||||||
* | | moving more stuff to the instance | Aaron Patterson | 2013-01-30 | 1 | -6/+6 | |
| | | ||||||
* | | moving some stuff to the initializer | Aaron Patterson | 2013-01-30 | 1 | -14/+38 | |
| | | ||||||
* | | moved more evald code | Aaron Patterson | 2013-01-30 | 1 | -8/+7 | |
| | | ||||||
* | | factored out some of the dynamic code | Aaron Patterson | 2013-01-30 | 1 | -19/+31 | |
| | | ||||||
* | | Fix `content_tag_for` with array html option. | Semyon Perepelitsa | 2013-01-31 | 3 | -1/+25 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It would embed array as string instead of joining it like `content_tag` does: content_tag(:td, class: ["foo", "bar"]){} #=> '<td class="foo bar"></td>' Before: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item ["foo", "bar"]" id="item_1"></td>' After: content_tag_for(:td, item, class: ["foo", "bar"]){} #=> '<td class="item foo bar" id="item_1"></td>' | |||||
* | | Changelog about BestStandardsSupport removal | Guillermo Iguaran | 2013-01-29 | 1 | -5/+6 | |
| | | ||||||
* | | Add 'X-UA-Compatible' => 'chrome=1' to default headers | Guillermo Iguaran | 2013-01-29 | 2 | -2/+5 | |
| | | ||||||
* | | Remove BestStandardsSupport middleware | Guillermo Iguaran | 2013-01-29 | 4 | -67/+0 | |
| | | ||||||
* | | Merge pull request #9104 from bemurphy/remove_bad_idea_parser_test | Carlos Antonio da Silva | 2013-01-29 | 1 | -13/+0 | |
|\ \ | | | | | | | Remove yaml Proc param parser test | |||||
| * | | Remove yaml Proc param parser test | Brendon Murphy | 2013-01-28 | 1 | -13/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | I don't believe this test is exercising any explicit params_parser behavior that the other two Proc tests aren't already doing. Given that we now know it's a bad idea to load user input via YAML.load, somebody reading this test might get a dangerous idea about building out a YAML params parser. | |||||
* | | | s/ERb/ERB/ | Akira Matsuda | 2013-01-29 | 1 | -1/+1 | |
|/ / | ||||||
* | | Merge pull request #9096 from tricknotes/fix-code-comment | Rafael Mendonça França | 2013-01-28 | 1 | -4/+4 | |
|\ \ | | | | | | | Fix code comment | |||||
| * | | Fix JavaScript syntax in code comment [ci skip] | Ryunosuke SATO | 2013-01-29 | 1 | -4/+4 | |
| | | | ||||||
* | | | Move AS changelog entry to the top, improve AP changelog a bit | Carlos Antonio da Silva | 2013-01-28 | 1 | -4/+4 | |
| | | | | | | | | | | | | [ci skip] | |||||
* | | | Added a Changelog entry for fixing HEAD requests. | Michiel Sikkes | 2013-01-28 | 1 | -0/+5 | |
| | | | ||||||
* | | | Make current_url? work with a HEAD method | Michiel Sikkes | 2013-01-28 | 2 | -1/+7 | |
| | | | | | | | | | | | | | | | | | | ActionDispatch::Head was removed in favor of Rack::Head. But Rack::Head does not convert GET requests to HEAD requests so we need to do checking for HEAD requests ourselves. |