Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Use AS secure_compare for CSRF token comparison | Guillermo Iguaran | 2014-10-23 | 1 | -2/+2 |
| | |||||
* | fix small typo in routing test | Accessd | 2014-10-21 | 1 | -1/+1 |
| | |||||
* | Merge pull request #17313 from accessd/fix-url-generation-error-message | Rafael Mendonça França | 2014-10-21 | 2 | -1/+11 |
|\ | | | | | Fix url generation error message | ||||
| * | fix url generation error message | Accessd | 2014-10-21 | 2 | -1/+11 |
| | | |||||
* | | remove duplicate method (_status_code) in action_dispatch | Abdelkader Boudih | 2014-10-19 | 2 | -4/+1 |
| | | |||||
* | | Make _status_code methods nodoc | Prathamesh Sonpatki | 2014-10-19 | 2 | -4/+4 |
|/ | | | | | - Also one minor change for documenting url_for method in ActionController::Metal. [ci skip] | ||||
* | Replace (slower) block.call with (faster) yield | claudiob | 2014-10-17 | 1 | -2/+2 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Performance optimization: `yield` with an implicit `block` is faster than `block.call`. See http://youtu.be/fGFM_UrSp70?t=10m35s and the following benchmark: ```ruby require 'benchmark/ips' def fast yield end def slow(&block) block.call end Benchmark.ips do |x| x.report('fast') { fast{} } x.report('slow') { slow{} } end # => fast 154095 i/100ms # => slow 71454 i/100ms # => # => fast 7511067.8 (±5.0%) i/s - 37445085 in 4.999660s # => slow 1227576.9 (±6.8%) i/s - 6145044 in 5.028356s ``` | ||||
* | Use released rails-dom-testing | Rafael Mendonça França | 2014-10-16 | 1 | -1/+1 |
| | |||||
* | some changelog formatting. [ci skip] | Yves Senn | 2014-10-16 | 1 | -2/+2 |
| | |||||
* | Fix typo in actionpack/lib/action_dispatch/routing/mapper.rb | Yuutetu | 2014-10-16 | 1 | -1/+1 |
| | |||||
* | Merge pull request #17255 from printercu/cors_exception_wrapper | Rafael Mendonça França | 2014-10-15 | 1 | -10/+11 |
|\ | | | | | ActionController::InvalidCrossOriginRequest fails with 422 instead of 500 | ||||
| * | ActionController::InvalidCrossOriginRequest fails with 422 instead of 500 | Max Melentiev | 2014-10-14 | 1 | -10/+11 |
| | | | | | | | | Fixes #15967 | ||||
* | | Use `#tr` instead of `#gsub` | Nicolas Cavigneaux | 2014-10-14 | 1 | -1/+1 |
| | | | | | | | | | | `#tr` is more efficient than `#gsub` and can be used as a drop in replacement in this context. | ||||
* | | Improve Journey compliance to RFC 3986 | Nicolas Cavigneaux | 2014-10-14 | 3 | -11/+34 |
|/ | | | | | | | | | | The scanner in Journey fails to recognize routes that use literals from the sub-delims section of RFC 3986. This commit enhance the compatibility of Journey with the RFC by adding support of authorized delimiters to the scanner. Fix #17212 | ||||
* | Merge pull request #17234 from arthurnn/add_regression_for_path_and_cascade | Rafael Mendonça França | 2014-10-13 | 1 | -0/+8 |
|\ | | | | | Add regression test for router was overwriting PATH_INFO | ||||
| * | Add regression test for router was overwriting PATH_INFO | Arthur Neves | 2014-10-10 | 1 | -0/+8 |
| | | | | | | | | [related #17233] | ||||
* | | Replace Array#shuffle.first with Array#sample | Erik Michaels-Ober | 2014-10-13 | 1 | -2/+2 |
|/ | |||||
* | Request#check_method no longer breaks when :en is not available locale | Stefan Henzen | 2014-10-09 | 2 | -1/+17 |
| | | | | | | | | Request#check_method would use to_sentence(locale: :en), which breaks when I18n.available_locales does not include :en and I18n.enforce_available_locales is true (default). Inlined to_sentence functionality to solve this. | ||||
* | Rephrasing sentences | Neeraj Singh | 2014-10-07 | 1 | -2/+2 |
| | |||||
* | Merge pull request #17088 from robin850/jruby-dev | Rafael Mendonça França | 2014-10-01 | 1 | -0/+1 |
|\ | | | | | Follow up to #16613 | ||||
| * | Follow up to #16613 | Robin Dupret | 2014-09-28 | 1 | -0/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | Since we want this flag to be enabled anytime we are running the tests under JRuby, let's enable this at the Rakefile level so people get the performance boost on their local checkout. Moreover, we avoid having to update this particular line anytime the option changes on the JRuby side. The only drawback is that we have to define it in every Rakefile but there's no big deal, this is already the case for other options. | ||||
* | | Remove RUNNING UNIT TESTS from ActionPack | claudiob | 2014-09-30 | 1 | -17/+0 |
| | | | | | | | | | | | | | | | | [ci skip] Following discussion with @senny https://github.com/rails/rails/pull/17100#issuecomment-57285273 it only makes sense to keep this file form projects that require extra instructions. | ||||
* | | Responder was removed at ee77770d57de9da87b05a2fe84b9d46ec6852c62 | Akira Matsuda | 2014-09-30 | 1 | -1/+0 |
| | | |||||
* | | Parse HTML as document fragment. | Kasper Timm Hansen | 2014-09-29 | 4 | -6/+6 |
| | | | | | | | | This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20. | ||||
* | | Use Hash#each_key instead of Hash#keys.each | Erik Michaels-Ober | 2014-09-29 | 4 | -9/+9 |
| | | | | | | | | | | | | Hash#keys.each allocates an array of keys; Hash#each_key iterates through the keys without allocating a new array. This is the reason why Hash#each_key exists. | ||||
* | | Merge branch 'master' of github.com:rails/docrails | Vijay Dev | 2014-09-28 | 1 | -6/+6 |
|\ \ | |/ |/| | |||||
| * | Consistently markup etag options. | Steven Harman | 2014-09-16 | 1 | -3/+3 |
| | | |||||
| * | Consistently capitalize ETag. | Steven Harman | 2014-09-16 | 1 | -3/+3 |
| | | |||||
* | | Preparing for 4.2.0.beta2 release | Rafael Mendonça França | 2014-09-26 | 1 | -1/+1 |
| | | |||||
* | | Revert "Merge pull request #16966 from why-el/symbolize-path-params" | Rafael Mendonça França | 2014-09-25 | 2 | -9/+0 |
| | | | | | | | | | | | | | | | | This reverts commit 9d05d6de52871e57bfbf54a60de005e8a5f5b0e4, reversing changes made to 0863c9248fd47a15e88e05ce4fcd80966684c0e3. The change in the behaviour reported at #16958 doesn't exist since 4.0 and 4.1 works in the same way | ||||
* | | Ensure named path params are symbols (Fixes #16958) | Mohamed Wael Khobalatte | 2014-09-25 | 2 | -0/+9 |
| | | |||||
* | | No need CHANGLOG entry for a bug in a non released version | Rafael Mendonça França | 2014-09-25 | 1 | -7/+0 |
| | | | | | | | | [ci skip] | ||||
* | | Keep the original implementation to not having to allocate new objects | Rafael Mendonça França | 2014-09-25 | 1 | -2/+15 |
| | | |||||
* | | Merge pull request #17058 from eval/issue-17057 | Rafael Mendonça França | 2014-09-25 | 2 | -18/+10 |
|\ \ | | | | | | | | | | Remove internal options from query string of paths | ||||
| * | | Remove internal options from query string of paths | Gert Goet | 2014-09-25 | 2 | -18/+10 |
| | | | | | | | | | | | | Fixes #17057 | ||||
* | | | Fix actionpack test cases broken by #16888 | Godfrey Chan | 2014-09-26 | 2 | -29/+9 |
| | | | |||||
* | | | Use released rails-html-sanitizer and rails-deprecated_sanitizer | Godfrey Chan | 2014-09-26 | 1 | -1/+1 |
| | | | |||||
* | | | Use released rails-dom-testing | Rafael Mendonça França | 2014-09-25 | 1 | -1/+1 |
|/ / | |||||
* | | Rescue Rack::Utils::ParameterTypeError instead of TypeError | Yuki Nishijima | 2014-09-13 | 2 | -5/+5 |
| | | | | | | | | | | | | | | | | As of rack/rack@167b6480235ff00ed5f355698bf00ec2f250f72e, Rack raises Rack::Utils::ParameterTypeError which inherits TypeError. In terms of the behavior, Rescuing TypeError still works but this method shouldn't rescue if TypeError is raised for other reasons. | ||||
* | | Merge pull request #16839 from chancancode/default_test_order | Rafael Mendonça França | 2014-09-10 | 1 | -1/+1 |
|\ \ | | | | | | | | | | Default to sorting user's test cases for now | ||||
| * | | Default to sorting user's test cases for now | Godfrey Chan | 2014-09-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Goals: 1. Default to :random for newly generated applications 2. Default to :sorted for existing applications with a warning 3. Only show the warning once 4. Only show the warning if the app actually uses AS::TestCase Fixes #16769 | ||||
* | | | [ci skip]Correct variables in the sample code | suginoy | 2014-09-10 | 1 | -2/+2 |
| | | | |||||
* | | | Remove extra 'has been' from deprecation warning about asserting selectors | Prathamesh Sonpatki | 2014-09-09 | 1 | -1/+1 |
| | | | | | | | | | | | | [ci skip] | ||||
* | | | Remove extra 'has been' from the deprecation message | Prathamesh Sonpatki | 2014-09-09 | 1 | -1/+1 |
|/ / | | | | | | | - [ci skip] | ||||
* | | Removing unused fake models | Thiago Pradi | 2014-09-07 | 1 | -45/+0 |
| | | |||||
* | | Add support for Rack::ContentLength middelware | Javan Makhmali | 2014-09-06 | 2 | -0/+18 |
| | | |||||
* | | Deprecate implicit AD::Response splatting and Array conversion | Jeremy Kemper | 2014-09-06 | 3 | -5/+43 |
| | | |||||
* | | :scissors: | Rafael Mendonça França | 2014-09-05 | 1 | -1/+1 |
| | | |||||
* | | Add test to assert_recognizes with custom message | Rafael Mendonça França | 2014-09-05 | 1 | -1/+9 |
| | | |||||
* | | Message doesn't need to be optional | Rafael Mendonça França | 2014-09-05 | 1 | -2/+2 |
| | |