Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Make @controller an internal ivar in the view | Joshua Peek | 2010-01-22 | 1 | -4/+4 |
| | |||||
* | Start adding configuration to ActionView instead of using constants. | Yehuda Katz | 2009-10-14 | 1 | -12/+16 |
| | | | | | | | By using config rather than hardcoded constants, we can evolve the configuration system over time (we'd just need to update the config method with more robust capabilities and all consumers would get the capabilities with no code changes) | ||||
* | Switch to on-by-default XSS escaping for rails. | Michael Koziarski | 2009-10-08 | 1 | -3/+3 |
| | | | | | | | | | | | | This consists of: * String#html_safe! a method to mark a string as 'safe' * ActionView::SafeBuffer a string subclass which escapes anything unsafe which is concatenated to it * Calls to String#html_safe! throughout the rails helpers * a 'raw' helper which lets you concatenate trusted HTML from non-safety-aware sources (e.g. presantized strings in the DB) * New ERB implementation based on erubis which uses a SafeBuffer instead of a String Hat tip to Django for the inspiration. | ||||
* | Don't force test suite to use bundler | Joshua Peek | 2009-09-13 | 1 | -0/+1 |
| | |||||
* | Don't raise exceptions for missing javascript_include_tag or ↵ | Sam Pohlenz | 2009-09-03 | 1 | -2/+6 |
| | | | | | | stylesheet_link_tag sources unless the :cache or :concat options are given. [#2738 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Make sure javascript_include_tag/stylesheet_link_tag does not append ".js" ↵ | Matthew Rudy Jacobs | 2009-08-05 | 1 | -10/+14 |
| | | | | | | or ".css" onto external urls [#1664 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fix tag helpers so that all HTML element boolean attributes render according ↵ | Marc Love | 2009-07-30 | 1 | -1/+1 |
| | | | | | | to the specs. Added all boolean attributes listed in the XHTML 1.0 specs (http://www.w3.org/TR/xhtml1/guidelines.html) and HTML 5 specs (http://www.whatwg.org/specs/web-apps/current-work). HTML 5 boolean attribute rendering was broken in commit 1e2d7229602f467cfdc0ef606b5ef8a5566a1501 / [#2864 state:resolved]. Signed-off-by: Yehuda Katz <wycats@gmail.com> | ||||
* | Adds a audio_tag helper for the HTML5 audio tag. Fixed video_path docs. HTML ↵ | Emilio Tagua | 2009-07-07 | 1 | -3/+35 |
| | | | | | | attributes values should be true or false not attribute's name. [#2864 state:resolved] Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local> | ||||
* | Removed unnecessary calls to image_path and hash lookups [#2827 state:resolved] | Yehuda Katz + Carl Lerche | 2009-07-02 | 1 | -3/+3 |
| | |||||
* | Adds a video_tag helper for the HTML5 video tag (similar to how the ↵ | Tieg Zaharia | 2009-07-02 | 1 | -0/+67 |
| | | | | | | image_tag works) (tests included); removes a duplicate test line for image_tag; adds boolean attributes for video tag to tag()'s boolean attributes Signed-off-by: Yehuda Katz + Carl Lerche <ykatz+clerche@engineyard.com> | ||||
* | Handle missing javascript/stylesheets assets by raising an exception | Christos Zisopoulos | 2009-06-26 | 1 | -4/+28 |
| | | | | | | | | | | | | An exception will be raised if a local javascript/stylesheet file included by the stylesheet_link_tag or javascript_include_tag can not be found. When caching is enabled, we use atomic_write to ensure that the cache file is not created with zero length. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#2738 state:committed] | ||||
* | Add :concat option to asset tag helpers to force concatenation. | Joshua Peek | 2009-06-15 | 1 | -6/+18 |
| | | | | | This is useful for working around IE's stylesheet limit. stylesheet_link_tag :all, :concat => true | ||||
* | allow absolute paths for the asset caches | Andrew Kaspick | 2009-06-11 | 1 | -3/+3 |
| | | | | Signed-off-by: Michael Koziarski <michael@koziarski.com> | ||||
* | Eliminate unnecessary File.exist? when correct file extension given [#1879 ↵ | Andrew White | 2009-02-05 | 1 | -1/+2 |
| | | | | | | state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Merge docrails | Pratik Naik | 2009-01-18 | 1 | -50/+74 |
| | |||||
* | Cache AssetTag timestamps | Joshua Peek | 2009-01-04 | 1 | -5/+31 |
| | |||||
* | Revert to the good old days when AssetTag didn't cause anyone problems | Joshua Peek | 2009-01-02 | 1 | -325/+131 |
| | |||||
* | Fixed the AssetTagHelper cache to use the computed asset host as part of the ↵ | David Heinemeier Hansson | 2009-01-01 | 1 | -5/+5 |
| | | | | cache key instead of just assuming the its a string [#1299 state:committed] | ||||
* | Ensure ActionMailer doesn't blow up when a two argument proc is set for the ↵ | Tekin Suleyman | 2008-12-01 | 1 | -1/+1 |
| | | | | | | | asset host Signed-off-by: Michael Koziarski <michael@koziarski.com> [#1394 state:committed] | ||||
* | Make sure #compute_public_path caching allows to return different results ↵ | Sven Fuchs | 2008-11-29 | 1 | -1/+1 |
| | | | | | | for different given sources [#1471 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Added the option to declare an asset_host as an object that responds to call ↵ | David Heinemeier Hansson | 2008-11-27 | 1 | -3/+11 |
| | | | | (see http://github.com/dhh/asset-hosting-with-minimum-ssl for an example) [DHH] | ||||
* | need to make sure the asset type is cached with it in Cache.. name is ↵ | Aaron Batalion | 2008-11-19 | 1 | -2/+2 |
| | | | | | | sufficient, not self Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fixed asset host to not cache objects [#1419 state:resolved] | Aaron Batalion | 2008-11-19 | 1 | -29/+35 |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Fixed bug with asset timestamping when using relative_url_root (Joe ↵ | David Heinemeier Hansson | 2008-10-26 | 1 | -1/+1 |
| | | | | Goldwasser) [#1265 status:committed] | ||||
* | Fix image_tag behavior on windows. [#1085 state:resolved] | madlep | 2008-10-06 | 1 | -1/+1 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Fixed AssetTag cache with with relative_url_root [#1022 state:resolved] | Martin Rehfeld | 2008-09-22 | 1 | -1/+1 |
| | | | | Signed-off-by: Joshua Peek <josh@joshpeek.com> | ||||
* | Refactor AssetTagHelper and fix remaining threadsafe issues. | Joshua Peek | 2008-09-22 | 1 | -148/+316 |
| | |||||
* | Switched computed public paths cache over to a simple hash w/ mutex | Joshua Peek | 2008-09-10 | 1 | -15/+17 |
| | |||||
* | Removed unnecessary Symbol#to_proc from Asset Tag Helper. | Clemens Kofler | 2008-09-03 | 1 | -1/+1 |
| | | | | Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> | ||||
* | Fix asset file paths with dangling queries in mtime check | Jeremy Kemper | 2008-08-14 | 1 | -2/+6 |
| | |||||
* | Set asset-cached file ctime and mtime to the max mtime of the combined ↵ | Jeremy Kemper | 2008-08-12 | 1 | -0/+5 |
| | | | | files. Allows for consistent ETag generation without having a shared filesystem. | ||||
* | MemoryStore is the only "unsafe" store. Make it threadsafe by default. | Joshua Peek | 2008-08-06 | 1 | -1/+1 |
| | |||||
* | AbstractRequest.relative_url_root is no longer automatically configured by a ↵ | Joshua Peek | 2008-07-24 | 1 | -3/+3 |
| | | | | HTTP header. It can now be set in your configuration environment with config.action_controller.relative_url_root | ||||
* | Wrap AssetTagHelper's computed public path cache in a threadsafe store | Joshua Peek | 2008-07-17 | 1 | -33/+25 |
| | |||||
* | Resolved conflict | David Heinemeier Hansson | 2008-07-16 | 1 | -18/+44 |
|\ | |||||
| * | Add :recursive option to javascript_include_tag and stylesheet_link_tag to ↵ | Damian Janowski | 2008-07-08 | 1 | -14/+42 |
| | | | | | | | | | | | | be used along with :all. [#480 state:resolved] Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
| * | Move the file exists checks outside write_asset_file_contents. | Michael Koziarski | 2008-07-03 | 1 | -6/+4 |
| | | | | | | | | This lets us avoid the relatively costly trip through compute_*_paths if the file already exists. | ||||
* | | Fixed that AssetTagHelper#compute_public_path shouldn't cache the asset_host ↵ | David Heinemeier Hansson | 2008-07-16 | 1 | -11/+14 |
|/ | | | | along with the source or per-request proc's won't run [DHH] | ||||
* | Merge docrails. | Pratik Naik | 2008-05-25 | 1 | -12/+12 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Improve documentation coverage and markup | Xavier Noria | 2008-05-02 | 1 | -2/+2 |
| | | | | Signed-off-by: Pratik Naik <pratiknaik@gmail.com> | ||||
* | Merge branch 'master' of git://github.com/stephencelis/rails | Joshua Peek | 2008-04-14 | 1 | -3/+3 |
|\ | |||||
| * | Scripts and styles with multiple dots in the filename should cache | Stephen Celis | 2008-04-12 | 1 | -3/+3 |
| | | |||||
* | | Added Rails.public_path to control where HTML and assets are expected to be ↵ | David Heinemeier Hansson | 2008-04-13 | 1 | -1/+1 |
|/ | | | | loaded from (defaults to Rails.root + "/public") #11581 [nicksieger] | ||||
* | Re-added ActionView::Helpers::register_javascript/stylesheet_expansion to ↵ | Jeremy Kemper | 2008-03-20 | 1 | -18/+55 |
| | | | | | | make it easier for plugin developers to inject multiple assets. Closes #10350. git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9065 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Revert [9106]. References #10350. | Jeremy Kemper | 2008-03-19 | 1 | -57/+21 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9063 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Docfix (closes #11281) [jlindley] | David Heinemeier Hansson | 2008-03-15 | 1 | -4/+4 |
| | | | | git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9029 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Added ActionView::Helpers::register_javascript/stylesheet_expansion to make ↵ | David Heinemeier Hansson | 2008-03-13 | 1 | -21/+57 |
| | | | | | | it easier for plugin developers to inject multiple assets (closes #10350) [lotswholetime] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@9016 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Check the host string contains %d before using String#%, this avoids ↵ | Michael Koziarski | 2008-02-18 | 1 | -1/+1 |
| | | | | | | warnings. Closes #10809 [chuyeow] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8893 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Don't repeatedly add relative_url_root to asset sources. Closes #10767 ↵ | Michael Koziarski | 2008-01-27 | 1 | -5/+11 |
| | | | | | | [tomtoday, Koz] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de | ||||
* | Handle corner case with image_tag when passed 'messed up' image names. ↵ | Michael Koziarski | 2008-01-25 | 1 | -1/+1 |
| | | | | | | Closes #9018 [duncanbeevers, mpalmer] git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@8717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de |