Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Avoid (@_var ||= nil) pattern by using initialize methods and ensuring ↵ | José Valim | 2010-09-29 | 1 | -0/+1 |
| | | | | everyone calls super as expected. | ||||
* | Remove more warnings on AP. | Emilio Tagua | 2010-09-28 | 1 | -1/+2 |
| | |||||
* | Avoid more uninitialized variable warnings. | Emilio Tagua | 2010-09-28 | 1 | -1/+2 |
| | |||||
* | @selected may not be defined here, avoid warning. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Initialize @app if it doesn't exists. | Emilio Tagua | 2010-09-28 | 1 | -1/+1 |
| | |||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -2/+2 |
| | | | | Signed-off-by: Santiago Pastorino <santiago@wyeworks.com> | ||||
* | _routes must be inside @controller conditional. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Refactor method to avoid warnings and not run unnecessary code. | Emilio Tagua | 2010-09-27 | 1 | -11/+11 |
| | |||||
* | Initialize @cookies. | Emilio Tagua | 2010-09-27 | 1 | -0/+1 |
| | |||||
* | Remove more warnings shadowing outer local variable. | Emilio Tagua | 2010-09-27 | 1 | -2/+2 |
| | |||||
* | Don't shadow outer local variables. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Avoid uninitialized variable warning, reuse @integration_session. | Emilio Tagua | 2010-09-27 | 1 | -8/+14 |
| | |||||
* | Ask is @controller is defined to avoid warning. | Emilio Tagua | 2010-09-27 | 1 | -1/+1 |
| | |||||
* | Fix the precedence issue here | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 |
| | |||||
* | Not need to do this double ternary | Santiago Pastorino | 2010-09-26 | 1 | -1/+1 |
| | |||||
* | port is appended twice to HTTP_HOST when host already has the port | Santiago Pastorino | 2010-09-26 | 1 | -3/+3 |
| | |||||
* | Remove deprecated stuff in ActionController | Carlos Antonio da Silva | 2010-09-26 | 1 | -2/+2 |
| | | | | | | This removes all deprecated classes in ActionController related to Routing, Abstract Request/Response and Integration/IntegrationTest. All tests and docs were changed to ActionDispatch instead of ActionController. | ||||
* | Don't duplicate Rack::Response functionality. [#5320 state:resolved] | John Firebaugh | 2010-09-25 | 1 | -18/+4 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | fixing bug with rails use of rack-test | Aaron Patterson | 2010-09-22 | 1 | -2/+4 |
| | |||||
* | Cleanup deprecations in Action Dispatch | Carlos Antonio da Silva | 2010-09-06 | 1 | -93/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Added ability to set asset_path for engines | Piotr Sarnacki | 2010-09-03 | 1 | -1/+1 |
| | |||||
* | Expanded routing documentation with current best practices | Joost Baaij | 2010-08-29 | 1 | -5/+5 |
| | |||||
* | The call-seq directive has no useful effect on our documentation and is not ↵ | Joost Baaij | 2010-08-28 | 1 | -19/+0 |
| | | | | | | | | | | | used anywhere else. Worse still, its use breaks some rdoc, replacing method names with a curly brace. Having just one call-seq directive doesn't add anything since this is covered by regular rdoc. Having multiple might make sense, but these are already documented with examples. This partly re-reverts 60de0e56b7f57f0052d7e4f43bd2ef9e363c6a1a but does not touch the vendorized code in html-scanner. | ||||
* | Revert "call-seq directive makes rdoc cry and replaces method names with a ↵ | Xavier Noria | 2010-08-27 | 1 | -9/+28 |
| | | | | | | | | curly brace; besides it doesn't add anything when you only list one call example since this is obviously documented already" Reason: Part of this commit touches vendorized stuff, the rest is fine, could you please repatch? This reverts commit 60de0e56b7f57f0052d7e4f43bd2ef9e363c6a1a. | ||||
* | escape constants that should not be linked to | Joost Baaij | 2010-08-27 | 3 | -8/+8 |
| | |||||
* | call-seq directive makes rdoc cry and replaces method names with a curly ↵ | Joost Baaij | 2010-08-27 | 1 | -28/+9 |
| | | | | brace; besides it doesn't add anything when you only list one call example since this is obviously documented already | ||||
* | Support routing constraints in functional tests | Andrew White | 2010-08-20 | 1 | -14/+37 |
| | | | | | | | | | | Extend assert_recognizes and assert_generates to support passing full urls as the path argument. This allows testing of routing constraints such as subdomain and host within functional tests. [#5005 state:resolved] Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | adds missing requires for Object#try | Xavier Noria | 2010-08-09 | 1 | -0/+1 |
| | |||||
* | Change returning with tap | Santiago Pastorino | 2010-07-25 | 1 | -2/+2 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Remove assert_valid. It was already deprecated on Rails 2.3. | José Valim | 2010-07-19 | 2 | -21/+0 |
| | |||||
* | Remove unused variable on assert_recognizes [#4912 state:resolved] | Paco Guzman | 2010-06-22 | 1 | -1/+0 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | removed 'unless const_defined?' code smell | Josh Kalderimis | 2010-06-21 | 1 | -23/+19 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Fix a bunch of minor spelling mistakes | Evgeniy Dolzhenko | 2010-06-11 | 2 | -3/+3 |
| | |||||
* | regular expressions are usually ASCII-encoded, so force_encoding the content ↵ | wycats | 2010-06-07 | 1 | -2/+0 |
| | | | | of a Node to the encoding of the regular expression is wrong. | ||||
* | fix assert_select messages to its declaration behaviour | Paco Guzman | 2010-05-15 | 1 | -5/+11 |
| | | | | Signed-off-by: José Valim <jose.valim@gmail.com> | ||||
* | Some require indifferent_access added | Santiago Pastorino | 2010-04-21 | 2 | -0/+2 |
| | | | | Signed-off-by: Xavier Noria <fxn@ubuntu.(none)> | ||||
* | access assigns as a method or hash, with strings or symbols [#4431 ↵ | David Chelimsky | 2010-04-17 | 1 | -2/+2 |
| | | | | state:resolved] | ||||
* | Fix cookie access in integration tests with other host names | Joshua Peek | 2010-04-05 | 1 | -7/+21 |
| | |||||
* | moves Object#singleton_class to Kernel#singleton_class to match Ruby also ↵ | Xavier Noria | 2010-04-05 | 1 | -1/+1 |
| | | | | there, same for #class_eval to simplify, and adds coverage for class_eval | ||||
* | Rename config.cookie_secret to config.secret_token and pass it as ↵ | José Valim | 2010-04-05 | 1 | -0/+2 |
| | | | | configuration in request.env. This is another step forward removing global configuration. | ||||
* | * Change the object used in routing constraints to be an instance of | wycats | 2010-04-03 | 1 | -1/+2 |
| | | | | | | | | | | | ActionDispatch::Request rather than Rack::Request. * Changed ActionDispatch::Request#method to return a String, to be compatible with the Rack::Request superclass. * Changed ActionDispatch::Request#method to return the original method in the case of methodoverride and #request_method not to, to be compatible with Rack::Request | ||||
* | Add a test which ensures action_dispatch.show_exceptions is properly disabled. | José Valim | 2010-04-02 | 1 | -3/+1 |
| | |||||
* | Consistent routing language | Joshua Peek | 2010-03-30 | 1 | -10/+10 |
| | |||||
* | Fix stack overflow bug in integration test router helpers | Joshua Peek | 2010-03-30 | 1 | -1/+1 |
| | |||||
* | Merge remote branch 'rizwan/restrict' | wycats | 2010-03-28 | 1 | -0/+2 |
|\ | |||||
| * | adds missing requires for Object#blank? and Object#present? | Xavier Noria | 2010-03-28 | 1 | -0/+2 |
| | | |||||
* | | Rails 3 application can run performance tests now. [#4171 state:resolved] | Rizwan Reza | 2010-03-28 | 1 | -1/+3 |
|/ | |||||
* | open_session can just return the a dup of the current context. | wycats | 2010-03-22 | 1 | -24/+3 |
| | | | | | At this point, its entire purpose in the open_session {} case was to delegate back to the IntegrationTest anyway. | ||||
* | Each controller class has it's own view context subclass. This removes the ↵ | Carlhuda | 2010-03-18 | 1 | -3/+4 |
| | | | | need for ActionView::Base.for_controller | ||||
* | All tests pass without memoizing view_context | Carlhuda | 2010-03-18 | 1 | -3/+2 |
| |