| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Partially revert https://github.com/rails/rails/commit/c31e638a37946a120f6dbf207127d36beea5ab85.
|
|\
| |
| | |
[ci skip] Remove deprecated testing tasks
|
|/
|
|
|
| |
This has changed recently and so rake test:all and rake
test:all:db are deprecated.
|
|
|
|
|
| |
also increase the version of pg required so that people will get the
GVL friendly version
|
|\
| |
| | |
[ci skip] Improve upon testing tasks guide
|
|/
|
|
| |
Add missing testing tasks and also improve upon tasks descriptions
|
|\
| |
| | |
[ci skip] Capybara added to other testing approaches
|
|/ |
|
|\ |
|
|/
|
|
| |
name keywords
|
|\
| |
| | |
Abstract encoding strategy for ActiveSupport::MessageVerifier
|
|/ |
|
| |
|
|\
| |
| | |
Fix Rails::Paths::Path.unshift interface
|
| | |
|
|\ \
| | |
| | | |
Follow the coding conventions
|
|/ / |
|
|\ \
| |/
|/| |
simplify rake test vs rake test:all
|
| |
| |
| |
| | |
Renames `rake test:all` to `rake test` by changing old `rake test:run` to previous version of `rake test:all`. Removes old definition of `rake test`. Also renames `rake test:all:db` to `rake test:db` and deprecates `rake test:all` & `rake test:all:db`
|
|\ \
| | |
| | | |
[ci skip] Use American English and replace "behaviour" with "behavior".
|
|/ /
| |
| | |
Update to consistently use American English [ci skip]
|
|\ \
| | |
| | | |
Time includes DateAndTime::Zones acts_like(:time)
|
| | | |
|
|\ \ \
| | | |
| | | |
| | | | |
add a Table#name accessor like TableDefinition#name
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
Closes #17586
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Replaces the following in two places:
```diff
-require ::File.expand_path('../config/environment', __FILE__)
+require ::File.expand_path('../config/environment', __FILE__)
```
|
|\ \ \ \ |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | | |
Just prefer secrets over config
|
| |\ \ \ \
| | |/ / /
| |/| | |
| | | | | |
Allow fallback to LegacyKeyGenerator when secret_key_base is not set but secrets.secret_token is
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
- `secrets.secret_token` is now used in all places `config.secret_token` was
- `secrets.secret_token`, when not present in `config/secrets.yml`,
now falls back to the value of `config.secret_token`
- when `secrets.secret_token` is set, it over-writes
`config.secret_token` so they are the same (for backwards-compatibility)
- Update docs to reference app.secrets in all places
- Remove references to `config.secret_token`, `config.secret_key_base`
- Warn that missing secret_key_base is deprecated
- Add tests for secret_token, key_generator, and message_verifier
- the legacy key generator is used with the message verifier when
secrets.secret_key_base is blank and secret_token is set
- app.key_generator raises when neither secrets.secret_key_base nor
secret_token are set
- app.env_config raises when neither secrets.secret_key_base nor
secret_token are set
- Add changelog
Run focused tests via
ruby -w -Itest test/application/configuration_test.rb -n '/secret_|key_/'
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
remove never called method `limited_update_conditions`
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Tiny improvement in sqlite3 adapter
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
- remove unused method `supports_add_column?`
- change additional restriction method to `valid_alter_table_type?`
- fix code style
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix bug found when running individual tests against #17217 after merging
|
| |/ / / / |
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Empact/association-bind-values-not-updated-on-save
Fix that a collection proxy could be cached before the save of the owner, resulting in an invalid proxy lacking the owner’s id
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
resulting in an invalid proxy lacking the owner’s id.
Absent this fix calls like: owner.association.update_all to behave unexpectedly because they try to act on association objects where
owner_id is null.
more evidence here: https://gist.github.com/Empact/5865555
```
Active Record 3.2.13
-- create_table(:firms, {:force=>true})
-> 0.1371s
-- create_table(:clients, {:force=>true})
-> 0.0005s
1 clients. 1 expected.
1 clients updated. 1 expected.
```
```
Active Record 4.0.0
-- create_table(:firms, {:force=>true})
-> 0.1606s
-- create_table(:clients, {:force=>true})
-> 0.0004s
1 clients. 1 expected.
0 clients updated. 1 expected.
```
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We added a deprecation warning for these cases in aa1fadd, so these are now
causing deprecation warnings in the test output. AFAICT, in these two cases, the
option is not integral to the purpose of the test, so they can be safely removed
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follow up to 212057b9. Since that commit, we need to pass the `route_name`
explicitly. This is one of the left-over cases that was not handled in that
commit, which was causing `use_route` to be ignored in functional tests.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Why are people assigning booleans to string columns? >_>
We unintentionally changed the behavior on Sqlite3 and PostgreSQL.
Boolean values should cast to the database's representation of true and
false. This is 't' and 'f' by default, and "1" and "0" on Mysql. The
implementation to make the connection adapter specific behavior is hacky
at best, and should be re-visted once we decide how we actually want to
separate the concerns related to things that should change based on the
database adapter.
That said, this isn't something I'd expect to change based on my
database adapter. We're storing a string, so the way the database
represents a boolean should be irrelevant. It also seems strange for us
to give booleans special behavior at all in string columns. Why is
`to_s` not sufficient? It's inconsistent and confusing. Perhaps we
should consider deprecating in the future.
Fixes #17571
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fixed grammar about AS::Notifications [ci skip]
|
|/ / / / /
| | | | |
| | | | |
| | | | | |
active_support/notifications [ci skip]
|
|\ \ \ \ \
| |_|_|/ /
|/| | | | |
Ensure HABTM relationships produce valid class names (Fixes #17119)
|
|/ / / / |
|
|\ \ \ \
| | | | |
| | | | | |
[ci skip] Fix typo in command_line.md
|