| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |\ \ \
| | | | |
| | | | | |
Add CHANGELOG for https://github.com/rails/rails/pull/23734 [ci skip]
|
| |/ / / |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
It is not a released feature so we don't need to add changelogs to
changes on it.
[ci skip]
|
| | | |
| | | |
| | | |
| | | | |
Also use the new hash syntax.
|
| |\ \ \
| | | | |
| | | | |
| | | | | |
Fix logger silencing for broadcasted loggers
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix #23609
Commit 629efb6 introduced thread safety to logger silencing but it
didn't take into account the fact that the logger can be extended with
broadcasting to other logger.
This commit introduces local_level to broadcasting Module which enables
broadcasted loggers to be properly silenced.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
coffee-rails is stable now so we don't need to point to the master
branch.
|
| |\ \ \ \
| | | | | |
| | | | | | |
Show permitted flag in the output of AC::Parameters#inspect
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Fixes #23822.
|
| | |_|_|/
| |/| | |
| | | | |
| | | | | |
Fixes #22982.
|
| |\ \ \ \
| | |/ / /
| |/| | | |
AppGenerator: Replace 'rake' with 'rails_command'
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Follows the convention from Rails 5 of invoking tasks on the command-line
with `rails …` rather than `rake …`.
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since Rails 5.0 is switching the Rails command line from 'rake …'
to 'rails …', it makes sense to also replace the `rake` method in
the Rails templates API.
Based on feedback from @matthewd and @kaspth, I chose to replace
`rake` with `rails_command`, which is less confusing than
the alternatives `rails` or `command` or `rails_run` and is not
Thor-reserved word like `task`.
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Give Sessions Indifferent Access
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This is a rebased version of #22825.
Closes #22825.
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Abstract Controller is the common component between Action Mailer and
Action Controller so if we need to share the caching component it need
to be there.
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
environment templates
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
including it
Remove useless helper in ActionDispatch::Caching and fix indentation
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
and ActionController to include it
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
action_dispatch/caching/fragments
|
| | | |_|_|/
| | |/| | | |
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
`drop_table :test_text_limits` as well
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Follow up to 3b01785.
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Turbolinks 5 compatibility changes
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | | | | | | |
|
| | | |/ / / /
| | |/| | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
kamipo/fix_assert_nothing_raised_deprecation_warning_format
Fix `assert_nothing_raised` deprecation warning format
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Before:
```
DEPRECATION WARNING: Passing arguments to assert_nothing_raised
is deprecated and will be removed in Rails 5.1.
```
After:
```
DEPRECATION WARNING: Passing arguments to assert_nothing_raised is deprecated and will be removed in Rails 5.1.
```
|
| |\ \ \ \ \ \
| | |_|/ / / /
| |/| | | | | |
[ci skip] Improve the readability of documents of nested_attributes
|
| | | | | | | |
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix typo in Form Helpers Guide
|
| | | | | | | | |
|
| | | |/ / / /
| | |/| | | | |
|
| |\ \ \ \ \ \
| | |/ / / / /
| |/| | | | | |
Fix `request.ssl?` bug with Action Cable
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This bug affects `wss://` requests when running Action Cable in-app.
Fixes #23620.
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
In order to fix issue #17621 we added a check to validations that
determined if a record should be validated. Based on the existing tests
and behavior we wanted we determined the best way to do that was by
checking if `!record.peristed? || record.changed? || record.marked_for_destruction?`
This change didn't make it into a release until now. When #23790 was
opened we realized that `valid?` and `invalid?` were broken and did not
work on persisted records because of the `!record.persisted?`.
While there is still a bug that #17621 brought up, this change was too
drastic and should not be a RC blocker. I will work on fixing this so
that we don't break `valid?` but also aren't validating parent records
through child records if that parent record is validate false. This
change removes the code changes to validate and the corresponding tests.
It adds tests for two of the bugs found since Rails 5 beta2 release.
Fixes #17621
|
| |\ \ \ \ \
| | | | | | |
| | | | | | | |
Alternative to #23638 log to STDOUT via env var
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
People who deploy to containers or other places where they might have some sort of a log wrapping service use stdout. With this change new rails apps can be configured to output to STDOUT via setting `RAILS_LOG_TO_STDOUT` to any value. This allows container images or services to set the value for all apps without having to modify configuration for each application. If an app wants to opt out, they can either delete from the env hash, or remove that configuration.
cc/ @rafaelfranca
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
otherwise we don't get the log messages we're looking for and the tests
fail intermittently.
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix issue #23625
|
| | |/ / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This resolves a bug where if the primary key used is not `id` (ex:
`uuid`), and has a `validates_uniqueness_of` in the model, a uniqueness error
would be raised. This is a partial revert of commit `119b9181ece399c67213543fb5227b82688b536f`, which introduced this behavior.
|