| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|\ \ \ \
| |/ / /
|/| | | |
remove extra `=` in form builder example [ci skip]
|
|/ / / |
|
|\ \ \
| |_|/
|/| | |
Fix typos and improve the documentation
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is a squash of the following commits, from first to last:
-
Fix minor, random things I’ve come across lately that individually
did not seem worth making a PR for, so I saved them for one commit.
One common error is using “it’s” (which is an abbreviation of “it is”)
when the possessive “its” should be used for indicating possession.
-
Changes include the name of a test, so remove the `[skip ci]` (thanks @senny).
-
Line wrap the changes at 80 chars and add one more doc fix.
-
Add a missing line wrap in the Contributing to Ruby on Rails Guide.
-
Line wrap the `TIP` section in the Contributing to Ruby on Rails Guide as well.
Rendering the guide locally with `bundle exec rake guides:generate` did
not show any change in on-screen formatting after adding the line wrap.
The HTML generated is (extra line added to illustrate where the line
wrap takes place):
<div class="info"><p>Please squash your commits into a single commit
when appropriate. This
simplifies future cherry picks and also keeps the git log
clean.</p></div>
-
Squash commits.
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 524d40591eaa2f4d007409bfad386f6b107492eb, reversing
changes made to 34d3a6095100245283861ef480a54d0643bbee4c.
Reasoning behind the revert are in the PR discussion:
https://github.com/rails/rails/pull/19755
- This means that types can no longer cast to/from `Set`, and reasonably
work with `where` (we already have this problem for `array`/`json`
types on pg)
- This adds precedent for every other `Enumerable`, and we can't target
`Enumerable` directly.
- Calling `to_a` on a `Set` is reasonable.
|
|\ \
| | |
| | |
| | |
| | | |
andersonDadario/fix_security_guide_captcha_03_21_2015
Fix security guide captcha 03 21 2015 [ci skip]
|
| | | |
|
|\ \ \
| | | |
| | | | |
Tiny optimization of http auth Realm unquoting
|
| | | | |
|
|\ \ \ \
| | | | |
| | | | | |
Use #prepend rather than using 2 aliases
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Sidekiq::CLI#boot_system require "#{dummy_app_path}/config/environment.rb".
But this file has already been required in'test/support/integration/helper.rb'.
This patch will change to use Sidekiq::Launcher directly.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Removing GZip section since Sprockets 3.0 no longer create .gz files
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | | |
- https://github.com/rails/sprockets/commit/14b3b2eddac4699c64c051888e3801732b9a4418
- https://github.com/rails/sprockets/issues/26
|
| | | | | |
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Set default form builder for a controller
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
When 7e504927 was merged setting `Encoding.default_internal` and
`Encoding.default_external` would throw a warning when the ActionPack
tests were run.
Example warning: `actionpack/test/dispatch/static_test.rb:12: warning:
setting Encoding.default_external`
This patch silences the warnings as other similar tests do for setting
default_internal and default_external.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
fix indent in routes when using namespaced controllers
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Before:
namespace :foo do
namespace :bar do
get 'baz/index'
end
end
After:
namespace :foo do
namespace :bar do
get 'baz/index'
end
end
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | |
| | | | | | |
Add support for Set to Relation#where
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Previously `#where` used to treat `Set`objects as nil, but now it treats
them as an array:
set = Set.new([1, 2])
Author.where(:id => set)
# => SELECT "authors".* FROM "authors" WHERE "authors"."id" IN (1, 2)
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Use Ruby 2.2.2 on travis
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | | |
This is required to run https://github.com/rails/rails/pull/19752 successfully.
|
|\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Upgrade to Ruby 2.2.2
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
and fix the grammar in the ruby_version_check.rb user message.
|
|\ \ \ \ \ \
| |_|/ / / /
|/| | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| | | | | | |
|
| |\ \ \ \ \ |
|
| | | | | | |
| | | | | | |
| | | | | | | |
rails/rails#18305
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Fix the wrong documentation about config.autoload_paths [ci skip]
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
config.autoload_paths is not changeable from environment specific configuration files.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Related to f1af967e0055a33c45071848a049ff342e9c291e. [ci skip]
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Document that partial indexes are only supported by Postgres and SQLite.
|
|/ / / / / / / /
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fixes #18106
|
|\ \ \ \ \ \ \ \ |
|
| | | | | | | | | |
|