Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | | | | | | Merge pull request #34876 from ↵ | George Claghorn | 2019-01-05 | 1 | -1/+0 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bogdanvlviv/remove-needless-comment-actiontext.gemspec Remove comment from `actiontext/actiontext.gemspec` | |||||
| * | | | | | | Remove comment from `actiontext/actiontext.gemspec` | bogdanvlviv | 2019-01-05 | 1 | -1/+0 | |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This comment was autogenerated, see `railties/lib/rails/generators/rails/plugin/templates/%name%.gemspec.tt` Since actiontext is well described in this file, I think we shouldn't keep this comment. Note that this commit is more like cosmetic change, so it is OK if we don't merge this. | |||||
* | | | | | | Merge pull request #34874 from bogdanvlviv/fix-RichText-api-docs | George Claghorn | 2019-01-05 | 1 | -4/+4 | |
|\ \ \ \ \ \ | | | | | | | | | | | | | | | Fix API docs of `ActionText::RichText` [ci skip] | |||||
| * | | | | | | Fix API docs of `ActionText::RichText` [ci skip] | bogdanvlviv | 2019-01-05 | 1 | -4/+4 | |
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This text should appear on the page https://api.rubyonrails.org/v6.0/classes/ActionText/RichText.html Related to 86517942e469193e8624d5078d718785552c1270 | |||||
* | | | | | | Merge pull request #34709 from gmcgibbon/action_cable_guides_es6 | Javan Makhmali | 2019-01-05 | 1 | -112/+160 | |
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | Use ES6 and Webpacker in ActionCable guide. | |||||
| * | | | | | Use ES6 and Webpacker in ActionCable guide. | Gannon McGibbon | 2019-01-04 | 1 | -112/+160 | |
| | |_|_|/ | |/| | | | | | | | | | | | | | [ci skip] | |||||
* | | | | | Generate Action Text's API docs | George Claghorn | 2019-01-04 | 2 | -13/+23 | |
| | | | | | ||||||
* | | | | | Label Action Text PRs [ci skip] | George Claghorn | 2019-01-04 | 1 | -0/+2 | |
| | | | | | ||||||
* | | | | | Merge pull request #34873 from georgeclaghorn/actiontext | George Claghorn | 2019-01-04 | 144 | -5/+9447 | |
|\ \ \ \ \ | | | | | | | | | | | | | Import Action Text | |||||
| * \ \ \ \ | Import Action Text | George Claghorn | 2019-01-04 | 144 | -5/+9447 | |
| |\ \ \ \ \ | | |/ / / / | |/| | | | | ||||||
| | * | | | | Update tag helper routes for use in engines (#49) | Rikki Pitt | 2019-01-04 | 1 | -2/+2 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using the `rich_text_area_tag` form helper from within a Rails engine, the direct_upload_url and blob_url_template options would default to non-existent routes. By prefixing these routes with `main_app` we ensure the application root is used rather than the engine. | |||||
| | * | | | | Fix adding a rich_text_area to a form with no model | George Claghorn | 2018-12-31 | 5 | -29/+55 | |
| | | | | | | ||||||
| | * | | | | Bump Nokogiri for Ruby 2.6 compatibility | George Claghorn | 2018-12-31 | 1 | -4/+4 | |
| | | | | | | ||||||
| | * | | | | Move method definition below callbacks | George Claghorn | 2018-12-21 | 1 | -5/+6 | |
| | | | | | | ||||||
| | * | | | | Merge pull request #48 from lsylvester/use-plain-text-for-presence | George Claghorn | 2018-12-20 | 2 | -2/+14 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | use plain test to determine present/blank/empty | |||||
| | | * | | | | use plain test to determine present/blank/empty as the html version will ↵ | Lachlan Sylvester | 2018-12-21 | 2 | -2/+14 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | always contain content | |||||
| | * | | | | | Fit Rails’ Ruby requirement in here. | Kasper Timm Hansen | 2018-12-21 | 1 | -1/+1 | |
| | | | | | | | ||||||
| | * | | | | | Merge pull request #46 from bogdanvlviv/remove-ruby-2_4-from-ci | Kasper Timm Hansen | 2018-12-21 | 1 | -1/+0 | |
| | |\ \ \ \ \ | | | | | | | | | | | | | | | | | Remove Ruby 2.4 from the CI matrix | |||||
| | | * | | | | | Remove Ruby 2.4 from the CI matrix | bogdanvlviv | 2018-12-21 | 1 | -1/+0 | |
| | |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rails 6 requires Ruby 2.5+ or newer. See https://github.com/rails/rails/pull/34754. | |||||
| | * / / / / | CI against Ruby 2.4.5 and 2.5.3 (#45) | Tatsuya Ikeda | 2018-12-12 | 1 | -2/+2 | |
| | |/ / / / | | | | | | | | | | | | | Bump CI to latest minor versions of Ruby 2.4 and 2.5 | |||||
| | * | | | | Merge pull request #31 from albertoalmagro/remove-variable-shadowing | George Claghorn | 2018-10-13 | 1 | -8/+8 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | Rename shadowed variable | |||||
| | | * | | | | Rename shadowed variable | Alberto Almagro | 2018-10-13 | 1 | -8/+8 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit renames shadowed variable `attributes`. | |||||
| | * | | | | | Merge pull request #30 from albertoalmagro/remove-unused-options | George Claghorn | 2018-10-13 | 1 | -3/+3 | |
| | |\ \ \ \ \ | | | |/ / / / | | |/| | | | | Remove unused **options | |||||
| | | * | | | | Remove unused **options | Alberto Almagro | 2018-10-13 | 1 | -3/+3 | |
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not sure if this is going to be used in the future or not, but for the time being we shouldn't maintain parameters that we aren't using. We can always add them later when needed. | |||||
| | * | | | | <active-text-attachment> -> <action-text-attachment> | George Claghorn | 2018-10-12 | 1 | -1/+1 | |
| | | | | | | ||||||
| | * | | | | APPLICATION_PATH_PATH -> APPLICATION_PACK_PATH | George Claghorn | 2018-10-12 | 1 | -3/+3 | |
| | | | | | | ||||||
| | * | | | | Merge pull request #29 from swamp09/fix_typo | Javan Makhmali | 2018-10-11 | 1 | -1/+1 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | Fix typo | |||||
| | | * | | | | Fix typo | swamp09 | 2018-10-12 | 1 | -1/+1 | |
| | |/ / / / | ||||||
| | * | | | | Merge pull request #23 from albertoalmagro/privatize-constants | Javan Makhmali | 2018-10-11 | 1 | -4/+5 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | Privatize constants | |||||
| | | * | | | | Privatize constants | Alberto Almagro | 2018-10-11 | 1 | -4/+5 | |
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | This constants meant to be private but `private_constant` was missing, this commit makes them fully private by adding `private_constant`. | |||||
| | * | | | | Merge pull request #27 from ↵ | Rafael França | 2018-10-10 | 1 | -0/+28 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | albertoalmagro/test-coverage-form-with-rich-text-area Add test coverage for form with rich_text_area | |||||
| | | * | | | | Add test coverage for form with rich-text-area | Alberto Almagro | 2018-10-10 | 1 | -0/+28 | |
| | |/ / / / | ||||||
| | * | | | | Remove set_action_text_renderer from dummy app (#26) | Liroy Leshed | 2018-10-10 | 1 | -6/+0 | |
| | | | | | | | | | | | | | | | | | | I don't think we need that since it's set automatically through ActionText::Engine. | |||||
| | * | | | | Prevent rich_text_area from raising when inexistent attribute is passed (#24) | Alberto Almagro Sotelo | 2018-10-09 | 2 | -1/+22 | |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When an inexistent attribute is passed as a parameter to currently existing Rails' Form Helpers they render an empty tag instead of raising an exception. This commit confers the same behavior to `rich_text_area`. Fixes #19 | |||||
| | * | | | | Merge pull request #22 from albertoalmagro/add-frozen-string-literal | Javan Makhmali | 2018-10-09 | 28 | -0/+55 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | Add frozen_string_literal: true | |||||
| | | * | | | | Add frozen_string_literal: true | Alberto Almagro | 2018-10-08 | 28 | -0/+55 | |
| | |/ / / / | | | | | | | | | | | | | | | | | | | Adds frozen_string_literal: true comment on top of all currently existing files | |||||
| | * | | | | Test against Rails master | Javan Makhmali | 2018-10-08 | 2 | -64/+70 | |
| | | | | | | ||||||
| | * | | | | Match Rails Ruby version requirements | Javan Makhmali | 2018-10-08 | 3 | -3/+9 | |
| | | | | | | ||||||
| | * | | | | travis.yml → .travis.yml | Javan Makhmali | 2018-10-08 | 1 | -0/+0 | |
| | | | | | | | | | | | | | | | | | | | | | | | | 🤦♂️ | |||||
| | * | | | | Upgrade Ruby version (#20) | Alberto Almagro Sotelo | 2018-10-08 | 1 | -1/+1 | |
| | | | | | | | | | | | | | | | | | | Upgrades .ruby-version to latest stable release | |||||
| | * | | | | Use the ASt representation API | George Claghorn | 2018-10-07 | 1 | -5/+2 | |
| | | | | | | ||||||
| | * | | | | Add travis.yml | Javan Makhmali | 2018-10-06 | 1 | -0/+11 | |
| | | | | | | ||||||
| | * | | | | Merge pull request #17 from huacnlee/fix/uninitialized-constant-on-rails-reload | Javan Makhmali | 2018-10-06 | 1 | -5/+5 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | Fix `uninitialized constant ActionText:: ALLOWED_TAGS` error on Rails reload | |||||
| | | * | | | | Fix `uninitialized constant ActionText:: ALLOWED_TAGS` error on Rails reloading | Jason Lee | 2018-10-06 | 1 | -5/+5 | |
| | | | | | | | ||||||
| | * | | | | | Merge pull request #18 from vendethiel/patch-1 | Javan Makhmali | 2018-10-06 | 1 | -1/+1 | |
| | |\ \ \ \ \ | | | | | | | | | | | | | | | | | Fix minor typo in code comment | |||||
| | | * | | | | | Fix minor typo in code comment | ven | 2018-10-06 | 1 | -1/+1 | |
| | | |/ / / / | ||||||
| | * / / / / | Add template for ActionText::Attachables::RemoteImage | Javan Makhmali | 2018-10-06 | 2 | -15/+30 | |
| | |/ / / / | | | | | | | | | | | | | | | | | | | Fixes #15 | |||||
| | * | | | | Fix has_rich_text with `:body` keywords error. (#16) | Jason Lee | 2018-10-05 | 3 | -1/+7 | |
| | | | | | | ||||||
| | * | | | | Merge pull request #14 from hakusaro/add-sanitized-word | David Heinemeier Hansson | 2018-10-04 | 1 | -1/+1 | |
| | |\ \ \ \ | | | | | | | | | | | | | | | Add "sanitized" to the readme | |||||
| | | * | | | | Add "sanitized" to the readme | Lucas Nicodemus | 2018-10-04 | 1 | -1/+1 | |
| | |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think a prime concern people have here is sanitization and security. Adding this word to the readme provides a little bit of clarity and reassurance that we aren't just rendering raw data trusted from the client. |