| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
After c2fe093, which was reverted yesterday, there will likely be
future PRs to address #17661.
The test `actionview/test/template/capture_helper_test.rb
#test_capture_returns_nil_if_the_returned_value_is_not_a_string` should
have errored with c2fe093, but it was rewritten in the PR to not raise.
My guess is that it may have seemed irrelevant to the content_tag tests
or already covered by them.
This test provides additional protection by being in the content_tag
test suite to explicitly raise a red flag in future cases. It foregoes
some redundancy for safety — at least until #17661 is closed.
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
Add test for `:skip_after_callbacks_if_terminated`
|
| |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
`define_callbacks` from `ActiveSupport::Callbacks` accepts the
`:skip_after_callbacks_if_terminated` option since #4866 but the option
is not tested anywhere.
This commit adds tests and fixes documentation for the option, making it clear
that halting a callback chain only stops following `before_` and `around_`
callbacks by default.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Improve section in constant autoload guide
|
| | |/ / / /
| |/| | | |
| | | | | | |
[skip ci]
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
claudiob/remove-redundant-tests-about-around-actions-returning-false
Remove misleading test: around_action return false
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
When an `around_action` does not `yield`, then the corresponding action is
*never* executed and the `after_` actions are *never* invoked.
The value returned by the `around_action` does not have any impact on this:
an `around_action` can "return" `true`, `false`, or `"pizza"`, but as long
as `yield` is not invoked, the corresponding action and after callbacks are
not executed.
The test suite for `ActionController::Callbacks` currently includes separate
tests to distinguish the cases in which a non-yielding `around_actions` returns
`true` or `false`.
In my opinion, having such tests is misleading, giving the impression that the
returned value might have some sort of impact, while it does not. At least
that's the impression I got when I read those tests.
For completeness, the tests were introduced 7 years ago by @NZKoz in e80fabb.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
English fix [ci skip]
|
|/ / / / / / / |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Improve grammar
|
|/ / / / / / /
| | | | | | |
| | | | | | | |
[skip ci]
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Constant autoload grammar fix
|
|/ / / / / /
| | | | | |
| | | | | | |
[skip ci]
|
| | | | | | |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
JuanitoFatas/patch/constant_autoloading_and_reloading-list-items
[ci skip] :scissors: blank lines between list items.
|
| | |_|/ / /
| |/| | | | |
|
|/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
[ci skip]
/cc @sgrif @zzak
Conflicts:
activerecord/CHANGELOG.md
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
I think "What" is was fine, "The purpose of" assumes the reader knows such thing exists.
"What is" is fine, and also matches the following "What is require_dependency".
|
| | | | | |
|
| | | | | |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
4.2.0", then they should have no problems hacking with Rails. [ci skip]
If they do, then its a bug and it should be reported.
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Improving tips about installation in the guides [ci skip]
|
| | | | | | |
|
|\ \ \ \ \ \ |
|
|/| | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
jonatack-patch-8
[ci skip]
Conflicts:
guides/source/constant_autoloading_and_reloading.md
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
[skip ci]
Follow-up to previous commit
[skip ci]
Fix previous merge
[skip ci]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Counter cache Rails guides fix
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | | |
association when using a custom counter cache column. This is documented on the has_many association here: http://apidock.com/rails/ActiveRecord/Associations/ClassMethods/has_many [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Adding method chaining section on ActiveRecord querying guide [ci skip]
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
[ci skip]
|
|\ \ \ \ \ \ \ \
| |_|_|_|/ / / /
|/| | | | | | | |
Improve autoload_paths section [ci skip]
|
| | |/ / / / /
| |/| | | | |
| | | | | | | |
[skip ci]
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Minor typos/fixes to autoloading guide
|
|/ / / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
@fxn Great job with the guide, I read it all! Yeah!
Some paragraphs might be restructured, but I'll leave that to you
since you are currently working on it. This commit only includes
some minor typos and commas that in my opinion clarify the reading.
[ci skip]
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
This reverts commit c2fe0938d7201d4ce0bb2f25e72bf5f70df128af.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | | |
Don't convert empty arrays to nils when deep munging params
|
| | |/ / / / /
| |/| | | | | |
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Dynamic finders already deprecated [ci skip]
|
| |/ / / / / |
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | | |
fix a typo [ci skip]
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| |/ / / / / /
|/| | | | | | |
|
| | | | | | | |
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Adds examples and keeps coherent with the documentation of the
similar method `seconds_until_end_of_day`. [ci skip]
|
| |\ \ \ \ \ \ |
|
| |/ / / / / /
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The example was taken from the commit message 676d6a6.
[ci skip]
|