diff options
author | Alexey Vakhov <vakhov@gmail.com> | 2012-05-25 17:46:53 +0400 |
---|---|---|
committer | Alexey Vakhov <vakhov@gmail.com> | 2012-05-25 17:46:53 +0400 |
commit | b4167d3f3e4d25be16e06e71afd1c64a47ca54d7 (patch) | |
tree | 64132cec56772e6d106426d4c0c4c5f377fbd2df /activesupport/test/core_ext/kernel_test.rb | |
parent | 56417b40921704a6139191f39b9a10f76e18d38e (diff) | |
download | rails-b4167d3f3e4d25be16e06e71afd1c64a47ca54d7.tar.gz rails-b4167d3f3e4d25be16e06e71afd1c64a47ca54d7.tar.bz2 rails-b4167d3f3e4d25be16e06e71afd1c64a47ca54d7.zip |
Fix Range#sum optimized version
At 1bd4d1c67459a91415ee73a8f55d2309c0d62a87 was added Range#sum
optimized version for arithmetic progressions. This improvment injected
a defect with not integer range boundaries. The defect was fixed by
e0adfa82c05f9c975005f102b4bcaebfcd17d241. The second commit really
disabled optimization at all because in Ruby integer-valued numbers are
instances of Fixnum and Bignum classes. We should #use is_a?
(#kind_of?) method instead #instance_of? to check if value is numerical:
1.class # => Fixnum
1.instance_of?(Integer) # => false
1.is_a?(Integer) # => true
-100_000_000_000.class # => Bignum
-100_000_000_000.instance_of?(Integer) # => false
-100_000_000_000.is_a?(Integer) # => true
Moreover original implementation of Range#sum has a defect with reverse
range boundaries. If the first boundary is less than the second range is
empty. Current commit fixes and tests this case too.
Diffstat (limited to 'activesupport/test/core_ext/kernel_test.rb')
0 files changed, 0 insertions, 0 deletions