From 89c1fc75407f27a31146554f92d98a90e43605d1 Mon Sep 17 00:00:00 2001
From: Thomas Willingham <founder@kakste.com>
Date: Thu, 3 Oct 2013 02:39:49 +0100
Subject: Fix a gotcha in theme defaults.

---
 view/theme/redbasic/php/style.php | 41 +++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 15 deletions(-)

(limited to 'view/theme/redbasic')

diff --git a/view/theme/redbasic/php/style.php b/view/theme/redbasic/php/style.php
index aff592a05..88bf2ceb0 100644
--- a/view/theme/redbasic/php/style.php
+++ b/view/theme/redbasic/php/style.php
@@ -1,20 +1,5 @@
 <?php
 
-//Set some defaults
-
-	$nav_colour = "red";
-		$nav_bg_1 = "#f88";
-		$nav_bg_2 = "#b00";
-		$nav_bg_3 = "#f00";
-		$nav_bg_4 = "#b00";
-	$background_colour = "fff";
-	$background_image ='';
-	$item_colour = "fff";
-	$item_opacity = "1";
-	$font_size = "12";
-	$font_colour = "000";
-	$radius = "5";
-
 // Get the UID of the channel owner
 	$uid = get_theme_uid();
 
@@ -49,6 +34,32 @@
 	    $font_colour = get_pconfig($uid, "redbasic", "font_colour");	
 	    $radius = get_pconfig($uid, "redbasic", "radius");	
 
+//Set some defaults - we have to do this after pulling owner settings, and we have to check for each setting
+//individually.  If we don't, we'll have problems if a user has set one, but not all options.
+
+	if (! $nav_colour) {
+		$nav_colour = "red";
+			$nav_bg_1 = "#f88";
+			$nav_bg_2 = "#b00";
+			$nav_bg_3 = "#f00";
+			$nav_bg_4 = "#b00";
+		}
+	if (! $background_colour)
+		$background_colour = "fff";
+	if (! $background_image)
+		$background_image ='';
+	if (! $item_colour)
+		$item_colour = "fff";
+	if (! $item_opacity)
+		$item_opacity = "1";
+	if (! $font_size)
+		$font_size = "12";
+	if (! $font_colour)
+		$font_colour = "000";
+	if (! $radius)
+		$radius = "5";
+
+
 
 // Apply the settings
 	if(file_exists('view/theme/' . current_theme() . '/css/style.css')) {
-- 
cgit v1.2.3