From 6bc5d6f17b9d86d909cf43cde0a399b17c46bbf5 Mon Sep 17 00:00:00 2001 From: Friendika Date: Thu, 24 Mar 2011 15:45:27 -0700 Subject: repair duplicate nickname accounts caused by race condition --- mod/register.php | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) (limited to 'mod/register.php') diff --git a/mod/register.php b/mod/register.php index 95e9d581f..06ed1e0f1 100644 --- a/mod/register.php +++ b/mod/register.php @@ -199,6 +199,24 @@ function register_post(&$a) { return; } + /** + * if somebody clicked submit twice very quickly, they could end up with two accounts + * due to race condition. Remove this one. + */ + + $r = q("SELECT `uid` FROM `user` + WHERE `nickname` = '%s' ", + dbesc($nickname) + ); + if((count($r) > 1) && $newuid) { + $err .= t('Nickname is already registered. Please choose another.') . EOL; + q("DELETE FROM `user` WHERE `uid` = %d LIMIT 1", + intval($newuid) + ); + notice ($err); + return; + } + if(x($newuid) !== false) { $r = q("INSERT INTO `profile` ( `uid`, `profile-name`, `is-default`, `name`, `photo`, `thumb`, `publish`, `net-publish` ) VALUES ( %d, '%s', %d, '%s', '%s', '%s', %d, %d ) ", -- cgit v1.2.3