From 198070700c3f087b97e431ea64ae6845db8f4062 Mon Sep 17 00:00:00 2001 From: "System user; apache" Date: Fri, 15 Sep 2023 15:28:13 +0200 Subject: only select the required fields to prevent memory exhaustion on big result sets (cherry picked from commit 3a01aa40d8f788c89f50f9893214f6591dac7bae) --- include/items.php | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'include') diff --git a/include/items.php b/include/items.php index d88a676a1..57e5dbb96 100644 --- a/include/items.php +++ b/include/items.php @@ -3920,16 +3920,19 @@ function drop_item($id,$interactive = true,$stage = DROPITEM_NORMAL) { $notify_id = intval($item['id']); - $items = q("select * from item where parent = %d and uid = %d", + $items = q("select id, resource_id, uid, resource_type, mid from item where parent = %d and uid = %d", intval($item['id']), intval($item['uid']) ); + if($items) { - foreach($items as $i) + foreach($items as $i) { delete_item_lowlevel($i, $stage); + } } - else + else { delete_item_lowlevel($item, $stage); + } if(! $interactive) return 1; -- cgit v1.2.3