From 59940e7f053a1bb3fd0588e25d34b5235133dd2b Mon Sep 17 00:00:00 2001
From: Mario <mario@mariovavti.com>
Date: Sat, 9 Oct 2021 19:46:27 +0000
Subject: make sure to not include removed channels in xrd or webfinger queries

---
 Zotlabs/Module/Wfinger.php | 52 +++++++++++++++++++++-------------------------
 1 file changed, 24 insertions(+), 28 deletions(-)

(limited to 'Zotlabs/Module/Wfinger.php')

diff --git a/Zotlabs/Module/Wfinger.php b/Zotlabs/Module/Wfinger.php
index 6dedc1ef1..43102f006 100644
--- a/Zotlabs/Module/Wfinger.php
+++ b/Zotlabs/Module/Wfinger.php
@@ -72,20 +72,16 @@ class Wfinger extends \Zotlabs\Web\Controller {
 					dbesc($channel)
 				);
 				if($r) {
-					$r[0] = pchan_to_chan($r[0]);
+					$r = pchan_to_chan($r[0]);
 				}
 			}
 			else {
-				$r = q("select * from channel left join xchan on channel_hash = xchan_hash
-					where channel_address = '%s' limit 1",
-					dbesc($channel)
-				);
+				$r = channelx_by_nick($channel);
 			}
 		}
 
 		header('Access-Control-Allow-Origin: *');
 
-
 		if($root_resource) {
 			$result['subject'] = $resource;
 			$result['properties'] = [
@@ -107,15 +103,15 @@ class Wfinger extends \Zotlabs\Web\Controller {
 		if($resource && $r) {
 
 			$h = q("select hubloc_addr from hubloc where hubloc_hash = '%s' and hubloc_deleted = 0",
-				dbesc($r[0]['channel_hash'])
+				dbesc($r['channel_hash'])
 			);
 
 			$result['subject'] = $resource;
 
 			$aliases = array(
-				z_root() . (($pchan) ? '/pchan/' : '/channel/') . $r[0]['channel_address'],
-				z_root() . '/~' . $r[0]['channel_address'],
-				z_root() . '/@' . $r[0]['channel_address']
+				z_root() . (($pchan) ? '/pchan/' : '/channel/') . $r['channel_address'],
+				z_root() . '/~' . $r['channel_address'],
+				z_root() . '/@' . $r['channel_address']
 			);
 
 			if($h) {
@@ -127,9 +123,9 @@ class Wfinger extends \Zotlabs\Web\Controller {
 			$result['aliases'] = [];
 
 			$result['properties'] = [
-					'http://webfinger.net/ns/name'   => $r[0]['channel_name'],
-					'http://xmlns.com/foaf/0.1/name' => $r[0]['channel_name'],
-					'https://w3id.org/security/v1#publicKeyPem' => $r[0]['xchan_pubkey'],
+					'http://webfinger.net/ns/name'   => $r['channel_name'],
+					'http://xmlns.com/foaf/0.1/name' => $r['channel_name'],
+					'https://w3id.org/security/v1#publicKeyPem' => $r['xchan_pubkey'],
 					'http://purl.org/zot/federation' => 'zot6,zot'
 			];
 
@@ -143,18 +139,18 @@ class Wfinger extends \Zotlabs\Web\Controller {
 
 					[
 						'rel'  => 'http://webfinger.net/rel/avatar',
-						'type' => $r[0]['xchan_photo_mimetype'],
-						'href' => $r[0]['xchan_photo_l']
+						'type' => $r['xchan_photo_mimetype'],
+						'href' => $r['xchan_photo_l']
 					],
 
 					[
 						'rel'  => 'http://webfinger.net/rel/profile-page',
-						'href' => $r[0]['xchan_url'],
+						'href' => $r['xchan_url'],
 					],
 
 					[
 						'rel'  => 'magic-public-key',
-						'href' => 'data:application/magic-public-key,' . Keyutils::salmonKey($r[0]['channel_pubkey']),
+						'href' => 'data:application/magic-public-key,' . Keyutils::salmonKey($r['channel_pubkey']),
 					]
 
 				];
@@ -167,14 +163,14 @@ class Wfinger extends \Zotlabs\Web\Controller {
 
 					[
 						'rel'  => 'http://webfinger.net/rel/avatar',
-						'type' => $r[0]['xchan_photo_mimetype'],
-						'href' => $r[0]['xchan_photo_l']
+						'type' => $r['xchan_photo_mimetype'],
+						'href' => $r['xchan_photo_l']
 					],
 
 					[
 						'rel'  => 'http://microformats.org/profile/hcard',
 						'type' => 'text/html',
-						'href' => z_root() . '/hcard/' . $r[0]['channel_address']
+						'href' => z_root() . '/hcard/' . $r['channel_address']
 					],
 
 					[
@@ -184,18 +180,18 @@ class Wfinger extends \Zotlabs\Web\Controller {
 
 					[
 						'rel'  => 'http://webfinger.net/rel/profile-page',
-						'href' => z_root() . '/profile/' . $r[0]['channel_address'],
+						'href' => z_root() . '/profile/' . $r['channel_address'],
 					],
 
 					[
 						'rel'  => 'http://schemas.google.com/g/2010#updates-from',
 						'type' => 'application/atom+xml',
-						'href' => z_root() . '/ofeed/'  . $r[0]['channel_address']
+						'href' => z_root() . '/ofeed/'  . $r['channel_address']
 					],
 
 					[
 						'rel'  => 'http://webfinger.net/rel/blog',
-						'href' => z_root() . '/channel/' . $r[0]['channel_address'],
+						'href' => z_root() . '/channel/' . $r['channel_address'],
 					],
 
 					[
@@ -206,12 +202,12 @@ class Wfinger extends \Zotlabs\Web\Controller {
 					[
 						'rel'  => 'http://purl.org/zot/protocol/6.0',
 						'type' => 'application/x-zot+json',
-						'href' => channel_url($r[0])
+						'href' => channel_url($r)
 					],
 
 					[
 						'rel'  => 'http://purl.org/zot/protocol',
-						'href' => z_root() . '/.well-known/zot-info' . '?address=' . $r[0]['xchan_addr'],
+						'href' => z_root() . '/.well-known/zot-info' . '?address=' . $r['xchan_addr'],
 					],
 
 					[
@@ -222,14 +218,14 @@ class Wfinger extends \Zotlabs\Web\Controller {
 
 					[
 						'rel'  => 'magic-public-key',
-						'href' => 'data:application/magic-public-key,' . Keyutils::salmonKey($r[0]['channel_pubkey']),
+						'href' => 'data:application/magic-public-key,' . Keyutils::salmonKey($r['channel_pubkey']),
 					]
 				];
 			}
 
 			if($zot) {
 				// get a zotinfo packet and return it with webfinger
-				$result['zot'] = Libzot::zotinfo( [ 'address' => $r[0]['xchan_addr'] ]);
+				$result['zot'] = Libzot::zotinfo( [ 'address' => $r['xchan_addr'] ]);
 			}
 		}
 
@@ -238,7 +234,7 @@ class Wfinger extends \Zotlabs\Web\Controller {
 			killme();
 		}
 
-		$arr = [ 'channel' => $r[0], 'pchan' => $pchan, 'request' => $_REQUEST, 'result' => $result ];
+		$arr = [ 'channel' => $r, 'pchan' => $pchan, 'request' => $_REQUEST, 'result' => $result ];
 		call_hooks('webfinger',$arr);
 
 		json_return_and_die($arr['result'],'application/jrd+json');
-- 
cgit v1.2.3