From 1c2d956d7f447a8df335bf9ff63b0839a1f9c8bc Mon Sep 17 00:00:00 2001 From: marijus Date: Sun, 18 Jan 2015 14:44:58 +0100 Subject: basic proof of concept file activity support - will send activity via the filestorage module and via attach_delete() --- include/RedDAV/RedBrowser.php | 5 +- include/RedDAV/RedFile.php | 2 +- include/attach.php | 109 +++++++++++++++++++++++++++++++++++++++- include/conversation.php | 2 +- mod/filestorage.php | 9 ++++ mod/sharedwithme.php | 114 ++++++++++++++++++++++++++++++++++++++++++ view/tpl/attach_edit.tpl | 7 ++- view/tpl/cloud_header.tpl | 5 +- 8 files changed, 246 insertions(+), 7 deletions(-) create mode 100644 mod/sharedwithme.php diff --git a/include/RedDAV/RedBrowser.php b/include/RedDAV/RedBrowser.php index 9ea2b9808..93a546086 100644 --- a/include/RedDAV/RedBrowser.php +++ b/include/RedDAV/RedBrowser.php @@ -249,7 +249,10 @@ class RedBrowser extends DAV\Browser\Plugin { '$header' => t('Files') . ": " . $this->escapeHTML($path) . "/", '$quota' => $quota, '$total' => t('Total'), - '$actionspanel' => $output + '$actionspanel' => $output, + '$shared' => t('Shared'), + '$create' => t('Create'), + 'upload' => t('Upload') )); $html .= replace_macros(get_markup_template('cloud_directory.tpl'), array( diff --git a/include/RedDAV/RedFile.php b/include/RedDAV/RedFile.php index 3a5230dc1..f2ee071b8 100644 --- a/include/RedDAV/RedFile.php +++ b/include/RedDAV/RedFile.php @@ -276,4 +276,4 @@ class RedFile extends DAV\Node implements DAV\IFile { attach_delete($this->auth->owner_id, $this->data['hash']); } -} \ No newline at end of file +} diff --git a/include/attach.php b/include/attach.php index a76dd4b28..ec175fcb3 100644 --- a/include/attach.php +++ b/include/attach.php @@ -753,14 +753,17 @@ function attach_delete($channel_id, $resource) { $channel_address = (($c) ? $c[0]['channel_address'] : 'notfound'); - $r = q("SELECT hash, flags, folder FROM attach WHERE hash = '%s' AND uid = %d limit 1", + $r = q("SELECT hash, filename, flags, folder FROM attach WHERE hash = '%s' AND uid = %d limit 1", dbesc($resource), intval($channel_id) ); + if(! $r) return; + $url = get_parent_cloudpath($channel_id, $channel_address, $resource) . $r[0]['filename']; + // If resource is a directory delete everything in the directory recursive if($r[0]['flags'] & ATTACH_FLAG_DIR) { $x = q("SELECT hash, flags FROM attach WHERE folder = '%s' AND uid = %d", @@ -802,6 +805,8 @@ function attach_delete($channel_id, $resource) { dbesc($r[0]['folder']), intval($channel_id) ); + + file_activity($channel_id, $resource, $allow_cid='', $allow_gid='', $deny_cid='', $deny_gid='', $url, 'drop', $no_activity=false); } /** @@ -934,3 +939,105 @@ function pipe_streams($in, $out) { $size += fwrite($out, fread($in, 8192)); return $size; } + +function file_activity($channel_id, $hash, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $url, $action, $no_activity) { + + require_once('include/items.php'); + + $url = rawurlencode($url); + + $poster = get_app()->get_observer(); + + $verb = ACTIVITY_FILE . '/' . $action . '/' . $hash; + + $mid = item_message_id(); + + $item_flags = ITEM_WALL|ITEM_ORIGIN|ITEM_UNSEEN; + + if($action == 'post') { + //check if activity item exists + //if yes send drop activity and create a new one + + $r = q("SELECT * FROM item WHERE verb = '%s'", + dbesc($verb) + ); + + if($r) { + + $dmid = item_message_id(); + $updateverb = ACTIVITY_FILE . '/drop/' . $hash . '#' . $mid; + + $arr = array(); + + $arr['aid'] = get_account_id(); + $arr['uid'] = $channel_id; + $arr['mid'] = $dmid; + $arr['parent_mid'] = $dmid; + $arr['item_flags'] = $item_flags; + $arr['author_xchan'] = $poster['xchan_hash']; + $arr['owner_xchan'] = $poster['xchan_hash']; + $arr['title'] = ''; + $arr['allow_cid'] = $allow_cid; + $arr['allow_gid'] = $allow_gid; + $arr['deny_cid'] = $deny_cid; + $arr['deny_gid'] = $deny_gid; + $arr['item_restrict'] = ITEM_HIDDEN; + $arr['item_private'] = 0; + $arr['verb'] = $updateverb; + $arr['body'] = $url; + + $post = item_store($arr); + $item_id = $post['item_id']; + + if($item_id) { + proc_run('php',"include/notifier.php","activity",$item_id); + } + + //call_hooks('post_local_end', $arr); + + //notice( t('File activity updated') . EOL); + + if($no_activity) { + return; + } + + } + } + + if($no_activity) { + return; + } + + $arr = array(); + + $arr['aid'] = get_account_id(); + $arr['uid'] = $channel_id; + $arr['mid'] = $mid; + $arr['parent_mid'] = $mid; + $arr['item_flags'] = $item_flags; + $arr['author_xchan'] = $poster['xchan_hash']; + $arr['owner_xchan'] = $poster['xchan_hash']; + $arr['title'] = ''; + $arr['allow_cid'] = $allow_cid; + $arr['allow_gid'] = $allow_gid; + $arr['deny_cid'] = $deny_cid; + $arr['deny_gid'] = $deny_gid; + $arr['item_restrict'] = ITEM_HIDDEN; + $arr['item_private'] = 0; + $arr['verb'] = $verb; + $arr['body'] = $url; + + $post = item_store($arr); + $item_id = $post['item_id']; + + if($item_id) { + proc_run('php',"include/notifier.php","activity",$item_id); + } + + //call_hooks('post_local_end', $arr); + + //(($action === 'post') ? notice( t('File activity posted') . EOL) : notice( t('File activity dropped') . EOL)); + + return; + +} diff --git a/include/conversation.php b/include/conversation.php index 0d59ff92e..25c844fef 100644 --- a/include/conversation.php +++ b/include/conversation.php @@ -1572,7 +1572,7 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){ $tabs[] = array( 'label' => t('Files'), 'url' => $a->get_baseurl() . '/cloud/' . $nickname . ((get_observer_hash()) ? '' : '?f=&davguest=1'), - 'sel' => ((argv(0) == 'cloud') ? 'active' : ''), + 'sel' => ((argv(0) == 'cloud' || argv(0) == 'sharedwithme') ? 'active' : ''), 'title' => t('Files and Storage'), 'id' => 'files-tab', ); diff --git a/mod/filestorage.php b/mod/filestorage.php index 0a25617f0..67abc2eab 100644 --- a/mod/filestorage.php +++ b/mod/filestorage.php @@ -22,6 +22,8 @@ function filestorage_post(&$a) { $recurse = ((x($_POST, 'recurse')) ? intval($_POST['recurse']) : 0); $resource = ((x($_POST, 'filehash')) ? notags($_POST['filehash']) : ''); + $no_activity = ((x($_POST, 'no_activity')) ? intval($_POST['no_activity']) : 0); + if(! $resource) { notice(t('Item not found.') . EOL); return; @@ -37,6 +39,12 @@ function filestorage_post(&$a) { //Build directory tree and redirect $channel = $a->get_channel(); $cloudPath = get_parent_cloudpath($channel_id, $channel['channel_address'], $resource); + + $filename = find_filename_by_hash($channel_id, $resource); + $url = $cloudPath . $filename; + + file_activity($channel_id, $resource, $str_contact_allow, $str_group_allow, $str_contact_deny, $str_group_deny, $url, 'post', $no_activity); + goaway($cloudPath); } @@ -150,6 +158,7 @@ function filestorage_content(&$a) { '$submit' => t('Submit'), '$attach_btn_title' => t('Attach this file to a new post'), '$link_btn_title' => t('Show URL to this file'), + '$activity_btn_title' => t('Do not show in shared with me folder of your connections') )); echo $o; diff --git a/mod/sharedwithme.php b/mod/sharedwithme.php new file mode 100644 index 000000000..fe5a2b62e --- /dev/null +++ b/mod/sharedwithme.php @@ -0,0 +1,114 @@ +get_channel(); + + $is_owner = (local_user() && (local_user() == $channel['channel_id'])); + + $postverb = ACTIVITY_FILE . '/post/'; + $dropverb = ACTIVITY_FILE . '/drop/'; + + //maintenance - see if a file got dropped and remove it systemwide + $x = q("SELECT * FROM item WHERE verb LIKE '%s' AND uid = %d", + dbesc($dropverb . '%'), + intval(local_user()) + ); + + if($x) { + + foreach($x as $xx) { + + $hash = substr($xx['verb'], 39); + + $update = strpos($hash, '#'); + + if($update === false) { + q("DELETE FROM item WHERE verb = '%s' OR verb = '%s'", + dbesc($postverb . $hash), + dbesc($dropverb . $hash) + ); + } + + else { + + $arr = explode('#', $hash); + + q("DELETE FROM item WHERE mid != '%s' AND verb = '%s' OR verb = '%s'", + dbesc($arr[1]), + dbesc($postverb . $arr[0]), + dbesc($dropverb . $hash) + ); + + } + + } + + } + + //drop single file - localuser + if((argc() > 2) && (argv(2) === 'drop')) { + + $id = intval(argv(1)); + + q("DELETE FROM item WHERE id = %d AND uid = %d", + intval($id), + intval(local_user()) + ); + + goaway(z_root() . '/sharedfiles'); + } + + //drop all files - localuser + if((argc() > 1) && (argv(1) === 'dropall')) { + + q("DELETE FROM item WHERE verb LIKE '%s' AND uid = %d", + dbesc($postverb . '%'), + intval(local_user()) + ); + + goaway(z_root() . '/sharedfiles'); + } + + //list files + $r = q("SELECT * FROM item WHERE verb LIKE '%s' AND uid = %d", + dbesc($postverb . '%'), + intval(local_user()) + ); + + $o = profile_tabs($a, $is_owner, $channel['channel_id']); + + $o .= '
'; + + $o .= ' ' . t('Remove all entries') . ''; + + $o .= '

' . t('Files shared with me') . '

'; + + $o .= '
'; + + $o .= '
'; + + if($r) { + foreach($r as $rr) { + //don't display the files we shared with others + if($rr['owner_xchan'] != $channel['channel_hash']) { + unobscure($rr); + $url = rawurldecode($rr['body']); + $o .= '' . $url . ' 

'; + } + } + } + + $o .= '
'; + + return $o; + + +} + diff --git a/view/tpl/attach_edit.tpl b/view/tpl/attach_edit.tpl index 0147d35ba..5a8743919 100644 --- a/view/tpl/attach_edit.tpl +++ b/view/tpl/attach_edit.tpl @@ -14,7 +14,7 @@ -
+
{{if $isadir}}
{{/if}} +
+ +
- +  {{$shared}} + +
{{/if}}

{{$header}}

-- cgit v1.2.3 From 973398b915c5a31922a1351a82e919e64db0d543 Mon Sep 17 00:00:00 2001 From: marijus Date: Sun, 18 Jan 2015 15:15:48 +0100 Subject: fix profile tabs link --- mod/sharedwithme.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/sharedwithme.php b/mod/sharedwithme.php index fe5a2b62e..5a78333af 100644 --- a/mod/sharedwithme.php +++ b/mod/sharedwithme.php @@ -82,7 +82,7 @@ function sharedwithme_content(&$a) { intval(local_user()) ); - $o = profile_tabs($a, $is_owner, $channel['channel_id']); + $o = profile_tabs($a, $is_owner, $channel['channel_address']); $o .= '
'; -- cgit v1.2.3 From 9ac0922ff240589ae2b58cd45270385c1f8dd310 Mon Sep 17 00:00:00 2001 From: marijus Date: Sun, 18 Jan 2015 15:29:05 +0100 Subject: fix goaway link --- mod/sharedwithme.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/sharedwithme.php b/mod/sharedwithme.php index 5a78333af..2e2677a12 100644 --- a/mod/sharedwithme.php +++ b/mod/sharedwithme.php @@ -62,7 +62,7 @@ function sharedwithme_content(&$a) { intval(local_user()) ); - goaway(z_root() . '/sharedfiles'); + goaway(z_root() . '/sharedwithme'); } //drop all files - localuser @@ -73,7 +73,7 @@ function sharedwithme_content(&$a) { intval(local_user()) ); - goaway(z_root() . '/sharedfiles'); + goaway(z_root() . '/sharedwithme'); } //list files -- cgit v1.2.3 From b4faf4d90bca867ace578e7664f51c9921071945 Mon Sep 17 00:00:00 2001 From: marijus Date: Sun, 18 Jan 2015 15:31:13 +0100 Subject: fix link --- mod/sharedwithme.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/sharedwithme.php b/mod/sharedwithme.php index 2e2677a12..d4aa129ac 100644 --- a/mod/sharedwithme.php +++ b/mod/sharedwithme.php @@ -86,7 +86,7 @@ function sharedwithme_content(&$a) { $o .= '
'; - $o .= ' ' . t('Remove all entries') . ''; + $o .= ' ' . t('Remove all entries') . ''; $o .= '

' . t('Files shared with me') . '

'; @@ -100,7 +100,7 @@ function sharedwithme_content(&$a) { if($rr['owner_xchan'] != $channel['channel_hash']) { unobscure($rr); $url = rawurldecode($rr['body']); - $o .= '' . $url . ' 

'; + $o .= '' . $url . ' 

'; } } } -- cgit v1.2.3